Skip to content

Commit ea54426

Browse files
clydinalxhub
authored andcommitted
refactor(platform-browser): further reduce runtime code size of shared style host (angular#57951)
The `SharedStylesHost` class has been refactored to further reduce the runtime code size. SSR generated component styles are now added directly into the usage records to avoid the need for additional data structures and lookups when adding a component style. The code reduction in a prerelease newly generated Angular CLI application for production is ~190 bytes. Before: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-3X2VHGTM.js | main | 208.26 kB | 56.30 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.78 kB | 67.58 kB ``` After: ``` Initial chunk files | Names | Raw size | Estimated transfer size main-MGOZ6Q4F.js | main | 208.07 kB | 56.26 kB polyfills-FFHMD2TL.js | polyfills | 34.52 kB | 11.28 kB styles-5INURTSO.css | styles | 0 bytes | 0 bytes | Initial total | 242.59 kB | 67.54 kB ``` PR Close angular#57951
1 parent 187c3b2 commit ea54426

File tree

11 files changed

+89
-71
lines changed

11 files changed

+89
-71
lines changed

packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -818,6 +818,9 @@
818818
{
819819
"name": "createNotification"
820820
},
821+
{
822+
"name": "createStyleElement"
823+
},
821824
{
822825
"name": "createTView"
823826
},
@@ -1347,10 +1350,10 @@
13471350
"name": "remove"
13481351
},
13491352
{
1350-
"name": "removeAll"
1353+
"name": "removeClass"
13511354
},
13521355
{
1353-
"name": "removeClass"
1356+
"name": "removeElements"
13541357
},
13551358
{
13561359
"name": "removeFromArray"

packages/core/test/bundling/animations/bundle.golden_symbols.json

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -884,6 +884,9 @@
884884
{
885885
"name": "createPlatformFactory"
886886
},
887+
{
888+
"name": "createStyleElement"
889+
},
887890
{
888891
"name": "createTView"
889892
},
@@ -1425,10 +1428,10 @@
14251428
"name": "remove"
14261429
},
14271430
{
1428-
"name": "removeAll"
1431+
"name": "removeClass"
14291432
},
14301433
{
1431-
"name": "removeClass"
1434+
"name": "removeElements"
14321435
},
14331436
{
14341437
"name": "removeFromArray"

packages/core/test/bundling/cyclic_import/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -677,6 +677,9 @@
677677
{
678678
"name": "createPlatformFactory"
679679
},
680+
{
681+
"name": "createStyleElement"
682+
},
680683
{
681684
"name": "createTView"
682685
},
@@ -1152,7 +1155,7 @@
11521155
"name": "remove"
11531156
},
11541157
{
1155-
"name": "removeAll"
1158+
"name": "removeElements"
11561159
},
11571160
{
11581161
"name": "removeFromArray"

packages/core/test/bundling/defer/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -755,6 +755,9 @@
755755
{
756756
"name": "createNotification"
757757
},
758+
{
759+
"name": "createStyleElement"
760+
},
758761
{
759762
"name": "createTView"
760763
},
@@ -2397,7 +2400,7 @@
23972400
"name": "remove"
23982401
},
23992402
{
2400-
"name": "removeAll"
2403+
"name": "removeElements"
24012404
},
24022405
{
24032406
"name": "removeFromArray"

packages/core/test/bundling/forms_reactive/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -974,6 +974,9 @@
974974
{
975975
"name": "createPlatformFactory"
976976
},
977+
{
978+
"name": "createStyleElement"
979+
},
977980
{
978981
"name": "createTView"
979982
},
@@ -1719,7 +1722,7 @@
17191722
"name": "remove"
17201723
},
17211724
{
1722-
"name": "removeAll"
1725+
"name": "removeElements"
17231726
},
17241727
{
17251728
"name": "removeFromArray"

packages/core/test/bundling/forms_template_driven/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -938,6 +938,9 @@
938938
{
939939
"name": "createPlatformFactory"
940940
},
941+
{
942+
"name": "createStyleElement"
943+
},
941944
{
942945
"name": "createTView"
943946
},
@@ -1686,7 +1689,7 @@
16861689
"name": "remove"
16871690
},
16881691
{
1689-
"name": "removeAll"
1692+
"name": "removeElements"
16901693
},
16911694
{
16921695
"name": "removeFromArray"

packages/core/test/bundling/hydration/bundle.golden_symbols.json

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,9 @@
737737
{
738738
"name": "createOperatorSubscriber"
739739
},
740+
{
741+
"name": "createStyleElement"
742+
},
740743
{
741744
"name": "createTView"
742745
},
@@ -1259,15 +1262,15 @@
12591262
{
12601263
"name": "remove"
12611264
},
1262-
{
1263-
"name": "removeAll"
1264-
},
12651265
{
12661266
"name": "removeDehydratedView"
12671267
},
12681268
{
12691269
"name": "removeDehydratedViews"
12701270
},
1271+
{
1272+
"name": "removeElements"
1273+
},
12711274
{
12721275
"name": "removeFromArray"
12731276
},

packages/core/test/bundling/router/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1112,6 +1112,9 @@
11121112
{
11131113
"name": "createSegmentGroupFromRoute"
11141114
},
1115+
{
1116+
"name": "createStyleElement"
1117+
},
11151118
{
11161119
"name": "createTView"
11171120
},
@@ -1956,7 +1959,7 @@
19561959
"name": "remove"
19571960
},
19581961
{
1959-
"name": "removeAll"
1962+
"name": "removeElements"
19601963
},
19611964
{
19621965
"name": "removeFromArray"

packages/core/test/bundling/standalone_bootstrap/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -605,6 +605,9 @@
605605
{
606606
"name": "createNotification"
607607
},
608+
{
609+
"name": "createStyleElement"
610+
},
608611
{
609612
"name": "createTView"
610613
},
@@ -1011,7 +1014,7 @@
10111014
"name": "remove"
10121015
},
10131016
{
1014-
"name": "removeAll"
1017+
"name": "removeElements"
10151018
},
10161019
{
10171020
"name": "removeFromArray"

packages/core/test/bundling/todo/bundle.golden_symbols.json

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -794,6 +794,9 @@
794794
{
795795
"name": "createPlatformFactory"
796796
},
797+
{
798+
"name": "createStyleElement"
799+
},
797800
{
798801
"name": "createTView"
799802
},
@@ -1368,7 +1371,7 @@
13681371
"name": "remove"
13691372
},
13701373
{
1371-
"name": "removeAll"
1374+
"name": "removeElements"
13721375
},
13731376
{
13741377
"name": "removeFromArray"

0 commit comments

Comments
 (0)