refactor: change public const enums to enums (angular#51670)

frigus02 · dylhunn · commit ebbc7a27e82d · 2023-10-25T10:39:18.000-07:00
Angular recently gained a local compilation mode (see commit 345dd6d). This is intended to be used with the TypeScript compiler option isolatedModules, which bans imports of const enums. This changes all const enums tagged with @publicapi to regular enums. Fixes angular#46240 PR Close angular#51670
diff --git a/goldens/public-api/animations/index.md b/goldens/public-api/animations/index.md
@@ -89,7 +89,7 @@ export interface AnimationMetadata {
 }
 
 // @public
-export const enum AnimationMetadataType {
+export enum AnimationMetadataType {
     Animate = 4,
     AnimateChild = 9,
     AnimateRef = 10,
diff --git a/goldens/public-api/common/http/index.md b/goldens/public-api/common/http/index.md
@@ -2198,7 +2198,7 @@ export interface HttpSentEvent {
 }
 
 // @public
-export const enum HttpStatusCode {
+export enum HttpStatusCode {
     // (undocumented)
     Accepted = 202,
     // (undocumented)
diff --git a/goldens/public-api/platform-browser/index.md b/goldens/public-api/platform-browser/index.md
@@ -153,7 +153,7 @@ export interface HydrationFeature<FeatureKind extends HydrationFeatureKind> {
 }
 
 // @public
-export const enum HydrationFeatureKind {
+export enum HydrationFeatureKind {
     // (undocumented)
     HttpTransferCacheOptions = 1,
     // (undocumented)
diff --git a/goldens/public-api/router/index.md b/goldens/public-api/router/index.md
@@ -255,7 +255,7 @@ type Event_2 = NavigationStart | NavigationEnd | NavigationCancel | NavigationEr
 export { Event_2 as Event }
 
 // @public
-export const enum EventType {
+export enum EventType {
     // (undocumented)
     ActivationEnd = 14,
     // (undocumented)
@@ -433,7 +433,7 @@ export class NavigationCancel extends RouterEvent {
 }
 
 // @public
-export const enum NavigationCancellationCode {
+export enum NavigationCancellationCode {
     GuardRejected = 3,
     NoDataFromResolver = 2,
     Redirect = 0,
@@ -491,7 +491,7 @@ export class NavigationSkipped extends RouterEvent {
 }
 
 // @public
-export const enum NavigationSkippedCode {
+export enum NavigationSkippedCode {
     IgnoredByUrlHandlingStrategy = 1,
     IgnoredSameUrlNavigation = 0
 }
diff --git a/goldens/size-tracking/aio-payloads.json b/goldens/size-tracking/aio-payloads.json
@@ -2,7 +2,7 @@
   "aio": {
     "uncompressed": {
       "runtime": 4252,
-      "main": 506861,
+      "main": 507632,
       "polyfills": 33862,
       "styles": 60209,
       "light-theme": 34317,
@@ -12,7 +12,7 @@
   "aio-local": {
     "uncompressed": {
       "runtime": 4252,
-      "main": 501754,
+      "main": 507632,
       "polyfills": 33862,
       "styles": 60209,
       "light-theme": 34317,
diff --git a/goldens/size-tracking/integration-payloads.json b/goldens/size-tracking/integration-payloads.json
@@ -42,7 +42,7 @@
       "main": 221187,
       "polyfills": 33782,
       "node_modules_angular_animations_fesm2022_browser_mjs": 63981,
-      "default-node_modules_angular_animations_fesm2022_animations_mjs": 3828,
+      "default-node_modules_angular_animations_fesm2022_animations_mjs": 4264,
       "src_app_open-close_component_ts": 1321
     }
   },
@@ -56,7 +56,7 @@
   "platform-server/ngmodule/browser": {
     "uncompressed": {
       "runtime": 2688,
-      "main": 249925,
+      "main": 256333,
       "polyfills": 33778
     }
   },
diff --git a/packages/animations/src/animation_metadata.ts b/packages/animations/src/animation_metadata.ts
@@ -100,7 +100,7 @@ export declare interface AnimateChildOptions extends AnimationOptions {
  *
  * @publicApi
  */
-export const enum AnimationMetadataType {
+export enum AnimationMetadataType {
   /**
    * Associates a named animation state with a set of CSS styles.
    * See [`state()`](api/animations/state)
diff --git a/packages/common/http/src/response.ts b/packages/common/http/src/response.ts
@@ -358,7 +358,7 @@ export class HttpErrorResponse extends HttpResponseBase implements Error {
  * As per https://www.iana.org/assignments/http-status-codes/http-status-codes.xhtml
  * @publicApi
  */
-export const enum HttpStatusCode {
+export enum HttpStatusCode {
   Continue = 100,
   SwitchingProtocols = 101,
   Processing = 102,
diff --git a/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json b/packages/core/test/bundling/animations-standalone/bundle.golden_symbols.json
@@ -32,6 +32,9 @@
   {
     "name": "AnimationGroupPlayer"
   },
+  {
+    "name": "AnimationMetadataType"
+  },
   {
     "name": "AnimationRenderer"
   },
@@ -1295,9 +1298,6 @@
   {
     "name": "parseTimelineCommand"
   },
-  {
-    "name": "parseTransitionExpr"
-  },
   {
     "name": "processInjectorTypesWithProviders"
   },
diff --git a/packages/core/test/bundling/animations/bundle.golden_symbols.json b/packages/core/test/bundling/animations/bundle.golden_symbols.json
@@ -35,6 +35,9 @@
   {
     "name": "AnimationGroupPlayer"
   },
+  {
+    "name": "AnimationMetadataType"
+  },
   {
     "name": "AnimationRenderer"
   },
@@ -1367,9 +1370,6 @@
   {
     "name": "parseTimelineCommand"
   },
-  {
-    "name": "parseTransitionExpr"
-  },
   {
     "name": "platformBrowser"
   },
diff --git a/packages/core/test/bundling/hydration/bundle.golden_symbols.json b/packages/core/test/bundling/hydration/bundle.golden_symbols.json
@@ -209,6 +209,12 @@
   {
     "name": "HttpResponseBase"
   },
+  {
+    "name": "HttpStatusCode"
+  },
+  {
+    "name": "HydrationFeatureKind"
+  },
   {
     "name": "INJECTOR2"
   },
diff --git a/packages/core/test/bundling/router/bundle.golden_symbols.json b/packages/core/test/bundling/router/bundle.golden_symbols.json
@@ -251,6 +251,9 @@
   {
     "name": "EventManagerPlugin"
   },
+  {
+    "name": "EventType"
+  },
   {
     "name": "FilterOperator"
   },
@@ -455,6 +458,9 @@
   {
     "name": "NavigationCancel"
   },
+  {
+    "name": "NavigationCancellationCode"
+  },
   {
     "name": "NavigationEnd"
   },
@@ -467,6 +473,9 @@
   {
     "name": "NavigationSkipped"
   },
+  {
+    "name": "NavigationSkippedCode"
+  },
   {
     "name": "NavigationStart"
   },
diff --git a/packages/platform-browser/src/hydration.ts b/packages/platform-browser/src/hydration.ts
@@ -17,7 +17,7 @@ import {RuntimeErrorCode} from './errors';
  *
  * @publicApi
  */
-export const enum HydrationFeatureKind {
+export enum HydrationFeatureKind {
   NoHttpTransferCache,
   HttpTransferCacheOptions,
 }
diff --git a/packages/router/src/events.ts b/packages/router/src/events.ts
@@ -27,7 +27,7 @@ export const IMPERATIVE_NAVIGATION = 'imperative';
  *
  * @publicApi
  */
-export const enum EventType {
+export enum EventType {
   NavigationStart,
   NavigationEnd,
   NavigationCancel,
@@ -171,7 +171,7 @@ export class NavigationEnd extends RouterEvent {
  *
  * @publicApi
  */
-export const enum NavigationCancellationCode {
+export enum NavigationCancellationCode {
   /**
    * A navigation failed because a guard returned a `UrlTree` to redirect.
    */
@@ -196,7 +196,7 @@ export const enum NavigationCancellationCode {
  *
  * @publicApi
  */
-export const enum NavigationSkippedCode {
+export enum NavigationSkippedCode {
   /**
    * A navigation was skipped because the navigation URL was the same as the current Router URL.
    */

Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ export interface AnimationMetadata {`
`89`	`89`	`}`
`90`	`90`
`91`	`91`	`// @public`
`92`		`-export const enum AnimationMetadataType {`
	`92`	`+export enum AnimationMetadataType {`
`93`	`93`	`Animate = 4,`
`94`	`94`	`AnimateChild = 9,`
`95`	`95`	`AnimateRef = 10,`
Original file line number	Diff line number	Diff line change
`@@ -2198,7 +2198,7 @@ export interface HttpSentEvent {`
`2198`	`2198`	`}`
`2199`	`2199`
`2200`	`2200`	`// @public`
`2201`		`-export const enum HttpStatusCode {`
	`2201`	`+export enum HttpStatusCode {`
`2202`	`2202`	`// (undocumented)`
`2203`	`2203`	`Accepted = 202,`
`2204`	`2204`	`// (undocumented)`
Original file line number	Diff line number	Diff line change
`@@ -153,7 +153,7 @@ export interface HydrationFeature<FeatureKind extends HydrationFeatureKind> {`
`153`	`153`	`}`
`154`	`154`
`155`	`155`	`// @public`
`156`		`-export const enum HydrationFeatureKind {`
	`156`	`+export enum HydrationFeatureKind {`
`157`	`157`	`// (undocumented)`
`158`	`158`	`HttpTransferCacheOptions = 1,`
`159`	`159`	`// (undocumented)`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ export declare interface AnimateChildOptions extends AnimationOptions {`
`100`	`100`	`*`
`101`	`101`	`* @publicApi`
`102`	`102`	`*/`
`103`		`-export const enum AnimationMetadataType {`
	`103`	`+export enum AnimationMetadataType {`
`104`	`104`	`/**`
`105`	`105`	`* Associates a named animation state with a set of CSS styles.`
`106`	`106`	* See [`state()`](api/animations/state)
Original file line number	Diff line number	Diff line change
`@@ -32,6 +32,9 @@`
`32`	`32`	`{`
`33`	`33`	`"name": "AnimationGroupPlayer"`
`34`	`34`	`},`
	`35`	`+ {`
	`36`	`+ "name": "AnimationMetadataType"`
	`37`	`+ },`
`35`	`38`	`{`
`36`	`39`	`"name": "AnimationRenderer"`
`37`	`40`	`},`
`@@ -1295,9 +1298,6 @@`
`1295`	`1298`	`{`
`1296`	`1299`	`"name": "parseTimelineCommand"`
`1297`	`1300`	`},`
`1298`		`- {`
`1299`		`- "name": "parseTransitionExpr"`
`1300`		`- },`
`1301`	`1301`	`{`
`1302`	`1302`	`"name": "processInjectorTypesWithProviders"`
`1303`	`1303`	`},`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,9 @@`
`35`	`35`	`{`
`36`	`36`	`"name": "AnimationGroupPlayer"`
`37`	`37`	`},`
	`38`	`+ {`
	`39`	`+ "name": "AnimationMetadataType"`
	`40`	`+ },`
`38`	`41`	`{`
`39`	`42`	`"name": "AnimationRenderer"`
`40`	`43`	`},`
`@@ -1367,9 +1370,6 @@`
`1367`	`1370`	`{`
`1368`	`1371`	`"name": "parseTimelineCommand"`
`1369`	`1372`	`},`
`1370`		`- {`
`1371`		`- "name": "parseTransitionExpr"`
`1372`		`- },`
`1373`	`1373`	`{`
`1374`	`1374`	`"name": "platformBrowser"`
`1375`	`1375`	`},`