Skip to content

Commit ff028b8

Browse files
devversionalxhub
authored andcommitted
refactor(migrations): fix batch test of signal input migration failing (angular#57961)
The batch test was failing (it doesn't run on CI for resource reasons) because incompatibilities were not properly "incorporated" in batch execution mode (due to enum values of 0 being incorrectly checked via truthy). This is only visible in batch scenarios in two cases: - when a class was manually instantiated, between targets - when a class was overridden by a derived class, between targets PR Close angular#57961
1 parent 2fe393a commit ff028b8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

packages/core/schematics/migrations/signal-migration/src/batch/populate_global_data.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@ export function populateKnownInputsFromGlobalData(
2424
}
2525

2626
const inputMetadata = knownInputs.get({key})!;
27-
if (info.memberIncompatibility) {
27+
if (info.memberIncompatibility !== null) {
2828
knownInputs.markFieldIncompatible(inputMetadata.descriptor, {
2929
context: null, // No context serializable.
3030
reason: info.memberIncompatibility,
3131
});
3232
}
3333

34-
if (info.owningClassIncompatibility) {
34+
if (info.owningClassIncompatibility !== null) {
3535
knownInputs.markClassIncompatible(
3636
inputMetadata.container.clazz,
3737
info.owningClassIncompatibility,

0 commit comments

Comments
 (0)