Improve lint config

Author: Shinigami92

.eslintrc.js

@@ -32,9 +32,14 @@ module.exports = defineConfig({
 		quotes: ['error', 'single', { avoidEscape: true }],
 		semi: ['error', 'always'],
 
-		'@typescript-eslint/ban-ts-comment': 'off',
+		'@typescript-eslint/array-type': ['warn', { default: 'array-simple', readonly: 'generic' }],
+		'@typescript-eslint/ban-ts-comment': ['error', { 'ts-expect-error': 'allow-with-description' }],
+		'@typescript-eslint/ban-types': 'warn',
+		'@typescript-eslint/consistent-type-imports': 'error',
 		'@typescript-eslint/explicit-function-return-type': ['error', { allowExpressions: true }],
+		'@typescript-eslint/explicit-member-accessibility': 'error',
 		'@typescript-eslint/indent': ['error', 'tab', { SwitchCase: 1, ignoredNodes: ['MemberExpression'] }],
+		'@typescript-eslint/lines-between-class-members': ['warn', 'always', { exceptAfterSingleLine: true }],
 		'@typescript-eslint/member-ordering': 'warn',
 		'@typescript-eslint/no-explicit-any': 'off',
 		'@typescript-eslint/no-inferrable-types': 'off',
@@ -44,7 +49,9 @@ module.exports = defineConfig({
 		'@typescript-eslint/no-unused-vars': 'off',
 		'@typescript-eslint/prefer-nullish-coalescing': 'warn',
 		'@typescript-eslint/prefer-optional-chain': 'warn',
-		'@typescript-eslint/prefer-readonly': ['warn'],
+		'@typescript-eslint/prefer-readonly': 'warn',
+		'@typescript-eslint/prefer-reduce-type-parameter': 'warn',
+		'@typescript-eslint/require-await': 'warn',
 		'@typescript-eslint/restrict-template-expressions': 'off',
 		'@typescript-eslint/typedef': ['warn', { memberVariableDeclaration: true, variableDeclaration: true }],
 

src/index.ts

@@ -12,7 +12,8 @@ import type {
 } from 'prettier';
 import type { Token } from 'pug-lexer';
 import * as lex from 'pug-lexer';
-import { createLogger, Logger, LogLevel } from './logger';
+import type { Logger } from './logger';
+import { createLogger, LogLevel } from './logger';
 import type { PugParserOptions } from './options';
 import { options as pugOptions } from './options';
 import { convergeOptions } from './options/converge';

src/options/attribute-sorting/utils.ts

@@ -86,7 +86,7 @@ export function compareAttributeToken(
  * @param compare A function for comparing the values.
  * @returns The sorted array.
  */
-export function stableSort<T>(array: readonly T[], compare: CompareFunction<T>): T[] {
+export function stableSort<T>(array: ReadonlyArray<T>, compare: CompareFunction<T>): T[] {
 	const entries: Array<[T, number]> = array.map((value, index) => [value, index]);
 	entries.sort((a, b) => {
 		const order: CompareResult = compare(a[0], b[0]);
@@ -105,7 +105,7 @@ export function stableSort<T>(array: readonly T[], compare: CompareFunction<T>):
  * @param compareFn A function for comparing the values.
  * @returns The sorted array.
  */
-export function partialSort<T>(arr: readonly T[], start: number, end: number, compareFn: CompareFunction<T>): T[] {
+export function partialSort<T>(arr: ReadonlyArray<T>, start: number, end: number, compareFn: CompareFunction<T>): T[] {
 	const preSort: T[] = arr.slice(0, start);
 	const postSort: T[] = arr.slice(end);
 	const attributes: T[] = arr.slice(start, end);

src/options/index.ts

@@ -5,8 +5,8 @@ import {
 	PUG_SORT_ATTRIBUTES_END_OPTION,
 	PUG_SORT_ATTRIBUTES_OPTION
 } from './attribute-sorting';
+import type { ArrowParens } from './common';
 import {
-	ArrowParens,
 	PUG_ARROW_PARENS_OPTION,
 	PUG_BRACKET_SAME_LINE_OPTION,
 	PUG_BRACKET_SPACING_OPTION,

src/printer.ts

@@ -318,7 +318,7 @@ export class PugPrinter {
 					case 'eos':
 						// TODO: These tokens write directly into the result
 						this.result = results.join('');
-						// @ts-expect-error
+						// @ts-expect-error: The function is always valid
 						this[token.type](token);
 						results.length = 0;
 						results.push(this.result);
@@ -335,7 +335,7 @@ export class PugPrinter {
 						if (typeof this[token.type] !== 'function') {
 							throw new Error('Unhandled token: ' + JSON.stringify(token));
 						}
-						// @ts-expect-error
+						// @ts-expect-error: If the function would be invalid, it would be caught above
 						results.push(this[token.type](token));
 						break;
 					}

tests/common.ts

@@ -1,4 +1,4 @@
-import { AttributeToken } from 'pug-lexer';
+import type { AttributeToken } from 'pug-lexer';
 
 /**
  * Creates a fake attribute token.

tests/options/emptyAttributes/empty-attributes.test.ts

@@ -1,8 +1,8 @@
 import { readFileSync } from 'fs';
 import { resolve } from 'path';
 import { format } from 'prettier';
-import { AttributeToken } from 'pug-lexer';
-import { PugEmptyAttributes, PugEmptyAttributesForceQuotes } from '../../../src/options/empty-attributes';
+import type { AttributeToken } from 'pug-lexer';
+import type { PugEmptyAttributes, PugEmptyAttributesForceQuotes } from '../../../src/options/empty-attributes';
 import { formatEmptyAttribute } from '../../../src/options/empty-attributes/utils';
 import { createAttributeToken } from '../../common';
 import { plugin } from './../../../src/index';

tests/options/pugExplicitDiv/pug-explicit-div.test.ts

@@ -1,6 +1,7 @@
 import { readFileSync } from 'fs';
 import { resolve } from 'path';
-import { format, Options } from 'prettier';
+import type { Options } from 'prettier';
+import { format } from 'prettier';
 import { plugin } from '../../../src/index';
 
 describe('Options', () => {

tests/options/sortAttributes/sort-attributes.test.ts

@@ -1,7 +1,7 @@
 import { readFileSync } from 'fs';
 import { resolve } from 'path';
 import { format } from 'prettier';
-import { PugSortAttributes } from '../../../src/options/attribute-sorting/index';
+import type { PugSortAttributes } from '../../../src/options/attribute-sorting/index';
 import { compareAttributeToken, stableSort } from '../../../src/options/attribute-sorting/utils';
 import { createAttributeToken } from '../../common';
 import { plugin } from './../../../src/index';
@@ -14,9 +14,8 @@ describe('Options', () => {
 			const actual: string = format(code, {
 				parser: 'pug',
 				plugins: [plugin],
-				// @ts-ignore
+
 				pugSortAttributesBeginning: ['v-for', ':key', 'src', 'alt'],
-				// @ts-ignore
 				pugSortAttributesEnd: ['@click']
 			});
 

tests/pragma/detect-pragma/detect-pragma.test.ts

@@ -1,6 +1,6 @@
 import { readFileSync } from 'fs';
 import { resolve } from 'path';
-import { Parser } from 'prettier';
+import type { Parser } from 'prettier';
 import { parsers } from './../../../src/index';
 
 /* eslint @typescript-eslint/no-non-null-assertion: off */