fix: use overrideConfigFile: true + overrideConfig instead (#1193)

Author: JounQin

.changeset/late-eels-march.md

@@ -0,0 +1,5 @@
+---
+"prettier-eslint": patch
+---
+
+fix: use `overrideConfigFile: true` + `overrideConfig` instead

src/index.ts

@@ -228,6 +228,8 @@ function createPrettify(formatOptions: PrettierOptions, prettierPath: string) {
 
 function createEslintFix(eslintConfig: ESLintConfig, eslintPath: string) {
   return async function eslintFix(text: string, filePath?: string) {
+    eslintConfig.overrideConfigFile = true;
+
     eslintConfig.overrideConfig = {
       languageOptions: eslintConfig.languageOptions,
       rules: eslintConfig.rules,
@@ -246,8 +248,8 @@ function createEslintFix(eslintConfig: ESLintConfig, eslintPath: string) {
     delete eslintConfig.plugins;
     delete eslintConfig.settings;
 
-    // FIXME: Seems to be an ESLint core issue: `Key "plugins": Cannot redefine plugin`
-    delete eslintConfig.overrideConfig.plugins;
+    // FIXME: Seems like a bug in eslint - https://github.com/eslint/eslint/issues/19722
+    delete eslintConfig.overrideConfig.plugins!['@'];
 
     const eslint = await getESLint(eslintPath, eslintConfig);
     try {

test/index.spec.ts

@@ -1,4 +1,4 @@
-/* eslint-disable @typescript-eslint/unbound-method, sonarjs/no-commented-code */
+/* eslint-disable @typescript-eslint/unbound-method */
 
 // eslint-disable-next-line unicorn/prefer-node-protocol -- mocked
 import fsMock_ from 'fs';
@@ -131,7 +131,7 @@ const tests: Array<{
   {
     title: 'without a filePath and no config',
     input: { text: defaultInputText() },
-    output: prettierLastOutput(),
+    output: noopOutput(),
   },
   {
     title: 'inferring bracketSpacing',
@@ -187,7 +187,7 @@ const tests: Array<{
         languageOptions: { globals: { windows: 'writable' } },
       },
     },
-    output: prettierLastOutput(),
+    output: noopOutput(),
   },
   {
     title: 'CSS example',
@@ -284,7 +284,7 @@ const tests: Array<{
         },
       },
     },
-    output: "var foo = { bar: 'baz' };",
+    output: 'var foo = { bar: "baz" };',
   },
 ];
 
@@ -524,14 +524,14 @@ function defaultInputText() {
   `;
 }
 
-// function noopOutput() {
-//   return `
-//     function foo() {
-//       // stuff
-//       console.log("Hello world!", and, stuff);
-//     }
-//   `;
-// }
+function noopOutput() {
+  return `
+    function foo() {
+      // stuff
+      console.log("Hello world!", and, stuff);
+    }
+  `;
+}
 
 function defaultOutput() {
   return `