Refactoring and cleanup (#3835)

* Refactoring and cleanup

* switch to lefthook instead of husky

* updated lefthook config

* Updated eslint

* merge cleanup

* approve lefthook

* increased test timeout

* ignore tests in codeql

* Fix typo

* Fix instructions

* updated lefhook

Author: ntotten

.eslintignore

@@ -0,0 +1,4 @@
+name: "CodeQL Config"
+
+paths-ignore:
+  - test-fixtures

.eslintrc.js

@@ -6,7 +6,7 @@ This is the official Prettier VS Code extension (`prettier.prettier-vscode`). It
 
 - Use `pnpm` as the package manager
 - Run `pnpm install` to install dependencies
-- Run `pnpm webpack` to build for development
+- Run `pnpm compile` to build for development
 - Run `pnpm test` to run tests (no VS Code instance can be running)
 - Run `pnpm lint` to check linting
 - Run `pnpm prettier` to format code
@@ -23,10 +23,9 @@ Core components:
 - `src/extension.ts` - Extension activation, creates ModuleResolver, PrettierEditService, and StatusBar
 - `src/PrettierEditService.ts` - Registers VS Code document formatting providers, handles format requests
 - `src/ModuleResolver.ts` - Resolves local/global Prettier installations, falls back to bundled Prettier
-- `src/PrettierWorkerInstance.ts` - Runs Prettier v3+ in a worker thread for async formatting
-- `src/PrettierMainThreadInstance.ts` - Runs Prettier v2 synchronously on main thread
+- `src/PrettierInstance.ts` - Interface for Prettier loading, with `PrettierMainThreadInstance` and `PrettierWorkerInstance` implementations
 
-Webpack produces two bundles:
+esbuild produces two bundles:
 
 - Node bundle (`dist/extension.js`) for desktop VS Code
 - Web bundle (`dist/web-extension.js`) for vscode.dev/browser
@@ -70,7 +69,7 @@ When reviewing pull requests, focus on:
 ### Performance
 
 - Avoid blocking the extension host main thread
-- Prettier v3+ should use worker threads via `PrettierWorkerInstance`
+- `PrettierWorkerInstance` runs Prettier in a worker thread to avoid blocking
 - Module and config resolution results are cached appropriately
 
 ### Browser Compatibility

.github/codeql/codeql-config.yml

@@ -27,8 +27,8 @@ This is a VS Code extension. Follow these patterns:
 
 ## Prettier Integration
 
-- Support both Prettier v2 (sync, main thread) and v3+ (async, worker thread)
-- `PrettierMainThreadInstance` for v2, `PrettierWorkerInstance` for v3+
+- Support both Prettier v2 and v3+ via `PrettierInstance` interface
+- `PrettierMainThreadInstance` loads directly, `PrettierWorkerInstance` uses worker thread
 - Module resolution: local install → global install → bundled Prettier
 - Handle `.prettierrc`, `.prettierignore`, and `package.json` prettier config
 

.github/copilot-instructions.md

@@ -3,6 +3,7 @@
   "editor.codeActionsOnSave": {
     "source.fixAll.eslint": "explicit"
   },
+  "eslint.useFlatConfig": true,
   "editor.formatOnSave": true,
   "editor.defaultFormatter": "prettier.prettier-vscode",
   "editor.formatOnType": false,

.github/instructions/typescript.instructions.md

@@ -1,5 +1,4 @@
 .github/
-.husky/
 .vscode/
 .vscode-test/
 .vscode-test-web/
@@ -14,10 +13,12 @@ test-fixtures/
 .prettierrc
 CODE_OF_CONDUCT.md
 CONTRIBUTING.md
-CONTRIBUTORS.md
 tsconfig.json
-webpack.config.js
-yarn.lock
+tsconfig.scripts.json
+eslint.config.mjs
+lefthook.yml
+esbuild.mjs
+pnpm-lock.yaml
 dist/*.map
 
 node_modules/

.husky/.gitignore

@@ -86,11 +86,12 @@ Web tests are located in `src/test/web/suite/` and test the extension's browser
 - Caches resolved modules and configurations
 - Handles Workspace Trust restrictions
 
-**Prettier Instance Wrappers**:
+**Prettier Instance** (`PrettierInstance.ts`, `PrettierMainThreadInstance.ts`, `PrettierWorkerInstance.ts`):
 
-- `PrettierWorkerInstance.ts`: Runs Prettier v3+ in a worker thread for async formatting
-- `PrettierMainThreadInstance.ts`: Runs Prettier v2 synchronously on main thread
-- Worker script lives in `src/worker/prettier-instance-worker.js`
+- `PrettierInstance` is an interface with two implementations
+- `PrettierMainThreadInstance` loads Prettier directly via `require()`
+- `PrettierWorkerInstance` loads Prettier in a worker thread to avoid blocking
+- Works with both Prettier v2 and v3+
 
 ### Bundling