Skip to content

Commit 335efde

Browse files
ntottenCopilot
andauthored
Update workflows and various housekeeping (#3826)
* Update workflows and various housekeeping * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]>
1 parent c948693 commit 335efde

34 files changed

+2173
-265
lines changed

.claude/settings.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
{
22
"permissions": {
3-
"allow": ["WebFetch(domain:prettier.io)", "Bash(npm run prettier:*)"],
3+
"allow": [
4+
"WebFetch(domain:prettier.io)",
5+
"Bash(npm run prettier:*)",
6+
"mcp__ide__getDiagnostics"
7+
],
48
"deny": [],
59
"ask": []
610
}

.devcontainer/Dockerfile

Lines changed: 7 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,10 @@
1-
# See here for image contents: https://github.com/microsoft/vscode-dev-containers/tree/v0.209.6/containers/typescript-node/.devcontainer/base.Dockerfile
1+
# See here for image contents: https://github.com/devcontainers/images/tree/main/src/typescript-node
22

3-
# [Choice] Node.js version (use -bullseye variants on local arm64/Apple Silicon): 16, 14, 12, 16-bullseye, 14-bullseye, 12-bullseye, 16-buster, 14-buster, 12-buster
4-
ARG VARIANT="18-bullseye"
5-
FROM mcr.microsoft.com/vscode/devcontainers/typescript-node:0-${VARIANT}
3+
# [Choice] Node.js version: 22, 20, 18 (use -bookworm or -bullseye variants)
4+
ARG VARIANT="22-bookworm"
5+
FROM mcr.microsoft.com/devcontainers/typescript-node:${VARIANT}
66

7-
# [Optional] Uncomment this section to install additional OS packages.
7+
# Install PHP for Prettier PHP plugin testing
88
RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
9-
&& apt-get -y install --no-install-recommends php
10-
11-
# [Optional] Uncomment if you want to install an additional version of node using nvm
12-
# ARG EXTRA_NODE_VERSION=10
13-
# RUN su node -c "source /usr/local/share/nvm/nvm.sh && nvm install ${EXTRA_NODE_VERSION}"
14-
15-
# [Optional] Uncomment if you want to install more global node packages
16-
# RUN su node -c "npm install -g <your-package-list -here>"
9+
&& apt-get -y install --no-install-recommends php \
10+
&& apt-get clean && rm -rf /var/lib/apt/lists/*

.devcontainer/devcontainer.json

Lines changed: 13 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,33 +1,27 @@
1-
// For format details, see https://aka.ms/devcontainer.json. For config options, see the README at:
2-
// https://github.com/microsoft/vscode-dev-containers/tree/v0.209.6/containers/typescript-node
1+
// For format details, see https://containers.dev/implementors/json_reference/
32
{
43
"name": "Node.js & TypeScript",
54
"build": {
65
"dockerfile": "Dockerfile",
7-
// Update 'VARIANT' to pick a Node version: 16, 14, 12.
8-
// Append -bullseye or -buster to pin to an OS version.
9-
// Use -bullseye variants on local on arm64/Apple Silicon.
106
"args": {
11-
"VARIANT": "18-bullseye"
7+
"VARIANT": "22-bookworm"
128
}
139
},
1410

15-
// Set *default* container specific settings.json values on container create.
16-
"settings": {},
17-
18-
// Add the IDs of extensions you want installed when the container is created.
19-
"extensions": [
20-
"dbaeumer.vscode-eslint",
21-
"prettier.prettier-vscode",
22-
"streetsidesoftware.code-spell-checker"
23-
],
24-
25-
// Use 'forwardPorts' to make a list of ports inside the container available locally.
26-
// "forwardPorts": [],
11+
"customizations": {
12+
"vscode": {
13+
"extensions": [
14+
"dbaeumer.vscode-eslint",
15+
"prettier.prettier-vscode",
16+
"streetsidesoftware.code-spell-checker"
17+
],
18+
"settings": {}
19+
}
20+
},
2721

2822
// Use 'postCreateCommand' to run commands after the container is created.
2923
"postCreateCommand": "yarn install",
3024

31-
// Comment out connect as root instead. More info: https://aka.ms/vscode-remote/containers/non-root.
25+
// Run as the node user for better security.
3226
"remoteUser": "node"
3327
}

.github/ISSUE_TEMPLATE/Bug_report.md

Lines changed: 0 additions & 63 deletions
This file was deleted.

.github/ISSUE_TEMPLATE/Feature_request.md

Lines changed: 0 additions & 16 deletions
This file was deleted.
Lines changed: 142 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,142 @@
1+
name: Bug Report
2+
description: Report a bug with the Prettier VS Code extension
3+
labels: ["bug"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
## Before You Start
9+
10+
- **Formatting issues** (how Prettier formats your code) should be reported to [prettier/prettier](https://github.com/prettier/prettier/issues), not here.
11+
- **Support questions** should be asked on [Stack Overflow](https://stackoverflow.com/questions/tagged/prettier).
12+
- Please search [existing issues](https://github.com/prettier/prettier-vscode/issues) first.
13+
14+
See our [guide on writing a good issue](https://github.com/prettier/prettier-vscode/blob/main/docs/writing-an-issue.md).
15+
16+
- type: checkboxes
17+
id: preflight
18+
attributes:
19+
label: Preflight Checklist
20+
options:
21+
- label: I have read the [troubleshooting guide](https://github.com/prettier/prettier-vscode/blob/main/docs/troubleshooting.md)
22+
required: true
23+
- label: I have searched [existing issues](https://github.com/prettier/prettier-vscode/issues) and this is not a duplicate
24+
required: true
25+
- label: This is a bug with the **VS Code extension**, not with how Prettier formats code
26+
required: true
27+
28+
- type: textarea
29+
id: summary
30+
attributes:
31+
label: Issue Summary
32+
description: A clear and concise description of the bug.
33+
placeholder: Describe the bug...
34+
validations:
35+
required: true
36+
37+
- type: input
38+
id: repo
39+
attributes:
40+
label: Reproduction Repository
41+
description: |
42+
Link to a **public GitHub repository** that reproduces the issue.
43+
This is the most important part - without it, we likely cannot help you.
44+
placeholder: https://github.com/username/repo-name
45+
validations:
46+
required: true
47+
48+
- type: textarea
49+
id: steps
50+
attributes:
51+
label: Steps to Reproduce
52+
description: Detailed steps to reproduce the issue.
53+
placeholder: |
54+
1. Clone the repository above
55+
2. Open in VS Code
56+
3. Open file X
57+
4. Run "Format Document"
58+
5. See error
59+
validations:
60+
required: true
61+
62+
- type: textarea
63+
id: expected
64+
attributes:
65+
label: Expected Behavior
66+
description: What did you expect to happen?
67+
placeholder: Describe what should have happened...
68+
validations:
69+
required: true
70+
71+
- type: textarea
72+
id: actual
73+
attributes:
74+
label: Actual Behavior
75+
description: What actually happened?
76+
placeholder: Describe what actually happened...
77+
validations:
78+
required: true
79+
80+
- type: dropdown
81+
id: os
82+
attributes:
83+
label: Operating System
84+
options:
85+
- Windows
86+
- macOS
87+
- Linux
88+
validations:
89+
required: true
90+
91+
- type: input
92+
id: vscode-version
93+
attributes:
94+
label: VS Code Version
95+
description: "Help > About > Copy"
96+
placeholder: "e.g., 1.85.0"
97+
validations:
98+
required: true
99+
100+
- type: input
101+
id: extension-version
102+
attributes:
103+
label: Prettier Extension Version
104+
description: Check in Extensions panel
105+
placeholder: "e.g., 10.4.0"
106+
validations:
107+
required: true
108+
109+
- type: input
110+
id: prettier-version
111+
attributes:
112+
label: Prettier Version
113+
description: "Run: npx prettier --version"
114+
placeholder: "e.g., 3.2.0"
115+
validations:
116+
required: true
117+
118+
- type: textarea
119+
id: logs
120+
attributes:
121+
label: Prettier Extension Logs
122+
description: |
123+
Click "Prettier" in the VS Code status bar, then copy the **full log output**.
124+
DO NOT use screenshots - copy and paste the text.
125+
render: text
126+
placeholder: |
127+
Paste your Prettier log output here...
128+
129+
To get logs:
130+
1. Click "Prettier" in the bottom status bar
131+
2. Copy all the output from the panel
132+
validations:
133+
required: true
134+
135+
- type: textarea
136+
id: config
137+
attributes:
138+
label: Prettier Configuration
139+
description: Contents of your Prettier config file (if any)
140+
render: json
141+
placeholder: |
142+
Paste contents of .prettierrc, .prettierrc.json, etc.

.github/ISSUE_TEMPLATE/config.yaml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Prettier Formatting Issue
4+
url: https://github.com/prettier/prettier/issues/new/choose
5+
about: For issues with how Prettier formats your code (not VS Code specific)
6+
- name: Stack Overflow
7+
url: https://stackoverflow.com/questions/tagged/prettier-vscode
8+
about: For support and configuration questions
9+
- name: Prettier Documentation
10+
url: https://prettier.io/docs/en/index.html
11+
about: Read the Prettier documentation
12+
- name: Extension Documentation
13+
url: https://github.com/prettier/prettier-vscode#readme
14+
about: Read the extension documentation and settings guide

.github/ISSUE_TEMPLATE/config.yml

Lines changed: 0 additions & 5 deletions
This file was deleted.
Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
name: Feature Request
2+
description: Suggest an idea for the Prettier VS Code extension
3+
labels: ["enhancement"]
4+
body:
5+
- type: markdown
6+
attributes:
7+
value: |
8+
## Before You Start
9+
10+
- **Formatting behavior changes** should be requested at [prettier/prettier](https://github.com/prettier/prettier/issues).
11+
- This is for VS Code **extension** features only.
12+
- Please search [existing issues](https://github.com/prettier/prettier-vscode/issues) first.
13+
14+
- type: checkboxes
15+
id: preflight
16+
attributes:
17+
label: Preflight Checklist
18+
options:
19+
- label: I have searched [existing issues](https://github.com/prettier/prettier-vscode/issues) and this is not a duplicate
20+
required: true
21+
- label: This is a feature for the **VS Code extension**, not for Prettier's formatting behavior
22+
required: true
23+
24+
- type: textarea
25+
id: problem
26+
attributes:
27+
label: Problem Description
28+
description: Is your feature request related to a problem? Describe it.
29+
placeholder: I'm always frustrated when...
30+
validations:
31+
required: true
32+
33+
- type: textarea
34+
id: solution
35+
attributes:
36+
label: Proposed Solution
37+
description: Describe the solution you'd like.
38+
placeholder: I would like the extension to...
39+
validations:
40+
required: true
41+
42+
- type: textarea
43+
id: alternatives
44+
attributes:
45+
label: Alternatives Considered
46+
description: Describe any alternative solutions or features you've considered.
47+
placeholder: I've also considered...
48+
49+
- type: textarea
50+
id: context
51+
attributes:
52+
label: Additional Context
53+
description: Add any other context, mockups, or screenshots about the feature request.

0 commit comments

Comments
 (0)