improved error output of string exceptions

Author: ntotten

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to the "prettier-vscode" extension will be documented in thi
 
 <!-- Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how to structure this file. -->
 
+## [5.1.3]
+
+- Improved error output of certain plugin exceptions.
+
 ## [5.1.2]
 
 - Added error logging for unusual prettier exceptions.

package.json

@@ -2,7 +2,7 @@
   "name": "prettier-vscode",
   "displayName": "Prettier - Code formatter",
   "description": "Code formatter using prettier",
-  "version": "5.1.2",
+  "version": "5.1.3",
   "publisher": "esbenp",
   "author": "Prettier <@prettiercode>",
   "galleryBanner": {

src/LoggingService.ts

@@ -46,21 +46,23 @@ export class LoggingService {
     }
   }
 
-  public logError(message: string, error?: Error) {
+  public logError(message: string, error?: Error | string) {
     if (this.logLevel === "NONE") {
       return;
     }
     this.logMessage(message, "ERROR");
-    if (error?.message || error?.stack) {
-      // Try to print the most useful error message
+    if (typeof error === "string") {
+      // Errors as a string usually only happen with
+      // plugins that don't return the expected error.
+      this.outputChannel.appendLine(error);
+    } else if (error?.message || error?.stack) {
       if (error?.message) {
         this.logMessage(error.message, "ERROR");
       }
       if (error?.stack) {
         this.outputChannel.appendLine(error.stack);
       }
     } else if (error) {
-      // Weird error returned, just output the whole thing
       this.logObject(error);
     }
   }