Skip to content

Commit 5c53e86

Browse files
authored
Use github formatter in e2e tests (#358)
As it is less likely to change between versions
1 parent 221b1c9 commit 5c53e86

File tree

2 files changed

+13
-16
lines changed

2 files changed

+13
-16
lines changed

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@
5353
"prettier": "^3.0.0",
5454
"prettier-plugin-astro": "^0.12.1",
5555
"prettier-plugin-svelte": "^3.0.0",
56-
"strip-ansi": "^7.1.0",
5756
"stylelint": "^16.0.1",
5857
"stylelint-test-rule-node": "^0.2.0",
5958
"svelte": "^4.1.0",

test/stylelint-prettier-e2e.test.js

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
import {describe, test} from 'node:test';
22
import assert from 'node:assert/strict';
33
import {spawnSync} from 'node:child_process';
4-
import {resolve, dirname} from 'node:path';
4+
import {resolve, sep, dirname} from 'node:path';
55
import {fileURLToPath} from 'node:url';
6-
import stripAnsi from 'strip-ansi';
76

87
const __dirname = dirname(fileURLToPath(import.meta.url));
98

@@ -18,10 +17,7 @@ describe('E2E Tests', () => {
1817
const result = runStylelint('*.css');
1918

2019
const expectedResult = `
21-
check.invalid.css
22-
2:25 ✖ Replace ""x"" with "'x'" prettier/prettier
23-
24-
1 problem (1 error, 0 warnings)
20+
::error file=check.invalid.css,line=2,col=25,endLine=2,endColumn=28,title=Stylelint problem::Replace ""x"" with "'x'" (prettier/prettier)
2521
`.trim();
2622

2723
assert.strictEqual(result.output, '');
@@ -33,11 +29,8 @@ check.invalid.css
3329
const result = runStylelint('*.scss');
3430

3531
const expectedResult = `
36-
check.invalid.scss
37-
2:25 ✖ Replace ""x"" with "'x'" prettier/prettier
38-
8:14 ✖ Insert "," prettier/prettier
39-
40-
2 problems (2 errors, 0 warnings)
32+
::error file=check.invalid.scss,line=2,col=25,endLine=2,endColumn=28,title=Stylelint problem::Replace ""x"" with "'x'" (prettier/prettier)
33+
::error file=check.invalid.scss,line=8,col=14,endLine=8,endColumn=15,title=Stylelint problem::Insert "," (prettier/prettier)
4134
`.trim();
4235

4336
assert.strictEqual(result.output, '');
@@ -76,14 +69,19 @@ check.invalid.scss
7669

7770
function runStylelint(pattern) {
7871
const stylelintCmd = resolve(`${__dirname}/../node_modules/.bin/stylelint`);
72+
const cwd = `${__dirname}/fixtures`;
7973

80-
const result = spawnSync(stylelintCmd, [pattern], {
81-
cwd: `${__dirname}/fixtures`,
74+
// Use github formatter as it is less likely to change across releases
75+
const result = spawnSync(stylelintCmd, ['--formatter=github', pattern], {
76+
cwd,
8277
});
8378

8479
return {
8580
status: result.status,
86-
output: stripAnsi(result.stdout.toString().trim()),
87-
error: stripAnsi(result.stderr.toString().trim()),
81+
output: result.stdout.toString().trim(),
82+
error: result.stderr
83+
.toString()
84+
.trim()
85+
.replaceAll(`file=${cwd}${sep}`, 'file='),
8886
};
8987
}

0 commit comments

Comments
 (0)