Skip to content

Commit 2d7a9cb

Browse files
author
István Beregszászi
authored
Merge pull request #392 from prezly/feature/dev-21252-do-not-provide-content-when-listing-templates
[DEV-21252] Use `ExtendedTemplate` for template-related endpoints
2 parents a4f4eed + 11fab61 commit 2d7a9cb

File tree

2 files changed

+19
-10
lines changed

2 files changed

+19
-10
lines changed

src/endpoints/Templates/Client.ts

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { DeferredJobsApiClient } from '../../api';
22
import { routing } from '../../routing';
3-
import type { Template } from '../../types';
3+
import type { ExtendedTemplate, Template } from '../../types';
44

55
import type { CreateRequest, UpdateRequest } from './types';
66

@@ -15,25 +15,31 @@ export function createClient(api: DeferredJobsApiClient) {
1515
return templates;
1616
}
1717

18-
async function get(templateId: TemplateId): Promise<Template> {
18+
async function get(templateId: TemplateId): Promise<ExtendedTemplate> {
1919
const url = routing.templatesUrl;
20-
const { template } = await api.get<{ template: Template }>(`${url}/${templateId}`);
20+
const { template } = await api.get<{ template: ExtendedTemplate }>(`${url}/${templateId}`);
2121
return template;
2222
}
2323

24-
async function create(payload: CreateRequest): Promise<Template> {
24+
async function create(payload: CreateRequest): Promise<ExtendedTemplate> {
2525
const url = routing.templatesUrl;
26-
const { template } = await api.post<{ template: Template }>(url, {
26+
const { template } = await api.post<{ template: ExtendedTemplate }>(url, {
2727
payload,
2828
});
2929
return template;
3030
}
3131

32-
async function update(templateId: TemplateId, payload: UpdateRequest): Promise<Template> {
32+
async function update(
33+
templateId: TemplateId,
34+
payload: UpdateRequest,
35+
): Promise<ExtendedTemplate> {
3336
const url = routing.templatesUrl;
34-
const { template } = await api.patch<{ template: Template }>(`${url}/${templateId}`, {
35-
payload,
36-
});
37+
const { template } = await api.patch<{ template: ExtendedTemplate }>(
38+
`${url}/${templateId}`,
39+
{
40+
payload,
41+
},
42+
);
3743
return template;
3844
}
3945

src/types/Template.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,12 @@ import type { UserRef } from './User';
44
export interface Template {
55
id: string;
66
title: string;
7-
content: string;
87
creator: UserRef | null;
98
last_modifying_user: UserRef | null;
109
created_at: Iso8601DateTime;
1110
modified_at: Iso8601DateTime;
1211
}
12+
13+
export interface ExtendedTemplate extends Template {
14+
content: string;
15+
}

0 commit comments

Comments
 (0)