Skip to content

Commit 1d6871a

Browse files
committed
Fix: EncodingType 프론트랑 맞지 않았던 오류 해결, originUrl 길이 제한 1000자로 변경
1 parent fcbb58e commit 1d6871a

File tree

4 files changed

+7
-8
lines changed

4 files changed

+7
-8
lines changed

src/main/java/com/young/shortenerurl/url/model/EncodingType.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
public enum EncodingType {
1010
BASE_64_V1(Base64EncoderV1::new),
11-
BASE_62_V2(Base64EncoderV2::new);
11+
BASE_64_V2(Base64EncoderV2::new);
1212

1313
private final Supplier<Encoder> supplier;
1414

src/main/java/com/young/shortenerurl/url/model/Url.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ public class Url {
2222
@GeneratedValue(strategy = GenerationType.IDENTITY)
2323
private Long id;
2424

25-
@Column(nullable = false, updatable = false)
25+
@Column(length = 1000, nullable = false, updatable = false)
2626
private String originUrl;
2727

2828
@Embedded

src/test/java/com/young/shortenerurl/url/application/EncodingExecutorTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void encode_base64V2() {
4141
given(uniqueKeyGenerator.generateKey()).willReturn(63L);
4242

4343
//when
44-
String encodedUrl = encodingExecutor.encode(EncodingType.BASE_62_V2);
44+
String encodedUrl = encodingExecutor.encode(EncodingType.BASE_64_V2);
4545

4646
//then
4747
assertThat(encodedUrl).isEqualTo("~");

src/test/java/com/young/shortenerurl/url/application/UrlServiceTest.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package com.young.shortenerurl.url.application;
22

3-
import com.young.shortenerurl.url.application.UrlService;
43
import com.young.shortenerurl.url.application.dto.UrlCreateRequest;
54
import com.young.shortenerurl.url.application.dto.UrlInfoFindResponse;
65
import com.young.shortenerurl.url.infrastructures.UrlJpaRepository;
@@ -33,12 +32,12 @@ class UrlServiceTest {
3332

3433
@BeforeEach
3534
void setup(){
36-
Encoder encoder = EncodingType.BASE_62_V2.getEncoder();
35+
Encoder encoder = EncodingType.BASE_64_V2.getEncoder();
3736
String originUrl = "setup-url1";
3837

3938
Url url = new Url(
4039
originUrl,
41-
new EncodedUrl(encoder.encode(5), EncodingType.BASE_62_V2)
40+
new EncodedUrl(encoder.encode(5), EncodingType.BASE_64_V2)
4241
);
4342

4443
setupUrl = urlJpaRepository.save(url);
@@ -48,7 +47,7 @@ void setup(){
4847
@DisplayName("originUrl과 Base64V2을 통해 인코딩된 url을 생성할 수 있다.")
4948
void createUrl_Base64V2() {
5049
//given
51-
UrlCreateRequest request = new UrlCreateRequest("test-orgin-url", EncodingType.BASE_62_V2);
50+
UrlCreateRequest request = new UrlCreateRequest("test-orgin-url", EncodingType.BASE_64_V2);
5251

5352
//when
5453
String encodedUrl = urlService.createUrl(request);
@@ -76,7 +75,7 @@ void createUrl_Base64V1() {
7675
@DisplayName("url 저장 시 동일한 originUrl이 이미 존재한다면 존재하는 Url의 인코딩 url을 반환한다.")
7776
void createUrl_alreadyExistUrl(){
7877
//given
79-
UrlCreateRequest request = new UrlCreateRequest("setup-url1", EncodingType.BASE_62_V2);
78+
UrlCreateRequest request = new UrlCreateRequest("setup-url1", EncodingType.BASE_64_V2);
8079

8180
//when
8281
String encodedUrl = urlService.createUrl(request);

0 commit comments

Comments
 (0)