Refactor: url 인코딩 분리

Author: young970

src/main/java/com/young/shortenerurl/global/GlobalApiExceptionHandler.java

@@ -11,8 +11,6 @@
 import org.springframework.web.bind.annotation.ExceptionHandler;
 import org.springframework.web.bind.annotation.RestControllerAdvice;
 
-import java.util.NoSuchElementException;
-
 @RestControllerAdvice
 @Slf4j
 public class GlobalApiExceptionHandler {
@@ -39,13 +37,6 @@ public ResponseEntity<ErrorResponse> handleEntityNotFoundException(HttpServletRe
         return ResponseEntity.status(HttpStatus.NOT_FOUND).body(errorResponse);
     }
 
-    @ExceptionHandler(NoSuchElementException.class)
-    public ResponseEntity<Void> handleNoSuchElementException(HttpServletRequest request, NoSuchElementException e){
-        log.error("Sever Exception Request URI {}: ", request.getRequestURI(), e);
-
-        return ResponseEntity.internalServerError().build();
-    }
-
     @ExceptionHandler(Exception.class)
     public ResponseEntity<Void> handleException(HttpServletRequest request, Exception e){
         log.error("Sever Exception Request URI {}: ", request.getRequestURI(), e);

src/main/java/com/young/shortenerurl/url/application/EncodingExecutor.java

@@ -0,0 +1,34 @@
+package com.young.shortenerurl.url.application;
+
+import com.young.shortenerurl.global.generator.UniqueKeyGenerator;
+import com.young.shortenerurl.url.model.EncodingType;
+import com.young.shortenerurl.url.util.Encoder;
+import org.springframework.stereotype.Component;
+import org.springframework.util.Assert;
+
+import java.util.Map;
+import java.util.stream.Collectors;
+import java.util.stream.Stream;
+
+@Component
+public class EncodingExecutor {
+
+    private final Map<String, Encoder> encoders;
+    private final UniqueKeyGenerator uniqueKeyGenerator;
+
+    public EncodingExecutor(UniqueKeyGenerator uniqueKeyGenerator) {
+        this.encoders = Stream.of(EncodingType.values())
+                .collect(Collectors.toMap(Enum::name, EncodingType::getEncoder));
+
+        this.uniqueKeyGenerator = uniqueKeyGenerator;
+    }
+
+    public String encode(EncodingType encodingType){
+        Assert.notNull(encodingType, "encodingType은 null이 들어오면 안됩니다.");
+
+        Encoder encoder = encoders.get(encodingType.name());
+
+        return encoder.encode(uniqueKeyGenerator.generateKey());
+    }
+
+}

src/main/java/com/young/shortenerurl/url/application/UrlService.java

@@ -2,29 +2,26 @@
 
 import com.young.shortenerurl.url.application.dto.UrlCreateRequest;
 import com.young.shortenerurl.url.application.dto.UrlInfoFindResponse;
-import com.young.shortenerurl.global.generator.UniqueKeyGenerator;
 import com.young.shortenerurl.url.infrastructures.UrlRepository;
 import com.young.shortenerurl.url.model.EncodedUrl;
 import com.young.shortenerurl.url.model.Url;
-import com.young.shortenerurl.url.util.Encoder;
 import org.springframework.stereotype.Service;
 import org.springframework.transaction.annotation.Transactional;
 
 @Service
 public class UrlService {
 
     private final UrlRepository urlRepository;
-    private final UniqueKeyGenerator uniqueKeyGenerator;
+    private final EncodingExecutor encodingExecutor;
 
-    public UrlService(UrlRepository urlRepository, UniqueKeyGenerator uniqueKeyGenerator) {
+    public UrlService(UrlRepository urlRepository, EncodingExecutor encodingExecutor) {
         this.urlRepository = urlRepository;
-        this.uniqueKeyGenerator = uniqueKeyGenerator;
+        this.encodingExecutor = encodingExecutor;
     }
 
     @Transactional
     public String createUrl(UrlCreateRequest request) {
-        Encoder encoder = request.encodingType().getEncoder();
-        String encodedUrl = encoder.encode(uniqueKeyGenerator.generateKey());
+        String encodedUrl = encodingExecutor.encode(request.encodingType());
 
         Url savedUrl = urlRepository.findByOriginUrl(request.originUrl()).orElseGet(() -> {
             Url url = new Url(