refactor(community): 코드 리뷰 사항 반영

- findById 메서드로 추출(추상화 레벨 일관성)
- ServiceTest 중복되는 부분 @beforeeach로 추출
- CommunityBoard 메서드에 isWriter 추가

Author: ayoung-dev

src/main/java/com/somemore/community/domain/CommunityBoard.java

@@ -48,4 +48,8 @@ public CommunityBoard(UUID writerId, String title, String content, String imgUrl
         this.content = content;
         this.imgUrl = imgUrl;
     }
+
+    public boolean isWriter(UUID writerId) {
+        return this.writerId.equals(writerId);
+    }
 }

src/main/java/com/somemore/community/service/command/DeleteCommunityBoardService.java

@@ -22,16 +22,22 @@ class DeleteCommunityBoardService implements DeleteCommunityBoardUseCase {
 
     @Override
     public void deleteCommunityBoard(UUID writerId, Long id) {
-        CommunityBoard communityBoard = communityBoardRepository.findById(id)
-                .orElseThrow(() -> new BadRequestException(NOT_EXISTS_COMMUNITY_BOARD.getMessage()));
+        CommunityBoard communityBoard = getCommunityBoardById(id);
 
         validateWriter(communityBoard, writerId);
 
         communityBoard.markAsDeleted();
+
+        communityBoardRepository.save(communityBoard);
+    }
+
+    private CommunityBoard getCommunityBoardById(Long id) {
+        return communityBoardRepository.findById(id)
+                .orElseThrow(() -> new BadRequestException(NOT_EXISTS_COMMUNITY_BOARD.getMessage()));
     }
 
     private void validateWriter(CommunityBoard communityBoard, UUID writerId) {
-        if (communityBoard.getWriterId().equals(writerId)) {
+        if (communityBoard.isWriter(writerId)) {
             return;
         }
 

src/test/java/com/somemore/community/service/command/DeleteCommunityBoardServiceTest.java

@@ -12,6 +12,7 @@
 import com.somemore.global.exception.ExceptionMessage;
 import org.assertj.core.api.ThrowableAssert;
 import org.junit.jupiter.api.AfterEach;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
@@ -28,6 +29,23 @@ class DeleteCommunityBoardServiceTest extends IntegrationTestSupport {
     @Autowired
     private CommunityBoardRepository communityBoardRepository;
 
+    private UUID writerId;
+    private Long communityId;
+    private String imgUrl;
+
+    @BeforeEach
+    void setUp() {
+        CommunityBoardCreateRequestDto dto = CommunityBoardCreateRequestDto.builder()
+                .title("커뮤니티 테스트 제목")
+                .content("커뮤니티 테스트 내용")
+                .build();
+
+        writerId = UUID.randomUUID();
+        imgUrl = "https://image.test.url/123";
+
+        communityId = createCommunityBoardUseCase.createCommunityBoard(dto, writerId, imgUrl);
+    }
+
     @AfterEach
     void tearDown() {
         communityBoardRepository.deleteAllInBatch();
@@ -37,16 +55,6 @@ void tearDown() {
     @Test
     void deleteCommunityBoardWithId() {
         //given
-        CommunityBoardCreateRequestDto dto = CommunityBoardCreateRequestDto.builder()
-                .title("커뮤니티 테스트 제목")
-                .content("커뮤니티 테스트 내용")
-                .build();
-
-        UUID writerId = UUID.randomUUID();
-        String imgUrl = "https://image.test.url/123";
-
-        Long communityId = createCommunityBoardUseCase.createCommunityBoard(dto, writerId, imgUrl);
-
         //when
         deleteCommunityBoardService.deleteCommunityBoard(writerId, communityId);
 
@@ -58,15 +66,6 @@ void deleteCommunityBoardWithId() {
     @Test
     void deleteCommunityBoardWithDeletedId() {
         //given
-        CommunityBoardCreateRequestDto dto = CommunityBoardCreateRequestDto.builder()
-                .title("커뮤니티 테스트 제목")
-                .content("커뮤니티 테스트 내용")
-                .build();
-
-        UUID writerId = UUID.randomUUID();
-        String imgUrl = "https://image.test.url/123";
-
-        Long communityId = createCommunityBoardUseCase.createCommunityBoard(dto, writerId, imgUrl);
         deleteCommunityBoardService.deleteCommunityBoard(writerId, communityId);
 
         //when
@@ -82,16 +81,6 @@ void deleteCommunityBoardWithDeletedId() {
     @Test
     void deleteCommunityBoardWithNotWriterId() {
         //given
-        CommunityBoardCreateRequestDto dto = CommunityBoardCreateRequestDto.builder()
-                .title("커뮤니티 테스트 제목")
-                .content("커뮤니티 테스트 내용")
-                .build();
-
-        UUID writerId = UUID.randomUUID();
-        String imgUrl = "https://image.test.url/123";
-
-        Long communityId = createCommunityBoardUseCase.createCommunityBoard(dto, writerId, imgUrl);
-
         //when
         ThrowableAssert.ThrowingCallable callable = () -> deleteCommunityBoardService.deleteCommunityBoard(UUID.randomUUID(), communityId);
 
@@ -100,4 +89,4 @@ void deleteCommunityBoardWithNotWriterId() {
                 .isThrownBy(callable)
                 .withMessage(ExceptionMessage.UNAUTHORIZED_COMMUNITY_BOARD.getMessage());
     }
-}
+}