Skip to content

Commit 06102da

Browse files
committed
fix: sonarqube issue fix
1 parent 921e210 commit 06102da

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

src/test/java/com/somemore/common/fixture/LocalDateTimeFixture.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,9 @@
44

55
public class LocalDateTimeFixture {
66

7+
private LocalDateTimeFixture() {
8+
}
9+
710
public static LocalDateTime createStartDateTime() {
811
// 2024-11-25 T:13:00:00
912
return LocalDateTime.of(2024, 11, 25, 13, 0);

src/test/java/com/somemore/location/service/command/UpdateLocationServiceTest.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,9 @@ void updateLocationWithDto() {
5757
// then
5858
Location updateLocation = locationRepository.findById(location.getId()).orElseThrow();
5959
assertThat(updateLocation.getAddress()).isEqualTo(dto.address());
60-
assertThat(updateLocation.getLatitude().compareTo(dto.latitude())).isZero();
61-
assertThat(updateLocation.getLongitude().compareTo(dto.longitude())).isZero();
60+
assertThat(updateLocation.getLatitude())
61+
.isEqualByComparingTo(dto.latitude());
62+
assertThat(updateLocation.getLongitude())
63+
.isEqualByComparingTo(dto.longitude());
6264
}
6365
}

src/test/java/com/somemore/recruitboard/repository/RecruitBoardRepositoryImplTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
import static org.assertj.core.api.Assertions.assertThat;
66

77
import com.somemore.IntegrationTestSupport;
8-
import com.somemore.common.fixture.LocalDateTimeFixture;
98
import com.somemore.recruitboard.domain.RecruitBoard;
109
import com.somemore.recruitboard.domain.VolunteerInfo;
1110
import java.time.LocalDateTime;
@@ -23,6 +22,7 @@ class RecruitBoardRepositoryImplTest extends IntegrationTestSupport {
2322
private RecruitBoardRepositoryImpl recruitBoardRepository;
2423

2524
private RecruitBoard recruitBoard;
25+
2626
@BeforeEach
2727
void setUp() {
2828
recruitBoard = createRecruitBoard();

src/test/java/com/somemore/recruitboard/service/command/UpdateRecruitBoardServiceTest.java

Lines changed: 10 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44
import static com.somemore.common.fixture.LocalDateTimeFixture.createUpdateStartDateTime;
55
import static com.somemore.recruitboard.domain.VolunteerType.ADMINISTRATIVE_SUPPORT;
66
import static com.somemore.recruitboard.domain.VolunteerType.OTHER;
7-
import static java.time.temporal.ChronoUnit.MINUTES;
87
import static org.assertj.core.api.Assertions.assertThat;
98

109
import com.somemore.IntegrationTestSupport;
@@ -48,10 +47,8 @@ void setUp() {
4847
centerId = UUID.randomUUID();
4948
recruitBoard = createRecruitBoard(centerId, location.getId());
5049
recruitBoardRepository.saveAndFlush(recruitBoard);
51-
5250
}
5351

54-
5552
@AfterEach
5653
void tearDown() {
5754
recruitBoardRepository.deleteAllInBatch();
@@ -92,12 +89,10 @@ void updateRecruitBoard() {
9289
assertThat(volunteerInfo.getVolunteerType()).isEqualTo(dto.volunteerType());
9390
assertThat(volunteerInfo.getAdmitted()).isEqualTo(dto.admitted());
9491

95-
assertThat(volunteerInfo.getVolunteerStartDateTime().truncatedTo(MINUTES)
96-
.compareTo(dto.volunteerStartDateTime().truncatedTo(MINUTES)))
97-
.isZero();
98-
assertThat(volunteerInfo.getVolunteerEndDateTime().truncatedTo(MINUTES)
99-
.compareTo(dto.volunteerEndDateTime().truncatedTo(MINUTES)))
100-
.isZero();
92+
assertThat(volunteerInfo.getVolunteerStartDateTime())
93+
.isEqualToIgnoringNanos(dto.volunteerStartDateTime());
94+
assertThat(volunteerInfo.getVolunteerEndDateTime())
95+
.isEqualToIgnoringNanos(dto.volunteerEndDateTime());
10196
}
10297

10398
@DisplayName("봉사 모집글 위치를 수정할 수 있다")
@@ -122,14 +117,17 @@ void updateRecruitBoardLocation() {
122117

123118
assertThat(updateRecruitBoard.getVolunteerInfo().getRegion()).isEqualTo(dto.region());
124119
assertThat(updateLocation.getAddress()).isEqualTo(dto.address());
125-
assertThat(updateLocation.getLongitude().compareTo(dto.longitude())).isZero();
126-
assertThat(updateLocation.getLatitude().compareTo(dto.latitude())).isZero();
120+
assertThat(updateLocation.getLongitude())
121+
.isEqualByComparingTo(dto.longitude());
122+
assertThat(updateLocation.getLatitude())
123+
.isEqualByComparingTo(dto.latitude());
127124
}
128125

129126
@DisplayName("봉사 모집글은 작성자만 수정할 수 있다")
130127
@Test
131128
void updateRecruitBoardWhenCenterIdIsWrong() {
132129
// given
130+
Long id = recruitBoard.getId();
133131
UUID wrongCenterId = UUID.randomUUID();
134132
LocalDateTime newStartDateTime = createUpdateStartDateTime();
135133
LocalDateTime newEndDateTime = newStartDateTime.plusHours(3);
@@ -147,9 +145,7 @@ void updateRecruitBoardWhenCenterIdIsWrong() {
147145
// when
148146
// then
149147
Assertions.assertThatThrownBy(
150-
() -> updateRecruitBoardService.updateRecruitBoard(dto, recruitBoard.getId(),
151-
wrongCenterId,
152-
newImgUrl)
148+
() -> updateRecruitBoardService.updateRecruitBoard(dto, id, wrongCenterId, newImgUrl)
153149
).isInstanceOf(BadRequestException.class);
154150

155151
}

src/test/java/com/somemore/recruitboard/service/query/RecruitQueryServiceTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import static org.assertj.core.api.Assertions.assertThatThrownBy;
77

88
import com.somemore.IntegrationTestSupport;
9-
import com.somemore.common.fixture.LocalDateTimeFixture;
109
import com.somemore.global.exception.BadRequestException;
1110
import com.somemore.recruitboard.domain.RecruitBoard;
1211
import com.somemore.recruitboard.domain.VolunteerInfo;

0 commit comments

Comments
 (0)