refactor(sonar 반영): unused import, chaining join, 명시적인 엔티티 default fields

Author: m-a-king

src/main/java/com/somemore/volunteer/repository/VolunteerDetailRepositoryImpl.java

@@ -17,7 +17,7 @@ public class VolunteerDetailRepositoryImpl implements VolunteerDetailRepository
     private final VolunteerDetailJpaRepository volunteerDetailJpaRepository;
     private final JPAQueryFactory queryFactory;
 
-    private final QVolunteerDetail volunteerDetail = QVolunteerDetail.volunteerDetail;
+    private static final QVolunteerDetail volunteerDetail = QVolunteerDetail.volunteerDetail;
 
     @Override
     public VolunteerDetail save(VolunteerDetail volunteerDetail) {

src/main/java/com/somemore/volunteer/repository/VolunteerJpaRepository.java

@@ -3,8 +3,5 @@
 import com.somemore.volunteer.domain.Volunteer;
 import org.springframework.data.jpa.repository.JpaRepository;
 
-import java.util.Optional;
-import java.util.UUID;
-
 public interface VolunteerJpaRepository extends JpaRepository<Volunteer, Long> {
 }

src/main/java/com/somemore/volunteer/repository/VolunteerRepositoryImpl.java

@@ -10,7 +10,6 @@
 
 import java.util.Optional;
 import java.util.UUID;
-import java.util.function.Function;
 
 @RequiredArgsConstructor
 @Repository
@@ -19,7 +18,7 @@ public class VolunteerRepositoryImpl implements VolunteerRepository {
     private final VolunteerJpaRepository volunteerJpaRepository;
     private final JPAQueryFactory queryFactory;
 
-    private final QVolunteer volunteer = QVolunteer.volunteer;
+    private static final QVolunteer volunteer = QVolunteer.volunteer;
 
     @Override
     public Volunteer save(Volunteer volunteer) {

src/main/java/com/somemore/volunteer/service/RegisterVolunteerService.java

@@ -3,7 +3,6 @@
 import com.somemore.volunteer.domain.Volunteer;
 import com.somemore.volunteer.domain.VolunteerDetail;
 import com.somemore.volunteer.dto.request.VolunteerRegisterRequestDto;
-import com.somemore.volunteer.repository.VolunteerDetailJpaRepository;
 import com.somemore.volunteer.repository.VolunteerDetailRepository;
 import com.somemore.volunteer.repository.VolunteerRepository;
 import com.somemore.volunteer.usecase.RegisterVolunteerUseCase;

src/main/java/com/somemore/volunteerApply/domain/VolunteerApply.java

@@ -27,17 +27,17 @@ public class VolunteerApply extends BaseEntity {
 
     @Enumerated(EnumType.STRING)
     @Column(name = "status", nullable = false, length = 20)
-    private ApplyStatus status;
+    private ApplyStatus status = ApplyStatus.WAITING;
 
     @Column(name = "attended", nullable = false)
-    private Boolean attended;
+    private Boolean attended = false;
 
     @Builder
     public VolunteerApply(UUID volunteerId, Long recruitBoardId, ApplyStatus status, Boolean attended) {
         this.volunteerId = volunteerId;
         this.recruitBoardId = recruitBoardId;
-        this.status = status != null ? status : ApplyStatus.WAITING;
-        this.attended = attended != null ? attended : false;
+        this.status = status;
+        this.attended = attended;
     }
 }
 

src/main/java/com/somemore/volunteerApply/repository/VolunteerApplyRepositoryImpl.java

@@ -23,7 +23,7 @@ public class VolunteerApplyRepositoryImpl implements VolunteerApplyRepository {
     private final VolunteerApplyJpaRepository volunteerApplyJpaRepository;
     private final JPAQueryFactory queryFactory;
 
-    private final QVolunteerApply volunteerApply = QVolunteerApply.volunteerApply;
+    private static final QVolunteerApply volunteerApply = QVolunteerApply.volunteerApply;
 
     @Override
     public VolunteerApply save(VolunteerApply volunteerApply) {

src/test/java/com/somemore/recruitboard/repository/RecruitBoardRepositoryImplTest.java

@@ -247,9 +247,7 @@ void findNotCompletedIdsByCenterIds() {
 
         // then
         assertThat(notCompletedBoardIds)
-                .hasSize(2);
-
-        assertThat(notCompletedBoardIds)
+                .hasSize(2)
                 .doesNotContain(deletedRecruitingBoard.getId())
                 .doesNotContain(deletedClosedBoard.getId())
                 .doesNotContain(deletedCompletedRecruitBoard.getId())