Skip to content

Commit 3a6cd90

Browse files
committed
refactor(volunteer-apply): 봉사 지원 조회 리팩토링
- getById
1 parent f45bd2d commit 3a6cd90

File tree

2 files changed

+23
-21
lines changed

2 files changed

+23
-21
lines changed

src/main/java/com/somemore/domains/volunteerapply/service/VolunteerApplyQueryService.java

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import com.somemore.domains.volunteerapply.dto.response.VolunteerApplySummaryResponseDto;
99
import com.somemore.domains.volunteerapply.repository.VolunteerApplyRepository;
1010
import com.somemore.domains.volunteerapply.usecase.VolunteerApplyQueryUseCase;
11+
import com.somemore.global.exception.ExceptionMessage;
1112
import com.somemore.global.exception.NoSuchElementException;
1213
import java.util.List;
1314
import java.util.UUID;
@@ -26,46 +27,47 @@ public class VolunteerApplyQueryService implements VolunteerApplyQueryUseCase {
2627
private final VolunteerApplyRepository volunteerApplyRepository;
2728

2829
@Override
29-
public List<UUID> getVolunteerIdsByRecruitIds(List<Long> recruitIds) {
30-
return volunteerApplyRepository.findVolunteerIdsByRecruitIds(recruitIds);
30+
public VolunteerApply getById(Long id) {
31+
return volunteerApplyRepository.findById(id).orElseThrow(
32+
() -> new NoSuchElementException(NOT_EXISTS_VOLUNTEER_APPLY));
3133
}
3234

3335
@Override
3436
public VolunteerApply getByRecruitIdAndVolunteerId(Long recruitId, UUID volunteerId) {
35-
return volunteerApplyRepository.findByRecruitIdAndVolunteerId(recruitId, volunteerId)
36-
.orElseThrow(
37+
return volunteerApplyRepository.findByRecruitIdAndVolunteerId(recruitId, volunteerId).orElseThrow(
3738
() -> new NoSuchElementException(NOT_EXISTS_VOLUNTEER_APPLY));
3839
}
3940

4041
@Override
4142
public VolunteerApplySummaryResponseDto getSummaryByRecruitId(Long recruitId) {
4243

43-
List<VolunteerApply> applies = volunteerApplyRepository.findAllByRecruitId(
44-
recruitId);
44+
List<VolunteerApply> applies = volunteerApplyRepository.findAllByRecruitId(recruitId);
4545

4646
return VolunteerApplySummaryResponseDto.from(applies);
4747
}
4848

4949
@Override
50-
public VolunteerApplyResponseDto getVolunteerApplyByRecruitIdAndVolunteerId(Long recruitId,
51-
UUID volunteerId) {
50+
public VolunteerApplyResponseDto getVolunteerApplyByRecruitIdAndVolunteerId(Long recruitId, UUID volunteerId) {
5251
VolunteerApply apply = getByRecruitIdAndVolunteerId(recruitId, volunteerId);
5352

5453
return VolunteerApplyResponseDto.from(apply);
5554
}
5655

5756
@Override
58-
public Page<VolunteerApply> getAllByRecruitId(Long recruitId,
59-
VolunteerApplySearchCondition condition) {
57+
public Page<VolunteerApply> getAllByRecruitId(Long recruitId, VolunteerApplySearchCondition condition) {
6058
return volunteerApplyRepository.findAllByRecruitId(recruitId, condition);
6159
}
6260

6361
@Override
64-
public Page<VolunteerApply> getAllByVolunteerId(UUID volunteerId,
65-
VolunteerApplySearchCondition condition) {
62+
public Page<VolunteerApply> getAllByVolunteerId(UUID volunteerId, VolunteerApplySearchCondition condition) {
6663
return volunteerApplyRepository.findAllByVolunteerId(volunteerId, condition);
6764
}
6865

66+
@Override
67+
public List<UUID> getVolunteerIdsByRecruitIds(List<Long> recruitIds) {
68+
return volunteerApplyRepository.findVolunteerIdsByRecruitIds(recruitIds);
69+
}
70+
6971
@Override
7072
public List<VolunteerApply> getAllByIds(List<Long> ids) {
7173
return volunteerApplyRepository.findAllByIds(ids);
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,30 @@
11
package com.somemore.domains.volunteerapply.usecase;
22

3+
import com.somemore.domains.volunteerapply.domain.VolunteerApply;
34
import com.somemore.domains.volunteerapply.dto.condition.VolunteerApplySearchCondition;
45
import com.somemore.domains.volunteerapply.dto.response.VolunteerApplyResponseDto;
56
import com.somemore.domains.volunteerapply.dto.response.VolunteerApplySummaryResponseDto;
6-
import com.somemore.domains.volunteerapply.domain.VolunteerApply;
7+
import org.springframework.data.domain.Page;
78

89
import java.util.List;
910
import java.util.UUID;
10-
import org.springframework.data.domain.Page;
1111

1212
public interface VolunteerApplyQueryUseCase {
1313

14-
List<UUID> getVolunteerIdsByRecruitIds(List<Long> recruitIds);
14+
VolunteerApply getById(Long id);
1515

1616
VolunteerApply getByRecruitIdAndVolunteerId(Long recruitId, UUID volunteerId);
1717

1818
VolunteerApplySummaryResponseDto getSummaryByRecruitId(Long recruitId);
1919

20-
VolunteerApplyResponseDto getVolunteerApplyByRecruitIdAndVolunteerId(Long recruitId,
21-
UUID volunteerId);
20+
VolunteerApplyResponseDto getVolunteerApplyByRecruitIdAndVolunteerId(Long recruitId, UUID volunteerId);
2221

23-
Page<VolunteerApply> getAllByRecruitId(Long recruitId, VolunteerApplySearchCondition condition);
24-
25-
Page<VolunteerApply> getAllByVolunteerId(UUID volunteerId,
26-
VolunteerApplySearchCondition condition);
22+
List<UUID> getVolunteerIdsByRecruitIds(List<Long> recruitIds);
2723

2824
List<VolunteerApply> getAllByIds(List<Long> ids);
2925

26+
Page<VolunteerApply> getAllByRecruitId(Long recruitId, VolunteerApplySearchCondition condition);
27+
28+
Page<VolunteerApply> getAllByVolunteerId(UUID volunteerId, VolunteerApplySearchCondition condition);
29+
3030
}

0 commit comments

Comments
 (0)