refactor(review): 봉사 지원 생성 리팩토링

 - ReviewQueryUseCase 의존하도록 변경

Author: leebs0521

src/main/java/com/somemore/domains/review/dto/request/ReviewCreateRequestDto.java

@@ -1,6 +1,7 @@
 package com.somemore.domains.review.dto.request;
 
 import com.fasterxml.jackson.databind.PropertyNamingStrategies;
+import com.fasterxml.jackson.databind.PropertyNamingStrategies.SnakeCaseStrategy;
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import com.somemore.domains.volunteerapply.domain.VolunteerApply;
 import com.somemore.domains.review.domain.Review;
@@ -10,12 +11,12 @@
 import java.util.UUID;
 import lombok.Builder;
 
-@JsonNaming(PropertyNamingStrategies.SnakeCaseStrategy.class)
+@JsonNaming(SnakeCaseStrategy.class)
 @Builder
 public record ReviewCreateRequestDto(
-        @Schema(description = "봉사 모집글 아이디", example = "1")
-        @NotNull(message = "봉사 모집글 아이디는 필수 값입니다.")
-        Long recruitBoardId,
+        @Schema(description = "봉사 지원 아이디", example = "1")
+        @NotNull(message = "봉사 지원 아이디는 필수 값입니다.")
+        Long volunteerApplyId,
         @Schema(description = "리뷰 제목", example = "내 인생 최고의 봉사 활동")
         @NotBlank(message = "리뷰 제목은 필수 값입니다.")
         String title,
@@ -24,9 +25,9 @@ public record ReviewCreateRequestDto(
         String content
 ) {
 
-    public Review toEntity(VolunteerApply apply, UUID volunteerId, String imgUrl) {
+    public Review toEntity(UUID volunteerId, String imgUrl) {
         return Review.builder()
-                .volunteerApplyId(apply.getId())
+                .volunteerApplyId(volunteerApplyId)
                 .volunteerId(volunteerId)
                 .title(title)
                 .content(content)

src/main/java/com/somemore/domains/review/service/CreateReviewService.java

@@ -4,6 +4,7 @@
 import static com.somemore.global.exception.ExceptionMessage.REVIEW_RESTRICTED_TO_ATTENDED;
 
 import com.somemore.domains.review.repository.ReviewRepository;
+import com.somemore.domains.review.usecase.ReviewQueryUseCase;
 import com.somemore.domains.volunteerapply.domain.VolunteerApply;
 import com.somemore.domains.volunteerapply.usecase.VolunteerApplyQueryUseCase;
 import com.somemore.global.exception.BadRequestException;
@@ -23,24 +24,24 @@
 public class CreateReviewService implements CreateReviewUseCase {
 
     private final ReviewRepository reviewRepository;
+    private final ReviewQueryUseCase reviewQueryUseCase;
     private final VolunteerApplyQueryUseCase volunteerApplyQueryUseCase;
 
     @Override
     public Long createReview(ReviewCreateRequestDto requestDto, UUID volunteerId, String imgUrl) {
-        VolunteerApply apply = getVolunteerApply(requestDto.recruitBoardId(), volunteerId);
-        validateDuplicateReview(apply);
+        validateDuplicateReview(requestDto.volunteerApplyId());
+
+        VolunteerApply apply = volunteerApplyQueryUseCase.getById(requestDto.volunteerApplyId());
         validateActivityCompletion(apply);
 
-        Review review = requestDto.toEntity(apply, volunteerId, imgUrl);
-        return reviewRepository.save(review).getId();
-    }
+        Review review = requestDto.toEntity(volunteerId, imgUrl);
+        reviewRepository.save(review);
 
-    private VolunteerApply getVolunteerApply(Long recruitBoardId, UUID volunteerId) {
-        return volunteerApplyQueryUseCase.getByRecruitIdAndVolunteerId(recruitBoardId, volunteerId);
+        return review.getId();
     }
 
-    private void validateDuplicateReview(VolunteerApply apply) {
-        if (reviewRepository.existsByVolunteerApplyId(apply.getId())) {
+    private void validateDuplicateReview(Long volunteerApplyId) {
+        if (reviewQueryUseCase.existsByVolunteerApplyId(volunteerApplyId)) {
             throw new DuplicateException(REVIEW_ALREADY_EXISTS);
         }
     }

src/main/java/com/somemore/domains/review/service/ReviewQueryService.java

@@ -31,6 +31,11 @@ public class ReviewQueryService implements ReviewQueryUseCase {
     private final VolunteerQueryUseCase volunteerQueryUseCase;
     private final CenterQueryUseCase centerQueryUseCase;
 
+    @Override
+    public boolean existsByVolunteerApplyId(Long volunteerApplyId) {
+        return reviewRepository.existsByVolunteerApplyId(volunteerApplyId);
+    }
+
     @Override
     public Review getById(Long id) {
         return reviewRepository.findById(id).orElseThrow(

src/main/java/com/somemore/domains/review/usecase/ReviewQueryUseCase.java

@@ -10,6 +10,8 @@
 
 public interface ReviewQueryUseCase {
 
+    boolean existsByVolunteerApplyId(Long volunteerApplyId);
+
     Review getById(Long id);
 
     ReviewDetailResponseDto getDetailById(Long id);