refactor(volunteer-apply): VolunteerInfo 객체만 가져오도록 수정

 - 객체를 가져오고 현 서비스에서 응답 DTO로 감싸주도록 변경

Author: leebs0521

src/main/java/com/somemore/volunteer/service/VolunteerQueryService.java

@@ -8,7 +8,6 @@
 import com.somemore.volunteer.domain.VolunteerDetail;
 import com.somemore.volunteer.dto.response.VolunteerProfileResponseDto;
 import com.somemore.volunteer.dto.response.VolunteerRankingResponseDto;
-import com.somemore.volunteer.dto.response.VolunteerSimpleInfoResponseDto;
 import com.somemore.volunteer.repository.VolunteerDetailRepository;
 import com.somemore.volunteer.repository.VolunteerRepository;
 import com.somemore.volunteer.repository.mapper.VolunteerOverviewForRankingByHours;
@@ -89,15 +88,8 @@ public List<Volunteer> getAllByIds(List<UUID> volunteerIds) {
     }
 
     @Override
-    public List<VolunteerSimpleInfoResponseDto> getVolunteerSimpleInfosByIds(
-            List<UUID> volunteerIds) {
-
-        List<VolunteerSimpleInfo> volunteerSimpleInfos = volunteerRepository.findSimpleInfoByIds(
-                volunteerIds);
-
-        return volunteerSimpleInfos.stream()
-                .map(VolunteerSimpleInfoResponseDto::from)
-                .toList();
+    public List<VolunteerSimpleInfo> getVolunteerSimpleInfosByIds(List<UUID> ids) {
+        return volunteerRepository.findSimpleInfoByIds(ids);
     }
 
     private Volunteer findVolunteer(UUID volunteerId) {

src/main/java/com/somemore/volunteer/usecase/VolunteerQueryUseCase.java

@@ -4,6 +4,7 @@
 import com.somemore.volunteer.dto.response.VolunteerProfileResponseDto;
 import com.somemore.volunteer.dto.response.VolunteerRankingResponseDto;
 import com.somemore.volunteer.dto.response.VolunteerSimpleInfoResponseDto;
+import com.somemore.volunteer.repository.mapper.VolunteerSimpleInfo;
 import java.util.List;
 import java.util.UUID;
 
@@ -23,5 +24,5 @@ public interface VolunteerQueryUseCase {
 
     List<Volunteer> getAllByIds(List<UUID> volunteerIds);
 
-    List<VolunteerSimpleInfoResponseDto> getVolunteerSimpleInfosByIds(List<UUID> volunteerIds);
+    List<VolunteerSimpleInfo> getVolunteerSimpleInfosByIds(List<UUID> ids);
 }

src/main/java/com/somemore/volunteerapply/dto/response/VolunteerApplyVolunteerInfoResponseDto.java

@@ -3,6 +3,7 @@
 import com.fasterxml.jackson.databind.PropertyNamingStrategies.SnakeCaseStrategy;
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import com.somemore.volunteer.dto.response.VolunteerSimpleInfoResponseDto;
+import com.somemore.volunteer.repository.mapper.VolunteerSimpleInfo;
 import com.somemore.volunteerapply.domain.ApplyStatus;
 import com.somemore.volunteerapply.domain.VolunteerApply;
 import io.swagger.v3.oas.annotations.media.Schema;
@@ -32,8 +33,10 @@ public record VolunteerApplyVolunteerInfoResponseDto(
 
     public static VolunteerApplyVolunteerInfoResponseDto of(
             VolunteerApply volunteerApply,
-            VolunteerSimpleInfoResponseDto volunteer
+            VolunteerSimpleInfo volunteerSimpleInfo
     ) {
+        VolunteerSimpleInfoResponseDto volunteer = VolunteerSimpleInfoResponseDto.from(
+                volunteerSimpleInfo);
         return VolunteerApplyVolunteerInfoResponseDto.builder()
                 .id(volunteerApply.getId())
                 .recruitBoardId(volunteerApply.getRecruitBoardId())

src/main/java/com/somemore/volunteerapply/service/VolunteerApplyQueryFacadeService.java

@@ -5,7 +5,7 @@
 import com.somemore.global.exception.BadRequestException;
 import com.somemore.recruitboard.domain.RecruitBoard;
 import com.somemore.recruitboard.usecase.query.RecruitBoardQueryUseCase;
-import com.somemore.volunteer.dto.response.VolunteerSimpleInfoResponseDto;
+import com.somemore.volunteer.repository.mapper.VolunteerSimpleInfo;
 import com.somemore.volunteer.usecase.VolunteerQueryUseCase;
 import com.somemore.volunteerapply.domain.VolunteerApply;
 import com.somemore.volunteerapply.dto.condition.VolunteerApplySearchCondition;
@@ -39,14 +39,14 @@ public Page<VolunteerApplyVolunteerInfoResponseDto> getVolunteerAppliesByRecruit
         Page<VolunteerApply> applies = volunteerApplyRepository.findAllByRecruitId(recruitId,
                 condition);
 
-        Map<UUID, VolunteerSimpleInfoResponseDto> volunteerMap = getVolunteerInfoMap(
+        Map<UUID, VolunteerSimpleInfo> volunteerMap = getVolunteerInfoMap(
                 applies);
 
-        return applies.map(apply -> {
-            VolunteerSimpleInfoResponseDto volunteerInfo = volunteerMap.getOrDefault(
-                    apply.getVolunteerId(), null);
-            return VolunteerApplyVolunteerInfoResponseDto.of(apply, volunteerInfo);
-        });
+        return applies.map(
+                apply -> VolunteerApplyVolunteerInfoResponseDto.of(
+                        apply,
+                        volunteerMap.getOrDefault(apply.getVolunteerId(), null)
+                ));
     }
 
     @Override
@@ -79,24 +79,20 @@ private Map<Long, RecruitBoard> getRecruitBoardMap(Page<VolunteerApply> applies)
                 .toList();
         List<RecruitBoard> boards = recruitBoardQueryUseCase.getAllByIds(boardIds);
 
-        Map<Long, RecruitBoard> boardMap = boards.stream()
+        return boards.stream()
                 .collect(Collectors.toMap(RecruitBoard::getId,
                         board -> board));
-        return boardMap;
     }
 
-    private Map<UUID, VolunteerSimpleInfoResponseDto> getVolunteerInfoMap(
-            Page<VolunteerApply> applies) {
-
-        List<UUID> volunteerIds = applies.getContent().stream()
-                .map(VolunteerApply::getVolunteerId)
-                .collect(Collectors.toList());
+    private Map<UUID, VolunteerSimpleInfo> getVolunteerInfoMap(Page<VolunteerApply> applies) {
+        List<UUID> volunteerIds = applies.getContent().stream().map(VolunteerApply::getVolunteerId)
+                .toList();
 
-        List<VolunteerSimpleInfoResponseDto> volunteers = volunteerQueryUseCase.getVolunteerSimpleInfosByIds(
+        List<VolunteerSimpleInfo> volunteers = volunteerQueryUseCase.getVolunteerSimpleInfosByIds(
                 volunteerIds);
 
         return volunteers.stream()
-                .collect(Collectors.toMap(VolunteerSimpleInfoResponseDto::id,
+                .collect(Collectors.toMap(VolunteerSimpleInfo::id,
                         volunteer -> volunteer));
     }