Skip to content

Commit 5dbad40

Browse files
committed
refactor(center): center 아이디로 센터명 조회하는 메서드 Optional로 변경
- BadRequestException -> NoSuchElementException
1 parent d1dc8d2 commit 5dbad40

File tree

3 files changed

+6
-12
lines changed

3 files changed

+6
-12
lines changed

src/main/java/com/somemore/center/repository/NEWCenterRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,6 @@ default boolean doesNotExistById(UUID id) {
2525

2626
List<CenterOverviewInfo> findOverviewInfosByIds(List<UUID> ids);
2727

28-
String findNameById(UUID id);
28+
Optional<String> findNameById(UUID id);
2929

3030
}

src/main/java/com/somemore/center/repository/NEWCenterRepositoryImpl.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,9 +103,8 @@ public List<CenterOverviewInfo> findOverviewInfosByIds(List<UUID> ids) {
103103
}
104104

105105
@Override
106-
public String findNameById(UUID id) {
107-
return findDynamicFieldByCenterId(id, userCommonAttribute.name)
108-
.orElse(null);
106+
public Optional<String> findNameById(UUID id) {
107+
return findDynamicFieldByCenterId(id, userCommonAttribute.name);
109108
}
110109

111110
private static BooleanExpression idIn(List<UUID> ids) {

src/main/java/com/somemore/center/service/NEWCenterQueryService.java

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,13 +77,8 @@ public List<CenterOverviewInfo> getCenterOverviewsByIds(List<UUID> ids) {
7777

7878
@Override
7979
public String getNameById(UUID id) {
80-
String name = centerRepository.findNameById(id);
81-
82-
if (name == null || name.isBlank()) {
83-
throw new BadRequestException(NOT_EXISTS_CENTER);
84-
}
85-
86-
return name;
80+
return centerRepository.findNameById(id)
81+
.orElseThrow(
82+
() -> new NoSuchElementException(ExceptionMessage.NOT_EXISTS_CENTER));
8783
}
88-
8984
}

0 commit comments

Comments
 (0)