Skip to content

Commit 635db8b

Browse files
committed
chore: 코드 리뷰 사항 반영
- 컨트롤러 swagger 설명 수정 - 매직 스트링의 상수화
1 parent 84eace1 commit 635db8b

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

src/main/java/com/somemore/note/controller/NoteQueryApiController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public ApiResponse<NoteDetailViewForCenter> getNoteDetailForCenter(@PathVariable
5656
}
5757

5858
@Secured("ROLE_VOLUNTEER")
59-
@Operation(summary = "기관의 자신에게 온 쪽지 상세 조회")
59+
@Operation(summary = "봉사자의 자신에게 온 쪽지 상세 조회")
6060
@GetMapping("/volunteer/{noteId}")
6161
public ApiResponse<NoteDetailViewForVolunteer> getNoteDetailForVolunteer(@PathVariable Long noteId) {
6262

src/main/java/com/somemore/note/repository/NoteRepositoryImpl.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ public class NoteRepositoryImpl implements NoteRepository {
3535

3636
private static final String SENDER_ID = "senderId";
3737
private static final String SENDER_NAME = "senderName";
38+
private static final String SENDER_PROFILE_IMG_LINK = "senderProfileImgLink";
3839

3940
@Override
4041
public Note save(Note note) {
@@ -115,7 +116,7 @@ public Optional<NoteDetailViewForCenter> findNoteDetailViewReceiverIsCenter(Long
115116
note.content,
116117
volunteer.id.as(SENDER_ID),
117118
volunteer.nickname.as(SENDER_NAME),
118-
volunteer.imgUrl.as("senderProfileImgLink"),
119+
volunteer.imgUrl.as(SENDER_PROFILE_IMG_LINK),
119120
note.createdAt
120121
))
121122
.from(note)
@@ -139,7 +140,7 @@ public Optional<NoteDetailViewForVolunteer> findNoteDetailViewReceiverIsVoluntee
139140
note.content,
140141
center.id.as(SENDER_ID),
141142
center.name.as(SENDER_NAME),
142-
center.imgUrl.as("senderProfileImgLink"),
143+
center.imgUrl.as(SENDER_PROFILE_IMG_LINK),
143144
note.createdAt
144145
))
145146
.from(note)

0 commit comments

Comments
 (0)