test(recruit-board): 이미지 링크 제거에 따른 테스트

Author: leebs0521

src/test/java/com/somemore/domains/recruitboard/controller/RecruitBoardCommandApiControllerTest.java

@@ -1,5 +1,19 @@
 package com.somemore.domains.recruitboard.controller;
 
+import static com.somemore.domains.recruitboard.domain.RecruitStatus.CLOSED;
+import static com.somemore.domains.recruitboard.domain.VolunteerCategory.OTHER;
+import static com.somemore.support.fixture.LocalDateTimeFixture.createStartDateTime;
+import static org.mockito.ArgumentMatchers.any;
+import static org.mockito.BDDMockito.given;
+import static org.mockito.BDDMockito.willDoNothing;
+import static org.springframework.http.MediaType.APPLICATION_JSON;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.delete;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.patch;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post;
+import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.put;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
+import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+
 import com.somemore.domains.location.dto.request.LocationCreateRequestDto;
 import com.somemore.domains.recruitboard.domain.RecruitStatus;
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardCreateRequestDto;
@@ -9,34 +23,14 @@
 import com.somemore.domains.recruitboard.usecase.CreateRecruitBoardUseCase;
 import com.somemore.domains.recruitboard.usecase.DeleteRecruitBoardUseCase;
 import com.somemore.domains.recruitboard.usecase.UpdateRecruitBoardUseCase;
-import com.somemore.global.imageupload.usecase.ImageUploadUseCase;
 import com.somemore.support.ControllerTestSupport;
 import com.somemore.support.annotation.MockUser;
-import com.somemore.support.annotation.WithMockCustomUser;
-import org.junit.jupiter.api.DisplayName;
-import org.junit.jupiter.api.Test;
-import org.springframework.boot.test.mock.mockito.MockBean;
-import org.springframework.http.MediaType;
-import org.springframework.mock.web.MockHttpServletRequest;
-import org.springframework.mock.web.MockMultipartFile;
-import org.springframework.test.web.servlet.request.MockMultipartHttpServletRequestBuilder;
-import org.springframework.test.web.servlet.request.RequestPostProcessor;
-
 import java.math.BigDecimal;
 import java.time.LocalDateTime;
 import java.util.UUID;
-
-import static com.somemore.domains.recruitboard.domain.RecruitStatus.CLOSED;
-import static com.somemore.domains.recruitboard.domain.VolunteerCategory.OTHER;
-import static com.somemore.support.fixture.LocalDateTimeFixture.createStartDateTime;
-import static org.mockito.ArgumentMatchers.any;
-import static org.mockito.ArgumentMatchers.anyString;
-import static org.mockito.BDDMockito.given;
-import static org.mockito.BDDMockito.willDoNothing;
-import static org.springframework.http.MediaType.MULTIPART_FORM_DATA;
-import static org.springframework.test.web.servlet.request.MockMvcRequestBuilders.*;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.jsonPath;
-import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
+import org.junit.jupiter.api.DisplayName;
+import org.junit.jupiter.api.Test;
+import org.springframework.boot.test.mock.mockito.MockBean;
 
 class RecruitBoardCommandApiControllerTest extends ControllerTestSupport {
 
@@ -49,8 +43,6 @@ class RecruitBoardCommandApiControllerTest extends ControllerTestSupport {
     @MockBean
     private DeleteRecruitBoardUseCase deleteRecruitBoardUseCase;
 
-    @MockBean
-    private ImageUploadUseCase imageUploadUseCase;
 
     @Test
     @DisplayName("봉사 활동 모집글 등록 성공 테스트")
@@ -66,7 +58,7 @@ void createRecruitBoard_success() throws Exception {
                 .longitude(BigDecimal.valueOf(127.010842267696))
                 .build();
 
-        RecruitBoardCreateRequestDto dto = RecruitBoardCreateRequestDto.builder()
+        RecruitBoardCreateRequestDto requestDto = RecruitBoardCreateRequestDto.builder()
                 .title("봉사 모집글 작성")
                 .content("봉사 하실분을 모집합니다. <br>")
                 .region("지역")
@@ -79,37 +71,21 @@ void createRecruitBoard_success() throws Exception {
                 .location(location)
                 .build();
 
-        MockMultipartFile imageFile = new MockMultipartFile(
-                "img_file",
-                "test-image.jpg",
-                MediaType.IMAGE_JPEG_VALUE,
-                "test image content".getBytes()
-        );
-
-        MockMultipartFile requestData = new MockMultipartFile(
-                "data",
-                "",
-                MediaType.APPLICATION_JSON_VALUE,
-                objectMapper.writeValueAsBytes(dto)
-        );
-
-        String mockImageUrl = "http://example.com/image/test-image.jpg";
-        long mockRecruitBoardId = 1L;
+        String requestBody = objectMapper.writeValueAsString(requestDto);
+        long boardId = 1L;
 
-        given(imageUploadUseCase.uploadImage(any())).willReturn(mockImageUrl);
-        given(createRecruitBoardUseCase.createRecruitBoard(any(), any(UUID.class),
-                anyString())).willReturn(mockRecruitBoardId);
+        given(createRecruitBoardUseCase.createRecruitBoard(any(), any(UUID.class)))
+                .willReturn(boardId);
 
         // when
-        mockMvc.perform(multipart("/api/recruit-board")
-                        .file(requestData)
-                        .file(imageFile)
-                        .contentType(MULTIPART_FORM_DATA)
+        mockMvc.perform(post("/api/recruit-board")
+                        .content(requestBody)
+                        .contentType(APPLICATION_JSON)
                         .header("Authorization", "Bearer access-token"))
                 // then
                 .andExpect(status().isOk())
                 .andExpect(jsonPath("$.code").value(201))
-                .andExpect(jsonPath("$.data").value(mockRecruitBoardId))
+                .andExpect(jsonPath("$.data").value(boardId))
                 .andExpect(jsonPath("$.message").value("봉사 활동 모집글 등록 성공"));
     }
 
@@ -133,40 +109,15 @@ void updateRecruitBoard() throws Exception {
                 .admitted(true)
                 .build();
 
-        MockMultipartFile imageFile = new MockMultipartFile(
-                "img_file",
-                "test-image.jpg",
-                MediaType.IMAGE_JPEG_VALUE,
-                "test image content".getBytes()
-        );
-
-        MockMultipartFile requestData = new MockMultipartFile(
-                "data",
-                "",
-                MediaType.APPLICATION_JSON_VALUE,
-                objectMapper.writeValueAsBytes(requestDto)
-        );
-
-        String mockImageUrl = "http://example.com/image/test-image.jpg";
-
-        given(imageUploadUseCase.uploadImage(any())).willReturn(mockImageUrl);
         willDoNothing().given(updateRecruitBoardUseCase)
-                .updateRecruitBoard(any(), any(), any(UUID.class), anyString());
+                .updateRecruitBoard(any(), any(), any(UUID.class));
 
-        MockMultipartHttpServletRequestBuilder builder = multipart("/api/recruit-board/{id}", 1);
-        builder.with(new RequestPostProcessor() {
-            @Override
-            public MockHttpServletRequest postProcessRequest(MockHttpServletRequest request) {
-                request.setMethod("PUT");
-                return request;
-            }
-        });
+        String requestBody = objectMapper.writeValueAsString(requestDto);
 
         // when
-        mockMvc.perform(builder
-                        .file(requestData)
-                        .file(imageFile)
-                        .contentType(MULTIPART_FORM_DATA)
+        mockMvc.perform(put("/api/recruit-board/{id}", 1)
+                        .content(requestBody)
+                        .contentType(APPLICATION_JSON)
                         .header("Authorization", "Bearer access-token"))
                 //then
                 .andExpect(status().isOk())
@@ -195,7 +146,7 @@ void updateRecruitBoardLocation() throws Exception {
         // when
         mockMvc.perform(put("/api/recruit-board/{id}/location", 1L)
                         .content(requestBody)
-                        .contentType(MediaType.APPLICATION_JSON)
+                        .contentType(APPLICATION_JSON)
                         .header("Authorization", "Bearer access-token"))
                 // then
                 .andExpect(status().isOk())
@@ -219,7 +170,7 @@ void updateRecruitBoardStatus() throws Exception {
         // when
         mockMvc.perform(patch("/api/recruit-board/{id}", 1L)
                         .content(requestBody)
-                        .contentType(MediaType.APPLICATION_JSON)
+                        .contentType(APPLICATION_JSON)
                         .header("Authorization", "Bearer access-token"))
                 //then
                 .andExpect(status().isOk())

src/test/java/com/somemore/domains/recruitboard/domain/RecruitBoardTest.java

@@ -30,7 +30,6 @@ void setUp() {
     @Test
     void updateRecruitBoard() {
         // given
-        String imgUrl = "https://image.domain.com/updates";
         LocalDateTime updateStartDateTime = createUpdateStartDateTime();
         LocalDateTime updateEndDateTime = updateStartDateTime.plusHours(2);
 
@@ -45,12 +44,11 @@ void updateRecruitBoard() {
                 .admitted(true).build();
 
         // when
-        board.updateWith(dto, imgUrl);
+        board.updateWith(dto);
 
         // then
         assertThat(board.getTitle()).isEqualTo(dto.title());
         assertThat(board.getContent()).isEqualTo(dto.content());
-        assertThat(board.getImgUrl()).isEqualTo(imgUrl);
     }
 
     @DisplayName("봉사 활동 지역을 수정할 수 있다.")
@@ -152,7 +150,6 @@ public static RecruitBoard createRecruitBoard(UUID centerId) {
                 .content("내용")
                 .recruitmentInfo(recruitmentInfo)
                 .status(RECRUITING)
-                .imgUrl("이미지 링크")
                 .build();
     }
 }

src/test/java/com/somemore/domains/recruitboard/repository/RecruitBoardRepositoryImplTest.java

@@ -489,7 +489,6 @@ public static RecruitBoard createRecruitBoard(UUID centerId, Long locationId,
                 .locationId(locationId)
                 .title("모집글 제목")
                 .content("모집글 내용")
-                .imgUrl("이미지 링크")
                 .recruitmentInfo(recruitmentInfo)
                 .status(status)
                 .build();
@@ -514,7 +513,6 @@ public static RecruitBoard createRecruitBoard(UUID centerId, String title,
                 .locationId(1L)
                 .title(title)
                 .content("모집글 내용")
-                .imgUrl("이미지 링크")
                 .recruitmentInfo(recruitmentInfo)
                 .status(status)
                 .build();
@@ -538,7 +536,6 @@ private static RecruitBoard createRecruitBoard(LocalDateTime startTime, LocalDat
                 .locationId(1L)
                 .title("모집글 제목")
                 .content("모집글 내용")
-                .imgUrl("이미지 링크")
                 .recruitmentInfo(recruitmentInfo)
                 .status(status)
                 .build();

src/test/java/com/somemore/domains/recruitboard/scheduler/RecruitBoardStatusUpdateSchedulerTest.java

@@ -98,7 +98,6 @@ private static RecruitBoard createRecruitBoard(LocalDateTime startTime, LocalDat
                 .locationId(1L)
                 .title("모집글 제목")
                 .content("모집글 내용")
-                .imgUrl("이미지 링크")
                 .recruitmentInfo(recruitmentInfo)
                 .status(status)
                 .build();

src/test/java/com/somemore/domains/recruitboard/service/CreateRecruitBoardServiceTest.java

@@ -71,15 +71,14 @@ void createRecruitBoardWithDto() {
         String imgUrl = "https://image.domain.com/links";
 
         // when
-        Long saveId = createRecruitBoardService.createRecruitBoard(dto, centerId, imgUrl);
+        Long saveId = createRecruitBoardService.createRecruitBoard(dto, centerId);
 
         // then
         Optional<RecruitBoard> recruitBoard = recruitBoardRepository.findById(saveId);
 
         assertThat(recruitBoard).isPresent();
         assertThat(recruitBoard.get().getId()).isEqualTo(saveId);
         assertThat(recruitBoard.get().getCenterId()).isEqualTo(centerId);
-        assertThat(recruitBoard.get().getImgUrl()).isEqualTo(imgUrl);
     }
 
 }

src/test/java/com/somemore/domains/recruitboard/service/DeleteRecruitBoardServiceTest.java

@@ -71,7 +71,6 @@ private static RecruitBoard createRecruitBoard() {
                 .locationId(1L)
                 .title("봉사모집제목")
                 .content("봉사모집내용")
-                .imgUrl("https://image.domain.com/links")
                 .recruitmentInfo(recruitmentInfo)
                 .status(RECRUITING)
                 .build();

src/test/java/com/somemore/domains/recruitboard/service/UpdateRecruitBoardServiceTest.java

@@ -85,16 +85,15 @@ void updateRecruitBoard() {
         setMockClock(current);
 
         // when
-        updateRecruitBoardService.updateRecruitBoard(dto, recruitBoard.getId(), centerId,
-                newImgUrl);
+        updateRecruitBoardService.updateRecruitBoard(dto, recruitBoard.getId(), centerId
+        );
 
         // then
         RecruitBoard updatedRecruitBoard = recruitBoardRepository.findById(recruitBoard.getId())
                 .orElseThrow();
 
         assertThat(updatedRecruitBoard.getTitle()).isEqualTo(dto.title());
         assertThat(updatedRecruitBoard.getContent()).isEqualTo(dto.content());
-        assertThat(updatedRecruitBoard.getImgUrl()).isEqualTo(newImgUrl);
 
         RecruitmentInfo recruitmentInfo = updatedRecruitBoard.getRecruitmentInfo();
         assertThat(recruitmentInfo.getRecruitmentCount()).isEqualTo(dto.recruitmentCount());
@@ -181,7 +180,6 @@ private static RecruitBoard createRecruitBoard(UUID centerId, Long locationId,
                 .locationId(locationId)
                 .title("봉사모집제목")
                 .content("봉사모집내용")
-                .imgUrl("https://image.domain.com/links")
                 .recruitmentInfo(recruitmentInfo)
                 .status(RECRUITING)
                 .build();

src/test/java/com/somemore/domains/recruitboard/service/validator/RecruitBoardValidatorTest.java

@@ -168,7 +168,6 @@ public static RecruitBoard createRecruitBoard() {
                 .content("내용")
                 .recruitmentInfo(recruitmentInfo)
                 .status(RECRUITING)
-                .imgUrl("이미지 링크")
                 .build();
     }