Skip to content

Commit 7ff6c7e

Browse files
committed
chore: 코드리뷰 사항 반영
- RedisSettleVolunteerHoursSubscriber 클래스에 마지막 라인 개행추가 - VolunteerRecordMessageConverter의 봉사 기록 객체 생성 메서드 이름 변경
1 parent 2c6d162 commit 7ff6c7e

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/main/java/com/somemore/domains/volunteerrecord/event/convert/VolunteerRecordMessageConverter.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public VolunteerRecord from(String message) {
2424
String eventType = rootNode.get(SUB_TYPE).asText();
2525

2626
return switch (DomainEventSubType.from(eventType)) {
27-
case VOLUNTEER_HOURS_SETTLE -> buildVolunteerRecordCreate(message);
27+
case VOLUNTEER_HOURS_SETTLE -> convertToVolunteerRecord(message);
2828
default -> {
2929
log.error("지원하지 않는 이벤트 타입입니다: {}", eventType);
3030
throw new IllegalArgumentException("지원하지 않는 이벤트 타입입니다: " + eventType);
@@ -36,7 +36,7 @@ public VolunteerRecord from(String message) {
3636
}
3737
}
3838

39-
private VolunteerRecord buildVolunteerRecordCreate(String message) throws JsonProcessingException {
39+
private VolunteerRecord convertToVolunteerRecord(String message) throws JsonProcessingException {
4040

4141
VolunteerRecordCreateEvent volunteerRecordCreateEvent = objectMapper.readValue(message, VolunteerRecordCreateEvent.class);
4242

src/main/java/com/somemore/domains/volunteerrecord/event/subscriber/RedisSettleVolunteerHoursSubscriber.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ public void onMessage(Message message, byte[] pattern) {
2424

2525
settleVolunteerHoursHandler.handle(volunteerRecord);
2626
}
27-
}
27+
}

0 commit comments

Comments
 (0)