Skip to content

Commit 9a9331c

Browse files
committed
chore: 불필요한 구문 제거및 개행 추가
- 불필요한 코드, import문 제거 - 마지막 줄 개행이 없는 클래스 개행 추가
1 parent e6e3077 commit 9a9331c

File tree

6 files changed

+5
-18
lines changed

6 files changed

+5
-18
lines changed

src/main/java/com/somemore/domains/volunteerrecord/controller/VolunteerRankingApiController.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ public class VolunteerRankingApiController {
1818

1919
@Operation(summary = "봉사 시간 랭킹", description = "봉사 시간 랭킹을 반환합니다.")
2020
@GetMapping("/ranking")
21-
public ApiResponse<VolunteerRankingResponseDto> updateCenterProfile() {
21+
public ApiResponse<VolunteerRankingResponseDto> getVolunteerRanking() {
2222

2323
VolunteerRankingResponseDto volunteerRankings = getVolunteerRankingUseCase.getVolunteerRanking();
2424

src/main/java/com/somemore/domains/volunteerrecord/repository/VolunteerRecordJpaRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,4 +52,4 @@ AND YEAR(vr.volunteer_date) = YEAR(CURDATE())
5252
WHERE ranking <= 4
5353
""", nativeQuery = true)
5454
List<Object[]> findMonthlyTopRankingWithTies();
55-
}
55+
}

src/main/java/com/somemore/domains/volunteerrecord/repository/mapper/VolunteerRankingMapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,4 +54,4 @@ public static UUID toUUID(Object uuidObject) {
5454
default -> throw new IllegalArgumentException("UUID 변환이 불가능한 데이터 타입: " + uuidObject.getClass().getName());
5555
};
5656
}
57-
}
57+
}

src/test/java/com/somemore/domains/volunteerrecord/repository/mapper/VolunteerRankingMapperTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,4 +113,4 @@ void returnNullWhenIdNotExistInNicknameMap() {
113113
// then
114114
assertThat(dto.nickname()).isNull();
115115
}
116-
}
116+
}

src/test/java/com/somemore/domains/volunteerrecord/service/CalculateRankingServiceTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -118,4 +118,4 @@ void calculateMonthlyVolunteerRanking() {
118118
assertThat(ranking.volunteerMonthlyResponse().get(3).totalHours()).isEqualTo(60L);
119119
assertThat(ranking.volunteerMonthlyResponse().get(3).ranking()).isEqualTo(3);
120120
}
121-
}
121+
}

src/test/java/com/somemore/support/TestContainerSupport.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,35 +2,22 @@
22

33
import org.springframework.test.context.DynamicPropertyRegistry;
44
import org.springframework.test.context.DynamicPropertySource;
5-
import org.testcontainers.containers.GenericContainer;
65
import org.testcontainers.containers.JdbcDatabaseContainer;
76
import org.testcontainers.containers.MySQLContainer;
8-
import org.testcontainers.utility.DockerImageName;
97

108
public abstract class TestContainerSupport {
119

12-
private static final String REDIS_IMAGE = "redis:latest";
13-
// private static final int REDIS_PORT = 6379;
1410
private static final String MYSQL_IMAGE = "mysql:8";
1511

16-
// private static final GenericContainer REDIS;
1712
private static final JdbcDatabaseContainer MYSQL;
1813

1914
static {
20-
// REDIS = new GenericContainer(DockerImageName.parse(REDIS_IMAGE))
21-
// .withExposedPorts(REDIS_PORT)
22-
// .withReuse(true);
2315
MYSQL = new MySQLContainer(MYSQL_IMAGE);
24-
25-
// REDIS.start();
2616
MYSQL.start();
2717
}
2818

2919
@DynamicPropertySource
3020
public static void overrideProps(DynamicPropertyRegistry registry){
31-
// registry.add("spring.data.redis.host", REDIS::getHost);
32-
// registry.add("spring.data.redis.port", () -> String.valueOf(REDIS.getMappedPort(REDIS_PORT)));
33-
3421
registry.add("spring.datasource.driver-class-name", MYSQL::getDriverClassName);
3522
registry.add("spring.datasource.url", MYSQL::getJdbcUrl);
3623
registry.add("spring.datasource.~username", MYSQL::getUsername);

0 commit comments

Comments
 (0)