Skip to content

Commit ae1799d

Browse files
committed
feat(oauth): 소셜 로그인 URL 획득 컨트롤러 개선
1 parent 7f12ef2 commit ae1799d

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

src/main/java/com/somemore/domains/volunteer/controller/VolunteerSignController.java

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
11
package com.somemore.domains.volunteer.controller;
22

33
import com.somemore.domains.volunteer.usecase.GenerateOAuthUrlUseCase;
4-
import com.somemore.global.common.response.ApiResponse;
5-
import com.somemore.global.exception.BadRequestException;
64
import com.somemore.global.auth.signout.usecase.SignOutUseCase;
5+
import com.somemore.global.common.response.ApiResponse;
76
import io.swagger.v3.oas.annotations.Parameter;
87
import io.swagger.v3.oas.annotations.media.Schema;
98
import io.swagger.v3.oas.annotations.tags.Tag;
@@ -32,11 +31,7 @@ public RedirectView signIn(
3231
@Parameter(name = "oauthProvider", description = "OAuth 제공자 선택", example = "naver", required = true, schema = @Schema(allowableValues = {"naver"}))
3332
@PathVariable("oauthProvider") String oauthProvider) {
3433

35-
String redirectUrl = switch (oauthProvider.toLowerCase()) {
36-
case "naver" -> generateOAuthUrlUseCase.generateUrl(oauthProvider);
37-
38-
default -> throw new BadRequestException("지원되지 않는 OAuth 제공자: " + oauthProvider);
39-
};
34+
String redirectUrl = generateOAuthUrlUseCase.generateUrl(oauthProvider);
4035

4136
return new RedirectView(redirectUrl);
4237
}

src/main/java/com/somemore/domains/volunteer/service/GenerateOAuthUrlService.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
package com.somemore.domains.volunteer.service;
22

33
import com.somemore.domains.volunteer.usecase.GenerateOAuthUrlUseCase;
4+
import com.somemore.global.auth.oauth.domain.OAuthProvider;
45
import lombok.RequiredArgsConstructor;
56
import lombok.extern.slf4j.Slf4j;
67
import org.springframework.beans.factory.annotation.Value;
@@ -18,7 +19,7 @@ public class GenerateOAuthUrlService implements GenerateOAuthUrlUseCase {
1819
@Override
1920
public String generateUrl(String oAuthProvider) {
2021
return UriComponentsBuilder.fromHttpUrl(generateBaseUrl())
21-
.pathSegment(oAuthProvider)
22+
.pathSegment(OAuthProvider.from(oAuthProvider).getProviderName())
2223
.build()
2324
.toUriString();
2425
}

0 commit comments

Comments
 (0)