test(recruit-board): 모집글 Validator 추가에 따른 리팩토링 테스트

Author: leebs0521

src/test/java/com/somemore/domains/recruitboard/service/command/DeleteRecruitBoardServiceTest.java

@@ -2,15 +2,13 @@
 
 import com.somemore.domains.recruitboard.domain.RecruitBoard;
 import com.somemore.domains.recruitboard.domain.RecruitmentInfo;
-import com.somemore.domains.recruitboard.repository.RecruitBoardJpaRepository;
 import com.somemore.domains.recruitboard.repository.RecruitBoardRepository;
-import com.somemore.global.exception.BadRequestException;
 import com.somemore.support.IntegrationTestSupport;
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.time.LocalDateTime;
 import java.util.Optional;
@@ -19,8 +17,8 @@
 import static com.somemore.domains.recruitboard.domain.VolunteerCategory.OTHER;
 import static com.somemore.support.fixture.LocalDateTimeFixture.createStartDateTime;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
+@Transactional
 class DeleteRecruitBoardServiceTest extends IntegrationTestSupport {
 
     @Autowired
@@ -29,9 +27,6 @@ class DeleteRecruitBoardServiceTest extends IntegrationTestSupport {
     @Autowired
     private RecruitBoardRepository recruitBoardRepository;
 
-    @Autowired
-    private RecruitBoardJpaRepository recruitBoardJpaRepository;
-
     private RecruitBoard recruitBoard;
 
     @BeforeEach
@@ -40,11 +35,6 @@ void setUp() {
         recruitBoardRepository.save(recruitBoard);
     }
 
-    @AfterEach
-    void tearDown() {
-        recruitBoardJpaRepository.deleteAllInBatch();
-    }
-
     @DisplayName("봉사 모집글 식별값으로 모집글을 삭제할 수 있다")
     @Test
     void deleteRecruitBoard() {
@@ -61,20 +51,6 @@ void deleteRecruitBoard() {
         assertThat(findBoard).isEmpty();
     }
 
-    @DisplayName("모집글 삭제시 작성자가 아니면 에러가 발생한다")
-    @Test
-    void deleteRecruitBoardWithWrongCenterId() {
-        // given
-        UUID wrongCenterId = UUID.randomUUID();
-        Long recruitBoardId = recruitBoard.getId();
-
-        // when
-        // then
-        assertThatThrownBy(
-                () -> deleteRecruitBoardService.deleteRecruitBoard(wrongCenterId, recruitBoardId)
-        ).isInstanceOf(BadRequestException.class);
-    }
-
     private static RecruitBoard createRecruitBoard() {
 
         LocalDateTime startDateTime = createStartDateTime();

src/test/java/com/somemore/domains/recruitboard/service/command/UpdateRecruitBoardServiceTest.java

@@ -9,14 +9,12 @@
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardUpdateRequestDto;
 import com.somemore.domains.recruitboard.repository.RecruitBoardJpaRepository;
 import com.somemore.domains.recruitboard.repository.RecruitBoardRepository;
-import com.somemore.global.exception.BadRequestException;
 import com.somemore.support.IntegrationTestSupport;
-import org.assertj.core.api.Assertions;
-import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
+import org.springframework.transaction.annotation.Transactional;
 
 import java.math.BigDecimal;
 import java.time.LocalDateTime;
@@ -27,6 +25,7 @@
 import static com.somemore.support.fixture.LocalDateTimeFixture.*;
 import static org.assertj.core.api.Assertions.assertThat;
 
+@Transactional
 class UpdateRecruitBoardServiceTest extends IntegrationTestSupport {
 
     @Autowired
@@ -53,12 +52,6 @@ void setUp() {
         recruitBoardJpaRepository.saveAndFlush(recruitBoard);
     }
 
-    @AfterEach
-    void tearDown() {
-        recruitBoardJpaRepository.deleteAllInBatch();
-        locationRepository.deleteAllInBatch();
-    }
-
     @DisplayName("봉사 모집글의 데이터를 업데이트하면 저장소에 반영된다.")
     @Test
     void updateRecruitBoard() {
@@ -79,8 +72,7 @@ void updateRecruitBoard() {
                 .build();
 
         // when
-        updateRecruitBoardService.updateRecruitBoard(dto, recruitBoard.getId(), centerId,
-                newImgUrl);
+        updateRecruitBoardService.updateRecruitBoard(dto, recruitBoard.getId(), centerId, newImgUrl);
 
         // then
         RecruitBoard updatedRecruitBoard = recruitBoardRepository.findById(recruitBoard.getId())
@@ -129,33 +121,6 @@ void updateRecruitBoardLocation() {
                 .isEqualByComparingTo(dto.latitude());
     }
 
-    @DisplayName("봉사 모집글은 작성자만 수정할 수 있다")
-    @Test
-    void updateRecruitBoardWhenCenterIdIsWrong() {
-        // given
-        Long id = recruitBoard.getId();
-        UUID wrongCenterId = UUID.randomUUID();
-        LocalDateTime newStartDateTime = createUpdateStartDateTime();
-        LocalDateTime newEndDateTime = newStartDateTime.plusHours(3);
-        String newImgUrl = "https://image.domain.com/updates";
-        RecruitBoardUpdateRequestDto dto = RecruitBoardUpdateRequestDto.builder()
-                .title("업데이트 제목")
-                .content("업데이트 내용")
-                .recruitmentCount(1111)
-                .volunteerStartDateTime(newStartDateTime)
-                .volunteerEndDateTime(newEndDateTime)
-                .volunteerCategory(ADMINISTRATIVE_SUPPORT)
-                .admitted(false)
-                .build();
-
-        // when
-        // then
-        Assertions.assertThatThrownBy(
-                () -> updateRecruitBoardService.updateRecruitBoard(dto, id, wrongCenterId, newImgUrl)
-        ).isInstanceOf(BadRequestException.class);
-
-    }
-
     @DisplayName("봉사 모집글 상태를 변경할 수 있다")
     @Test
     void updateRecruitBoardStatus() {
@@ -165,8 +130,7 @@ void updateRecruitBoardStatus() {
         LocalDateTime currentDateTime = createCurrentDateTime();
 
         // when
-        updateRecruitBoardService.updateRecruitBoardStatus(newStatus, recruitBoardId, centerId,
-                currentDateTime);
+        updateRecruitBoardService.updateRecruitBoardStatus(newStatus, recruitBoardId, centerId, currentDateTime);
 
         // then
         RecruitBoard findBoard = recruitBoardRepository.findById(recruitBoardId).orElseThrow();