fix(community): sonarqube 이슈 사항 반영

Author: ayoung-dev

src/main/java/com/somemore/community/service/query/CommunityBoardQueryService.java

@@ -39,7 +39,7 @@ public List<CommunityBoardGetResponseDto> getCommunityBoards() {
                     String writerNickname = getWriterNickname(board.getWriterId());
                     return CommunityBoardGetResponseDto.fromEntity(board, writerNickname);
                 })
-                .collect(Collectors.toList());
+                .toList();
     }
 
     @Override
@@ -49,7 +49,7 @@ public List<CommunityBoardGetResponseDto> getCommunityBoardsByWriterId(UUID writ
 
         return boards.stream()
                 .map(board -> CommunityBoardGetResponseDto.fromEntity(board, writerNickname))
-                .collect(Collectors.toList());
+                .toList();
     }
 
     @Override

src/test/java/com/somemore/community/repository/CommunityRepositoryTest.java

@@ -11,11 +11,10 @@
 import java.util.Optional;
 import java.util.UUID;
 
-import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
-
+import static org.assertj.core.api.Assertions.assertThat;
 
 @Transactional
-public class CommunityRepositoryTest extends IntegrationTestSupport {
+class CommunityRepositoryTest extends IntegrationTestSupport {
 
     @Autowired
     private CommunityBoardRepository communityBoardRepository;
@@ -69,7 +68,7 @@ void getCommunityBoards() {
         List<CommunityBoard> communityBoards = communityBoardRepository.getCommunityBoards();
 
         //then
-        assertThat(communityBoards.size()).isEqualTo(2);
+        assertThat(communityBoards).hasSize(2);
         assertThat(communityBoards.get(0)).isEqualTo(communityBoard2);
         assertThat(communityBoards.get(1)).isEqualTo(communityBoard1);
     }
@@ -107,7 +106,7 @@ void getCommunityBoardsByWriterId() {
         List<CommunityBoard> communityBoards = communityBoardRepository.getCommunityBoardsByWriterId(communityBoard1.getWriterId());
 
         //then
-        assertThat(communityBoards.size()).isEqualTo(2);
+        assertThat(communityBoards).hasSize(2);
         assertThat(communityBoards.get(0)).isEqualTo(communityBoard2);
         assertThat(communityBoards.get(1)).isEqualTo(communityBoard1);
     }

src/test/java/com/somemore/community/service/query/CommunityBoardQueryServiceTest.java

@@ -88,8 +88,10 @@ void getAllCommunityBoards() {
         Optional<CommunityBoard> communityBoard1 = communityBoardRepository.findById(communityId1);
         Optional<CommunityBoard> communityBoard2 = communityBoardRepository.findById(communityId2);
 
-        assertThat(dtos).isNotNull();
-        assertThat(dtos).hasSize(2);
+
+        assertThat(dtos)
+                .isNotNull()
+                .hasSize(2);
 
         CommunityBoardGetResponseDto board1 = dtos.getLast();
         assertThat(board1.id()).isEqualTo(communityId1);
@@ -114,17 +116,6 @@ void getCommunityBoardsByWriter() {
 
         Volunteer savedVolunteer = volunteerRepository.save(volunteer);
 
-        Center center = Center.create(
-                "기본 기관 이름",
-                "010-1234-5678",
-                "http://example.com/image.jpg",
-                "기관 소개 내용",
-                "http://example.com",
-                "account123",
-                "password123"
-        );
-        Center savedCenter = centerRepository.save(center);
-
         CommunityBoardCreateRequestDto dto1 = CommunityBoardCreateRequestDto.builder()
                 .title("커뮤니티 테스트 제목1")
                 .content("커뮤니티 테스트 내용1")
@@ -135,16 +126,10 @@ void getCommunityBoardsByWriter() {
                 .content("커뮤니티 테스트 내용2")
                 .build();
 
-        CommunityBoardCreateRequestDto dto3 = CommunityBoardCreateRequestDto.builder()
-                .title("커뮤니티 테스트 제목3")
-                .content("커뮤니티 테스트 내용23")
-                .build();
-
         String imgUrl1 = "https://image.test.url/123";
 
         Long communityId1 = createCommunityBoardService.createCommunityBoard(dto1, savedVolunteer.getId(), null);
         Long communityId2 = createCommunityBoardService.createCommunityBoard(dto2, savedVolunteer.getId(), imgUrl1);
-        Long communityId3 = createCommunityBoardService.createCommunityBoard(dto3, savedCenter.getId(), imgUrl1);
 
         //when
         List<CommunityBoardGetResponseDto> dtos = communityBoardQueryService.getCommunityBoardsByWriterId(volunteer.getId());
@@ -153,8 +138,9 @@ void getCommunityBoardsByWriter() {
         Optional<CommunityBoard> communityBoard1 = communityBoardRepository.findById(communityId1);
         Optional<CommunityBoard> communityBoard2 = communityBoardRepository.findById(communityId2);
 
-        assertThat(dtos).isNotNull();
-        assertThat(dtos).hasSize(2);
+        assertThat(dtos)
+                .isNotNull()
+                .hasSize(2);
 
         CommunityBoardGetResponseDto board1 = dtos.getLast();
         assertThat(board1.id()).isEqualTo(communityId1);

src/test/java/com/somemore/volunteer/repository/VolunteerRepositoryTest.java

@@ -2,17 +2,16 @@
 
 import com.somemore.IntegrationTestSupport;
 import com.somemore.auth.oauth.OAuthProvider;
-import com.somemore.center.domain.Center;
 import com.somemore.volunteer.domain.Volunteer;
 import org.junit.jupiter.api.DisplayName;
 import org.junit.jupiter.api.Test;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.transaction.annotation.Transactional;
 
-import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
+import static org.assertj.core.api.Assertions.assertThat;
 
 @Transactional
-public class VolunteerRepositoryTest extends IntegrationTestSupport {
+class VolunteerRepositoryTest extends IntegrationTestSupport {
     @Autowired
     private VolunteerRepository volunteerRepository;