fix(volunteer-apply): sonar qube 리뷰 반영

Author: leebs0521

src/main/java/com/somemore/volunteerapply/dto/VolunteerApplyCreateRequestDto.java

@@ -6,7 +6,6 @@
 import com.fasterxml.jackson.databind.annotation.JsonNaming;
 import com.somemore.volunteerapply.domain.VolunteerApply;
 import io.swagger.v3.oas.annotations.media.Schema;
-import jakarta.validation.constraints.NotBlank;
 import jakarta.validation.constraints.NotNull;
 import java.util.UUID;
 import lombok.Builder;

src/test/java/com/somemore/common/fixture/RecruitBoardFixture.java

@@ -1,6 +1,7 @@
 package com.somemore.common.fixture;
 
 import static com.somemore.common.fixture.LocalDateTimeFixture.createStartDateTime;
+import static com.somemore.recruitboard.domain.RecruitStatus.CLOSED;
 import static com.somemore.recruitboard.domain.RecruitStatus.COMPLETED;
 import static com.somemore.recruitboard.domain.VolunteerCategory.OTHER;
 
@@ -322,7 +323,7 @@ public static RecruitBoard createCompletedRecruitBoard() {
     public static RecruitBoard createCloseRecruitBoard() {
         RecruitBoard recruitBoard = createCompletedRecruitBoard(UUID.randomUUID(),
                 VOLUNTEER_CATEGORY);
-        setRecruitStatus(recruitBoard, COMPLETED);
+        setRecruitStatus(recruitBoard, CLOSED);
         return recruitBoard;
     }
 

src/test/java/com/somemore/volunteerapply/service/WithdrawVolunteerApplyServiceTest.java

@@ -46,15 +46,15 @@ void withdraw() {
     @Test
     void withdrawWhenWrongVolunteerId() {
         // given
-        UUID wrongId = UUID.randomUUID();
-
         VolunteerApply apply = createApply(UUID.randomUUID(), APPROVED, false);
         volunteerApplyRepository.save(apply);
 
+        UUID wrongId = UUID.randomUUID();
+        Long applyId = apply.getId();
         // when
         // then
         assertThatThrownBy(
-                () -> withdrawVolunteerApplyService.withdraw(apply.getId(), wrongId)
+                () -> withdrawVolunteerApplyService.withdraw(applyId, wrongId)
         ).isInstanceOf(BadRequestException.class)
                 .hasMessage(UNAUTHORIZED_VOLUNTEER_APPLY.getMessage());
     }