refactor: 코드 리뷰 테스트 수정

Author: m-a-king

src/main/java/com/somemore/notification/repository/NotificationRepository.java

@@ -18,4 +18,6 @@ public interface NotificationRepository {
 
     List<Notification> findByReceiverIdAndUnread(UUID userId);
     List<Notification> findByReceiverIdAndRead(UUID userId);
+
+    void deleteAllInBatch();
 }

src/main/java/com/somemore/notification/repository/NotificationRepositoryImpl.java

@@ -51,6 +51,11 @@ public List<Notification> findByReceiverIdAndRead(UUID receiverId) {
                 .fetch();
     }
 
+    @Override
+    public void deleteAllInBatch() {
+        notificationJpaRepository.deleteAllInBatch();
+    }
+
     private static BooleanExpression eqReceiverId(UUID userId) {
         return notification.receiverId.eq(userId);
     }

src/test/java/com/somemore/notification/repository/NotificationRepositoryTest.java

@@ -32,21 +32,8 @@ void setup() {
         savedNotificationIds = new ArrayList<>();
 
         for (long i = 1; i <= 10; i++) {
-            Notification unreadNotification = Notification.builder()
-                    .title("Unread Notification")
-                    .type(NotificationSubType.NOTE_BLAH_BLAH)
-                    .receiverId(receiverId)
-                    .relatedId(i + 1)
-                    .build();
-
-            Notification readNotification = Notification.builder()
-                    .title("Read Notification")
-                    .type(NotificationSubType.REVIEW_BLAH_BLAH)
-                    .receiverId(receiverId)
-                    .relatedId(i + 100)
-                    .build();
-
-            readNotification.markAsRead();
+            Notification unreadNotification = createNotification(i, false);
+            Notification readNotification = createNotification(i * 100, true);
 
             notificationRepository.save(unreadNotification);
             notificationRepository.save(readNotification);
@@ -63,7 +50,6 @@ void findByReceiverIdAndUnread() {
 
         // then
         assertThat(notifications).hasSize(10);
-        assertThat(notifications.getFirst().getTitle()).isEqualTo("Unread Notification");
         assertThat(notifications.getFirst().isRead()).isFalse();
     }
 
@@ -75,7 +61,6 @@ void findByReceiverIdAndRead() {
 
         // then
         assertThat(notifications).hasSize(10);
-        assertThat(notifications.getFirst().getTitle()).isEqualTo("Read Notification");
         assertThat(notifications.getFirst().isRead()).isTrue();
     }
 
@@ -107,10 +92,26 @@ void findById() {
     @Test
     void findAllByIds() {
         // given
+        notificationRepository.deleteAllInBatch();
+
         // when
         List<Notification> notifications = notificationRepository.findAllByIds(savedNotificationIds);
 
         // then
-        assertThat(notifications).hasSize(10);
+        assertThat(notifications).isEmpty();
+    }
+
+    private Notification createNotification(long i, boolean isRead) {
+        Notification notification = Notification.builder()
+                .title("Notification")
+                .type(NotificationSubType.NOTE_BLAH_BLAH)
+                .receiverId(receiverId)
+                .relatedId(i + 1)
+                .build();
+
+        if (isRead) {
+            notification.markAsRead();
+        }
+        return notification;
     }
 }

src/test/java/com/somemore/notification/service/NotificationCommandServiceTest.java

@@ -1,6 +1,7 @@
 package com.somemore.notification.service;
 
 import static com.somemore.global.exception.ExceptionMessage.NOT_EXISTS_NOTIFICATION;
+import static com.somemore.global.exception.ExceptionMessage.UNAUTHORIZED_NOTIFICATION;
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
@@ -69,7 +70,7 @@ void markSingleNotificationAsReadWhenUnauthorized() {
         // when / then
         assertThatThrownBy(() -> notificationCommandService.markSingleNotificationAsRead(receiverId, notification.getId()))
                 .isInstanceOf(BadRequestException.class)
-                .hasMessageContaining("권한이 없습니다");
+                .hasMessageContaining(UNAUTHORIZED_NOTIFICATION.getMessage());
     }
 
     @DisplayName("알림 N개를 읽음 처리한다.")
@@ -118,7 +119,7 @@ void markMultipleNotificationsAsReadWhenUnauthorized() {
         // when / then
         assertThatThrownBy(() -> notificationCommandService.markMultipleNotificationsAsRead(receiverId, requestDto))
                 .isInstanceOf(BadRequestException.class)
-                .hasMessageContaining("권한이 없습니다");
+                .hasMessageContaining(UNAUTHORIZED_NOTIFICATION.getMessage());
     }
 
     private Notification createNotification(UUID receiverId) {