Skip to content

Commit cb679a7

Browse files
committed
refactor(service): 불필요한 코드 제거 및 변수명 변경
- `findVolunteer`와 `findVolunteerDetail` 메서드 제거 - 사용되지 않는 메서드로 판단하여 삭제 - `NEWVolunteerRepository` 변수명을 `volunteerRepository`로 변경 - 가독성 및 네이밍 일관성 강화
1 parent e3f03f1 commit cb679a7

File tree

2 files changed

+2
-14
lines changed

2 files changed

+2
-14
lines changed

src/main/java/com/somemore/domains/volunteer/service/VolunteerQueryService.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package com.somemore.domains.volunteer.service;
22

33
import com.somemore.domains.volunteer.domain.Volunteer;
4-
import com.somemore.domains.volunteer.domain.VolunteerDetail;
54
import com.somemore.domains.volunteer.dto.response.VolunteerRankingResponseDto;
65
import com.somemore.domains.volunteer.repository.VolunteerDetailRepository;
76
import com.somemore.domains.volunteer.repository.VolunteerRepository;
@@ -70,15 +69,4 @@ public void validateVolunteerExists(UUID volunteerId) {
7069
throw new BadRequestException(NOT_EXISTS_VOLUNTEER.getMessage());
7170
}
7271
}
73-
74-
private Volunteer findVolunteer(UUID volunteerId) {
75-
return volunteerRepository.findById(volunteerId)
76-
.orElseThrow(() -> new BadRequestException(NOT_EXISTS_VOLUNTEER));
77-
}
78-
79-
private VolunteerDetail findVolunteerDetail(UUID volunteerId) {
80-
return volunteerDetailRepository.findByVolunteerId(volunteerId)
81-
.orElseThrow(() -> new BadRequestException(NOT_EXISTS_VOLUNTEER));
82-
}
83-
8472
}

src/main/java/com/somemore/volunteer/service/RegisterNEWVolunteerService.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@
1414
@Transactional
1515
public class RegisterNEWVolunteerService implements NEWRegisterVolunteerUseCase {
1616

17-
private final NEWVolunteerRepository NEWVolunteerRepository;
17+
private final NEWVolunteerRepository volunteerRepository;
1818

1919
@Override
2020
public void register(UUID userId) {
2121
NEWVolunteer volunteer = NEWVolunteer.createDefault(userId);
2222

23-
NEWVolunteerRepository.save(volunteer);
23+
volunteerRepository.save(volunteer);
2424
}
2525
}

0 commit comments

Comments
 (0)