test: findByIdOrThrow() -> findById() 따른 테스트

Author: leebs0521

src/test/java/com/somemore/location/service/query/LocationQueryServiceTest.java

@@ -1,10 +1,8 @@
 package com.somemore.location.service.query;
 
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import com.somemore.IntegrationTestSupport;
-import com.somemore.global.exception.BadRequestException;
 import com.somemore.location.domain.Location;
 import com.somemore.location.repository.LocationRepository;
 import java.math.BigDecimal;
@@ -66,29 +64,4 @@ void findByIdWithDoesNotExistId() {
         assertThat(findLocation).isEmpty();
     }
 
-    @DisplayName("ID로 Location 조회할 수 있다")
-    @Test
-    void findByIdOrThrowWithExistsId() {
-        // given
-        Long id = location.getId();
-
-        // when
-        Location findLocation = locationQueryService.findByIdOrThrow(id);
-
-        // then
-        assertThat(findLocation.getId()).isEqualTo(id);
-    }
-
-    @DisplayName("존재하지 않는 ID로 Location 조회하면 에러가 발생한다")
-    @Test
-    void findByIdOrThrowWithDoesNotExistId() {
-        // given
-        Long wrongId = 999L;
-
-        // when
-        // then
-        assertThatThrownBy(
-            () -> locationQueryService.findByIdOrThrow(wrongId)
-        ).isInstanceOf(BadRequestException.class);
-    }
 }

src/test/java/com/somemore/recruitboard/service/query/RecruitQueryServiceTest.java

@@ -3,10 +3,8 @@
 import static com.somemore.common.fixture.LocalDateTimeFixture.createStartDateTime;
 import static com.somemore.recruitboard.domain.VolunteerType.OTHER;
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatThrownBy;
 
 import com.somemore.IntegrationTestSupport;
-import com.somemore.global.exception.BadRequestException;
 import com.somemore.recruitboard.domain.RecruitBoard;
 import com.somemore.recruitboard.domain.VolunteerInfo;
 import com.somemore.recruitboard.repository.RecruitBoardRepository;
@@ -22,7 +20,7 @@
 class RecruitQueryServiceTest extends IntegrationTestSupport {
 
     @Autowired
-    private RecruitQueryService recruitQueryService;
+    private RecruitBoardQueryService recruitQueryService;
 
     @Autowired
     private RecruitBoardRepository recruitBoardRepository;
@@ -66,33 +64,6 @@ void findByIdWithDoesNotExistId() {
         assertThat(findBoard).isEmpty();
     }
 
-    @DisplayName("ID로 RecruitBoard 조회할 수 있다")
-    @Test
-    void findByIdOrThrowWithExistsId() {
-        // given
-        Long id = recruitBoard.getId();
-
-        // when
-        RecruitBoard findBoard = recruitQueryService.findByIdOrThrow(id);
-
-        // then
-        assertThat(findBoard.getId()).isEqualTo(id);
-    }
-
-    @DisplayName("존재하지 않는 ID로 RecruitBoard 조회하면 에러가 발생한다")
-    @Test
-    void findByIdOrThrowWithDoesNotExistId() {
-        // given
-        Long wrongId = 999L;
-
-        // when
-        // then
-        assertThatThrownBy(
-            () -> recruitQueryService.findByIdOrThrow(wrongId)
-        ).isInstanceOf(BadRequestException.class);
-
-    }
-
     private static RecruitBoard createRecruitBoard() {
 
         LocalDateTime startDateTime = createStartDateTime();