refactor(community): repository getCommunityBoardWithId -> findById, getCommunityBoardsByWriterId -> findByWriterId 이름 변경

Author: ayoung-dev

src/main/java/com/somemore/community/repository/CommunityBoardRepository.java

@@ -8,8 +8,8 @@
 
 public interface CommunityBoardRepository {
     CommunityBoard save(CommunityBoard communityBoard);
-    Optional<CommunityBoard> getCommunityBoardWithId(Long id);
+    Optional<CommunityBoard> findById(Long id);
     List<CommunityBoard> getCommunityBoards();
-    List<CommunityBoard> getCommunityBoardsByWriterId(UUID writerId);
+    List<CommunityBoard> findByWriterId(UUID writerId);
     void deleteAllInBatch();
 }

src/main/java/com/somemore/community/repository/CommunityRepositoryImpl.java

@@ -23,7 +23,7 @@ public CommunityBoard save(CommunityBoard communityBoard) {
     }
 
     @Override
-    public Optional<CommunityBoard> getCommunityBoardWithId(Long id) {
+    public Optional<CommunityBoard> findById(Long id) {
         QCommunityBoard communityBoard = QCommunityBoard.communityBoard;
 
         return Optional.ofNullable(queryFactory
@@ -45,7 +45,7 @@ public List<CommunityBoard> getCommunityBoards() {
     }
 
     @Override
-    public List<CommunityBoard> getCommunityBoardsByWriterId(UUID writerId) {
+    public List<CommunityBoard> findByWriterId(UUID writerId) {
         QCommunityBoard communityBoard = QCommunityBoard.communityBoard;
 
         return queryFactory

src/main/java/com/somemore/community/service/query/CommunityBoardQueryService.java

@@ -43,7 +43,7 @@ public List<CommunityBoardGetResponseDto> getCommunityBoards() {
 
     @Override
     public List<CommunityBoardGetResponseDto> getCommunityBoardsByWriterId(UUID writerId) {
-        List<CommunityBoard> boards = communityBoardRepository.getCommunityBoardsByWriterId(writerId);
+        List<CommunityBoard> boards = communityBoardRepository.findByWriterId(writerId);
         String writerNickname = getWriterNickname(writerId);
 
         return boards.stream()
@@ -53,7 +53,7 @@ public List<CommunityBoardGetResponseDto> getCommunityBoardsByWriterId(UUID writ
 
     @Override
     public CommunityBoardGetDetailResponseDto getCommunityBoardDetail(Long id) {
-        CommunityBoard board = communityBoardRepository.getCommunityBoardWithId(id)
+        CommunityBoard board = communityBoardRepository.findById(id)
                 .orElseThrow(() -> new BadRequestException(NOT_EXISTS_COMMUNITY_BOARD.getMessage()));
 
         return CommunityBoardGetDetailResponseDto.fromEntity(board, getWriterDetail(board.getWriterId()));

src/test/java/com/somemore/community/repository/CommunityRepositoryTest.java

@@ -33,7 +33,7 @@ void getCommunityBoardById() {
         communityBoardRepository.save(communityBoard);
 
         //when
-        Optional<CommunityBoard> foundCommunityBoard = communityBoardRepository.getCommunityBoardWithId(communityBoard.getId());
+        Optional<CommunityBoard> foundCommunityBoard = communityBoardRepository.findById(communityBoard.getId());
 
         //then
         assertThat(foundCommunityBoard).isNotNull();
@@ -58,7 +58,7 @@ void getCommunityBoardByDeletedId() {
         communityBoardRepository.deleteAllInBatch();
 
         //when
-        Optional<CommunityBoard> foundCommunityBoard = communityBoardRepository.getCommunityBoardWithId(communityBoard.getId());
+        Optional<CommunityBoard> foundCommunityBoard = communityBoardRepository.findById(communityBoard.getId());
 
         //then
         assertThat(foundCommunityBoard).isEmpty();
@@ -124,7 +124,7 @@ void getCommunityBoardsByWriterId() {
         communityBoardRepository.save(communityBoard3);
 
         //when
-        List<CommunityBoard> communityBoards = communityBoardRepository.getCommunityBoardsByWriterId(communityBoard1.getWriterId());
+        List<CommunityBoard> communityBoards = communityBoardRepository.findByWriterId(communityBoard1.getWriterId());
 
         //then
         assertThat(communityBoards).hasSize(2);

src/test/java/com/somemore/community/service/command/CreateCommunityBoardServiceTest.java

@@ -41,7 +41,7 @@ void createCommunityWithDto() {
         Long communityId = createCommunityBoardService.createCommunityBoard(dto, writerId, imgUrl);
 
         //then
-        Optional<CommunityBoard> communityBoard = communityBoardRepository.getCommunityBoardWithId(communityId);
+        Optional<CommunityBoard> communityBoard = communityBoardRepository.findById(communityId);
 
         assertThat(communityBoard).isPresent();
         assertThat(communityBoard.get().getId()).isEqualTo(communityId);
@@ -67,7 +67,7 @@ void createCommunityWithoutImgUrl() {
         Long communityId = createCommunityBoardService.createCommunityBoard(dto, writerId, imgUrl);
 
         //then
-        Optional<CommunityBoard> communityBoard = communityBoardRepository.getCommunityBoardWithId(communityId);
+        Optional<CommunityBoard> communityBoard = communityBoardRepository.findById(communityId);
 
         assertThat(communityBoard).isPresent();
         assertThat(communityBoard.get().getId()).isEqualTo(communityId);

src/test/java/com/somemore/community/service/query/CommunityBoardQueryServiceTest.java

@@ -85,8 +85,8 @@ void getAllCommunityBoards() {
         List<CommunityBoardGetResponseDto> dtos = communityBoardQueryService.getCommunityBoards();
 
         // then
-        Optional<CommunityBoard> communityBoard1 = communityBoardRepository.getCommunityBoardWithId(communityId1);
-        Optional<CommunityBoard> communityBoard2 = communityBoardRepository.getCommunityBoardWithId(communityId2);
+        Optional<CommunityBoard> communityBoard1 = communityBoardRepository.findById(communityId1);
+        Optional<CommunityBoard> communityBoard2 = communityBoardRepository.findById(communityId2);
 
 
         assertThat(dtos)
@@ -135,8 +135,8 @@ void getCommunityBoardsByWriter() {
         List<CommunityBoardGetResponseDto> dtos = communityBoardQueryService.getCommunityBoardsByWriterId(volunteer.getId());
 
         //then
-        Optional<CommunityBoard> communityBoard1 = communityBoardRepository.getCommunityBoardWithId(communityId1);
-        Optional<CommunityBoard> communityBoard2 = communityBoardRepository.getCommunityBoardWithId(communityId2);
+        Optional<CommunityBoard> communityBoard1 = communityBoardRepository.findById(communityId1);
+        Optional<CommunityBoard> communityBoard2 = communityBoardRepository.findById(communityId2);
 
         assertThat(dtos)
                 .isNotNull()