refactor(recruit-board): 시간 검증 로직 변경

 - Service 계층에서 Clock 사용

Author: leebs0521

src/main/java/com/somemore/domains/recruitboard/controller/RecruitBoardCommandApiController.java

@@ -1,6 +1,8 @@
 package com.somemore.domains.recruitboard.controller;
 
 
+import static org.springframework.http.MediaType.MULTIPART_FORM_DATA_VALUE;
+
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardCreateRequestDto;
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardLocationUpdateRequestDto;
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardStatusUpdateRequestDto;
@@ -15,16 +17,20 @@
 import io.swagger.v3.oas.annotations.Operation;
 import io.swagger.v3.oas.annotations.tags.Tag;
 import jakarta.validation.Valid;
+import java.util.UUID;
 import lombok.RequiredArgsConstructor;
 import org.springframework.security.access.annotation.Secured;
-import org.springframework.web.bind.annotation.*;
+import org.springframework.web.bind.annotation.DeleteMapping;
+import org.springframework.web.bind.annotation.PatchMapping;
+import org.springframework.web.bind.annotation.PathVariable;
+import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.PutMapping;
+import org.springframework.web.bind.annotation.RequestBody;
+import org.springframework.web.bind.annotation.RequestMapping;
+import org.springframework.web.bind.annotation.RequestPart;
+import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.multipart.MultipartFile;
 
-import java.time.LocalDateTime;
-import java.util.UUID;
-
-import static org.springframework.http.MediaType.MULTIPART_FORM_DATA_VALUE;
-
 @Tag(name = "Recruit Board Command API", description = "봉사 활동 모집글 생성 수정 삭제 API")
 @RequiredArgsConstructor
 @RequestMapping("/api")
@@ -44,7 +50,6 @@ public ApiResponse<Long> createRecruitBoard(
             @Valid @RequestPart("data") RecruitBoardCreateRequestDto requestDto,
             @RequestPart(value = "img_file", required = false) MultipartFile image
     ) {
-
         String imgUrl = imageUploadUseCase.uploadImage(new ImageUploadRequestDto(image));
         return ApiResponse.ok(
                 201,
@@ -63,9 +68,7 @@ public ApiResponse<String> updateRecruitBoard(
             @RequestPart(value = "img_file", required = false) MultipartFile image
     ) {
         String imgUrl = imageUploadUseCase.uploadImage(new ImageUploadRequestDto(image));
-        LocalDateTime now = LocalDateTime.now();
-        updateRecruitBoardUseCase.updateRecruitBoard(requestDto, id, userId, imgUrl, now);
-
+        updateRecruitBoardUseCase.updateRecruitBoard(requestDto, id, userId, imgUrl);
         return ApiResponse.ok("봉사 활동 모집글 수정 성공");
     }
 
@@ -77,8 +80,7 @@ public ApiResponse<String> updateRecruitBoardLocation(
             @PathVariable Long id,
             @Valid @RequestBody RecruitBoardLocationUpdateRequestDto requestDto
     ) {
-        LocalDateTime now = LocalDateTime.now();
-        updateRecruitBoardUseCase.updateRecruitBoardLocation(requestDto, id, userId, now);
+        updateRecruitBoardUseCase.updateRecruitBoardLocation(requestDto, id, userId);
         return ApiResponse.ok("봉사 활동 모집글 위치 수정 성공");
     }
 
@@ -90,9 +92,7 @@ public ApiResponse<String> updateRecruitBoardStatus(
             @PathVariable Long id,
             @RequestBody RecruitBoardStatusUpdateRequestDto requestDto
     ) {
-        LocalDateTime now = LocalDateTime.now();
-        updateRecruitBoardUseCase.updateRecruitBoardStatus(requestDto.status(), id, userId, now);
-
+        updateRecruitBoardUseCase.updateRecruitBoardStatus(requestDto.status(), id, userId);
         return ApiResponse.ok("봉사 활동 모집글 상태 수정 성공");
     }
 
@@ -106,5 +106,4 @@ public ApiResponse<String> deleteRecruitBoard(
         deleteRecruitBoardUseCase.deleteRecruitBoard(userId, id);
         return ApiResponse.ok("봉사 활동 모집글 삭제 성공");
     }
-
 }

src/main/java/com/somemore/domains/recruitboard/service/UpdateRecruitBoardService.java

@@ -8,6 +8,7 @@
 import com.somemore.domains.recruitboard.service.validator.RecruitBoardValidator;
 import com.somemore.domains.recruitboard.usecase.RecruitBoardQueryUseCase;
 import com.somemore.domains.recruitboard.usecase.UpdateRecruitBoardUseCase;
+import java.time.Clock;
 import java.time.LocalDateTime;
 import java.util.UUID;
 import lombok.RequiredArgsConstructor;
@@ -22,12 +23,13 @@ public class UpdateRecruitBoardService implements UpdateRecruitBoardUseCase {
     private final RecruitBoardQueryUseCase recruitBoardQueryUseCase;
     private final UpdateLocationUseCase updateLocationUseCase;
     private final RecruitBoardValidator recruitBoardValidator;
+    private final Clock clock;
 
     @Override
     public void updateRecruitBoard(RecruitBoardUpdateRequestDto dto, Long id, UUID centerId,
-            String imgUrl, LocalDateTime current) {
+            String imgUrl) {
         RecruitBoard recruitBoard = getRecruitBoard(id);
-        validateUpdatableAndWriter(recruitBoard, centerId, current);
+        validateUpdatableAndWriter(recruitBoard, centerId);
 
         recruitBoardValidator.validateUpdateRecruitBoardTime(recruitBoard.getCreatedAt(),
                 dto.volunteerStartDateTime(), dto.volunteerEndDateTime());
@@ -37,27 +39,26 @@ public void updateRecruitBoard(RecruitBoardUpdateRequestDto dto, Long id, UUID c
 
     @Override
     public void updateRecruitBoardLocation(RecruitBoardLocationUpdateRequestDto requestDto, Long id,
-            UUID centerId, LocalDateTime current) {
+            UUID centerId) {
         RecruitBoard recruitBoard = getRecruitBoard(id);
-        validateUpdatableAndWriter(recruitBoard, centerId, current);
+        validateUpdatableAndWriter(recruitBoard, centerId);
 
         updateLocationUseCase.updateLocation(requestDto.toLocationUpdateRequestDto(),
                 recruitBoard.getLocationId());
         recruitBoard.updateWith(requestDto.region());
     }
 
     @Override
-    public void updateRecruitBoardStatus(RecruitStatus status, Long id, UUID centerId,
-            LocalDateTime current) {
+    public void updateRecruitBoardStatus(RecruitStatus status, Long id, UUID centerId) {
         RecruitBoard recruitBoard = getRecruitBoard(id);
-        validateUpdatableAndWriter(recruitBoard, centerId, current);
+        validateUpdatableAndWriter(recruitBoard, centerId);
         recruitBoardValidator.validateRecruitStatus(status);
 
         recruitBoard.updateRecruitStatus(status);
     }
 
-    private void validateUpdatableAndWriter(RecruitBoard recruitBoard, UUID centerId,
-            LocalDateTime current) {
+    private void validateUpdatableAndWriter(RecruitBoard recruitBoard, UUID centerId) {
+        LocalDateTime current = LocalDateTime.now(clock);
         recruitBoardValidator.validateUpdatable(recruitBoard, current);
         recruitBoardValidator.validateWriter(recruitBoard, centerId);
     }

src/main/java/com/somemore/domains/recruitboard/usecase/UpdateRecruitBoardUseCase.java

@@ -3,18 +3,15 @@
 import com.somemore.domains.recruitboard.domain.RecruitStatus;
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardLocationUpdateRequestDto;
 import com.somemore.domains.recruitboard.dto.request.RecruitBoardUpdateRequestDto;
-import java.time.LocalDateTime;
 import java.util.UUID;
 
 public interface UpdateRecruitBoardUseCase {
 
-    void updateRecruitBoard(RecruitBoardUpdateRequestDto dto, Long id, UUID centerId, String imgUrl,
-            LocalDateTime current);
-
+    void updateRecruitBoard(RecruitBoardUpdateRequestDto dto, Long id, UUID centerId,
+            String imgUrl);
 
     void updateRecruitBoardLocation(RecruitBoardLocationUpdateRequestDto requestDto, Long id,
-            UUID centerId, LocalDateTime current);
+            UUID centerId);
 
-    void updateRecruitBoardStatus(RecruitStatus status, Long id, UUID centerId,
-            LocalDateTime currentDateTime);
+    void updateRecruitBoardStatus(RecruitStatus status, Long id, UUID centerId);
 }