Skip to content

Commit e8db6e0

Browse files
committed
Fix: 코드 리뷰 사항 반영
- 서비스 레이어의 public 메서드를 상단에 배치하여 가독성 향상 - CQRS 적용을 위한 Query, Command 서비스 클래스에 @Transactinal(readOnly = true), @Transactinal 어노테이션을 각각 추가 - 레포지토리의 불필요한 @query 어노테이션 삭제
1 parent 10130f2 commit e8db6e0

File tree

4 files changed

+10
-7
lines changed

4 files changed

+10
-7
lines changed

src/main/java/com/somemore/center/repository/PreferItemRepository.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import com.somemore.center.domain.PreferItem;
44
import org.springframework.data.jpa.repository.JpaRepository;
5-
import org.springframework.data.jpa.repository.Query;
65
import org.springframework.data.repository.query.Param;
76
import org.springframework.stereotype.Repository;
87

@@ -12,7 +11,6 @@
1211
@Repository
1312
public interface PreferItemRepository extends JpaRepository<PreferItem, Long> {
1413

15-
@Query("SELECT p FROM PreferItem p WHERE p.centerId = :centerId")
1614
List<PreferItem> findByCenterId(@Param("centerId") UUID centerId);
1715

1816
}

src/main/java/com/somemore/center/service/command/CreatePreferItemService.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,10 @@
66
import com.somemore.center.usecase.query.CenterQueryUseCase;
77
import lombok.RequiredArgsConstructor;
88
import org.springframework.stereotype.Service;
9+
import org.springframework.transaction.annotation.Transactional;
910

1011
@RequiredArgsConstructor
12+
@Transactional
1113
@Service
1214
public class CreatePreferItemService implements CreatePreferItemUseCase {
1315

@@ -21,4 +23,5 @@ public void createPreferItem(PreferItemCreateRequestDto requestDto) {
2123

2224
preferItemRepository.save(requestDto.createPreferItem());
2325
}
26+
2427
}

src/main/java/com/somemore/center/service/query/CenterQueryService.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -32,16 +32,16 @@ public CenterProfileResponseDto getCenterProfileByCenterId(UUID centerId) {
3232
return CenterProfileResponseDto.of(center, preferItems);
3333
}
3434

35-
private Center getCenterById(UUID centerId) {
36-
return centerRepository.findCenterById(centerId)
37-
.orElseThrow(() -> new BadRequestException(NOT_EXISTS_CENTER.getMessage()));
38-
}
39-
4035
@Override
4136
public void validateCenterExists(UUID id) {
4237
if (centerRepository.doesNotExistById(id)) {
4338
throw new BadRequestException(NOT_EXISTS_CENTER.getMessage());
4439
}
4540
}
4641

42+
private Center getCenterById(UUID centerId) {
43+
return centerRepository.findCenterById(centerId)
44+
.orElseThrow(() -> new BadRequestException(NOT_EXISTS_CENTER.getMessage()));
45+
}
46+
4747
}

src/main/java/com/somemore/center/service/query/PreferItemQueryService.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,13 @@
55
import com.somemore.center.usecase.query.PreferItemQueryUseCase;
66
import lombok.RequiredArgsConstructor;
77
import org.springframework.stereotype.Service;
8+
import org.springframework.transaction.annotation.Transactional;
89

910
import java.util.List;
1011
import java.util.UUID;
1112

1213
@RequiredArgsConstructor
14+
@Transactional(readOnly = true)
1315
@Service
1416
public class PreferItemQueryService implements PreferItemQueryUseCase {
1517

0 commit comments

Comments
 (0)