test(refactor): 테스트 리팩토링

- 소나 큐브 이슈 해결

Author: m-a-king

src/test/java/com/somemore/user/repository/usercommonattribute/UserCommonAttributeRepositoryImplTest.java

@@ -29,13 +29,14 @@ void saveUserCommonAttribute() {
         UserCommonAttribute savedUserCommonAttribute = userCommonAttributeRepository.save(userCommonAttribute);
 
         // then
-        assertThat(savedUserCommonAttribute).isNotNull();
-        assertThat(savedUserCommonAttribute).isEqualTo(userCommonAttribute);
+        assertThat(savedUserCommonAttribute)
+                .isNotNull()
+                .isEqualTo(userCommonAttribute);
 
         assertThat(savedUserCommonAttribute.getId()).isNotNull();
         assertThat(savedUserCommonAttribute.getUserId()).isEqualTo(userId);
         assertThat(savedUserCommonAttribute.getImgUrl()).isEqualTo(ImageUploadService.DEFAULT_IMAGE_URL);
-        assertThat(savedUserCommonAttribute.isCustomized()).isEqualTo(false);
+        assertThat(savedUserCommonAttribute.isCustomized()).isFalse();
 
     }
 }

src/test/java/com/somemore/user/repository/usersetting/UserSettingRepositoryImplTest.java

@@ -30,8 +30,9 @@ void findByUserId() {
         Optional<UserSetting> foundUserSetting = userSettingRepository.findByUserId(userId);
 
         // then
-        assertThat(foundUserSetting).isNotNull();
-        assertThat(foundUserSetting).get().isEqualTo(savedUserSetting);
+        assertThat(foundUserSetting)
+                .isPresent()
+                .hasValue(savedUserSetting);
     }
 
     @DisplayName("유저 세팅을 저장할 수 있다.")
@@ -47,7 +48,7 @@ void saveUserSetting() {
         // then
         assertThat(savedUserSetting).isNotNull();
         assertThat(savedUserSetting.getId()).isNotNull();
-        assertThat(savedUserSetting.isAuthenticated()).isEqualTo(false);
-        assertThat(savedUserSetting.isSmsAgreed()).isEqualTo(false);
+        assertThat(savedUserSetting.isAuthenticated()).isFalse();
+        assertThat(savedUserSetting.isSmsAgreed()).isFalse();
     }
 }

src/test/java/com/somemore/user/service/RegisterUserServiceTest.java

@@ -37,10 +37,6 @@ class RegisterUserServiceTest extends IntegrationTestSupport {
     @Autowired
     private UserCommonAttributeRepository userCommonAttributeRepository;
 
-    @BeforeEach
-    void setup() {
-    }
-
     @DisplayName("OAuth 사용자를 기본 ROLE인 봉사자로 등록할 수 있다.")
     @Test
     void registerOAuthUser() {
@@ -58,8 +54,8 @@ void registerOAuthUser() {
 
         assertThat(savedUser).isNotNull();
         assertThat(savedUser.getRole()).isEqualTo(UserRole.getOAuthUserDefaultRole());
-        assertThat(savedUser.getEmail().length()).isEqualTo(UUID.randomUUID().toString().length() + provider.getProviderName().length());
-
+        assertThat(savedUser.getEmail())
+                .hasSize(UUID.randomUUID().toString().length() + provider.getProviderName().length());
         assertThat(savedSetting).isNotNull();
         assertThat(savedSetting.getUserId()).isEqualTo(savedUser.getId());
         boolean userDefaultSetting = false;
@@ -68,7 +64,7 @@ void registerOAuthUser() {
 
         assertThat(savedCommonAttribute).isNotNull();
         assertThat(savedCommonAttribute.getUserId()).isEqualTo(savedUser.getId());
-        assertThat(savedCommonAttribute.getNickname().length()).isEqualTo(8);
+        assertThat(savedCommonAttribute.getNickname()).hasSize(8);
         assertThat(savedCommonAttribute.getIntroduce()).isEqualTo("");
         assertThat(savedCommonAttribute.getImgUrl()).isEqualTo(ImageUploadService.DEFAULT_IMAGE_URL);
         assertThat(savedCommonAttribute.isCustomized()).isEqualTo(userDefaultSetting);
@@ -102,7 +98,7 @@ void registerLocalUser() {
 
         assertThat(savedCommonAttribute).isNotNull();
         assertThat(savedCommonAttribute.getUserId()).isEqualTo(savedUser.getId());
-        assertThat(savedCommonAttribute.getNickname().length()).isEqualTo(8);
+        assertThat(savedCommonAttribute.getNickname()).hasSize(8);
         assertThat(savedCommonAttribute.getIntroduce()).isEqualTo("");
         assertThat(savedCommonAttribute.getImgUrl()).isEqualTo(ImageUploadService.DEFAULT_IMAGE_URL);
         assertThat(savedCommonAttribute.isCustomized()).isEqualTo(userDefaultSetting);

src/test/java/com/somemore/user/service/UserQueryServiceTest.java

@@ -72,6 +72,6 @@ void getIsCustomizedByUserId_ReturnsFalse_WhenDefaultValue() {
         boolean isCustomized = userQueryService.getIsCustomizedByUserId(user.getId());
 
         // then
-        assertThat(isCustomized).isEqualTo(false);
+        assertThat(isCustomized).isFalse();
     }
 }