refactor: 기관 프로필 조회 리팩토링

7zrv · 7zrv · commit f97f57311421 · 2025-01-25T04:43:37.000+09:00
- 기존 userId를 이용한 조회에서 기관 자체 PK를 이용한 조회 방식으로 리팩토링
- 테스트및 검증 완료
diff --git a/src/main/java/com/somemore/center/controller/CenterQueryApiController.java b/src/main/java/com/somemore/center/controller/CenterQueryApiController.java
@@ -22,10 +22,10 @@ public class CenterQueryApiController {
     private final NEWCenterQueryUseCase centerQueryUseCase;
 
     @Operation(summary = "기관 프로필 조회 API")
-    @GetMapping("/profile/{userId}")
-    public ApiResponse<CenterProfileResponseDto> getCenterProfile(@PathVariable UUID userId) {
+    @GetMapping("/profile/{centerId}")
+    public ApiResponse<CenterProfileResponseDto> getCenterProfile(@PathVariable UUID centerId) {
 
-        CenterProfileResponseDto responseDto = centerQueryUseCase.getCenterProfileByUserId(userId);
+        CenterProfileResponseDto responseDto = centerQueryUseCase.getCenterProfileById(centerId);
 
         return ApiResponse.ok(200, responseDto, "기관 프로필 조회 성공");
     }
diff --git a/src/main/java/com/somemore/center/repository/NEWCenterRepository.java b/src/main/java/com/somemore/center/repository/NEWCenterRepository.java
@@ -14,5 +14,5 @@ public interface NEWCenterRepository {
 
     Optional<NEWCenter> findByUserId(UUID userId);
 
-    Optional<CenterProfileDto> findCenterProfileByUserId(UUID userId);
+    Optional<CenterProfileDto> findCenterProfileById(UUID centerId);
 }
diff --git a/src/main/java/com/somemore/center/repository/NEWCenterRepositoryImpl.java b/src/main/java/com/somemore/center/repository/NEWCenterRepositoryImpl.java
@@ -51,15 +51,16 @@ public Optional<NEWCenter> findByUserId(UUID userId) {
         );
     }
 
-    public Optional<CenterProfileDto> findCenterProfileByUserId(UUID userId) {
+    @Override
+    public Optional<CenterProfileDto> findCenterProfileById(UUID centerId) {
         return Optional.ofNullable(
                 queryFactory.select(Projections.constructor(CenterProfileDto.class,
                                 center.id,
                                 center.userId,
                                 center.homepageUrl))
                         .from(center)
                         .where(
-                                center.userId.eq(userId),
+                                center.id.eq(centerId),
                                 isNotDeleted()
                         )
                         .fetchOne()
diff --git a/src/main/java/com/somemore/center/service/NEWCenterQueryService.java b/src/main/java/com/somemore/center/service/NEWCenterQueryService.java
@@ -39,12 +39,12 @@ public UUID getIdByUserId(UUID userId) {
     }
 
     @Override
-    public CenterProfileResponseDto getCenterProfileByUserId(UUID userId) {
+    public CenterProfileResponseDto getCenterProfileById(UUID centerId) {
 
-        CenterProfileDto centerProfileDto = centerRepository.findCenterProfileByUserId(userId)
+        CenterProfileDto centerProfileDto = centerRepository.findCenterProfileById(centerId)
                 .orElseThrow(() -> new NoSuchElementException(ExceptionMessage.NOT_EXISTS_CENTER));
 
-        UserProfileDto userProfileDto = userQueryUseCase.getUserProfileByUserId(userId);
+        UserProfileDto userProfileDto = userQueryUseCase.getUserProfileByUserId(centerProfileDto.userId());
 
         List<PreferItemResponseDto> preferItems = preferItemQueryUseCase.getPreferItemDtosByCenterId(centerProfileDto.id());
 
diff --git a/src/main/java/com/somemore/center/usecase/NEWCenterQueryUseCase.java b/src/main/java/com/somemore/center/usecase/NEWCenterQueryUseCase.java
@@ -11,5 +11,5 @@ public interface NEWCenterQueryUseCase {
 
     UUID getIdByUserId(UUID userId);
 
-    CenterProfileResponseDto getCenterProfileByUserId(UUID userId);
+    CenterProfileResponseDto getCenterProfileById(UUID centerId);
 }
diff --git a/src/test/java/com/somemore/center/controller/CenterQueryApiControllerTest.java b/src/test/java/com/somemore/center/controller/CenterQueryApiControllerTest.java
@@ -25,14 +25,14 @@ class CenterQueryApiControllerTest extends ControllerTestSupport {
     @MockBean
     protected NEWCenterQueryUseCase centerQueryUseCase;
 
-    private UUID userId;
+    private UUID centerId;
     private CenterProfileResponseDto responseDto;
 
     @BeforeEach
     void setUp() {
-        userId = UUID.randomUUID();
+        centerId = UUID.randomUUID();
         responseDto = CenterProfileResponseDto.builder()
-                .id(userId)
+                .id(centerId)
                 .userId(UUID.randomUUID())
                 .homepageUrl("http://example.com")
                 .name("Test Center")
@@ -43,21 +43,21 @@ void setUp() {
                 .build();
     }
 
-    @DisplayName("유저 ID로 기관 유저 프로필을 조회할 수 있다. (controller)")
+    @DisplayName("기관 ID로 기관 프로필을 조회할 수 있다. (controller)")
     @Test
     void getCenterProfile() throws Exception {
         // given
-        when(centerQueryUseCase.getCenterProfileByUserId(userId)).thenReturn(responseDto);
+        when(centerQueryUseCase.getCenterProfileById(centerId)).thenReturn(responseDto);
 
         // when & then
         mockMvc.perform(
-                        get("/api/center/profile/{userId}", userId)
+                        get("/api/center/profile/{centerId}", centerId)
                                 .contentType(MediaType.APPLICATION_JSON)
                 )
                 .andExpect(status().isOk())
                 .andExpect(jsonPath("$.code").value("200"))
                 .andExpect(jsonPath("$.message").value("기관 프로필 조회 성공"))
-                .andExpect(jsonPath("$.data.id").value(userId.toString()))
+                .andExpect(jsonPath("$.data.id").value(centerId.toString()))
                 .andExpect(jsonPath("$.data.user_id").value(responseDto.userId().toString()))
                 .andExpect(jsonPath("$.data.homepage_url").value(responseDto.homepageUrl()))
                 .andExpect(jsonPath("$.data.name").value(responseDto.name()))
@@ -66,27 +66,27 @@ void getCenterProfile() throws Exception {
                 .andExpect(jsonPath("$.data.introduce").value(responseDto.introduce()))
                 .andExpect(jsonPath("$.data.prefer_items").isArray());
 
-        verify(centerQueryUseCase, times(1)).getCenterProfileByUserId(userId);
+        verify(centerQueryUseCase, times(1)).getCenterProfileById(centerId);
     }
 
     @DisplayName("존재하지 않는 유저 ID로 조회 시 예외가 발생한다. (controller)")
     @Test
     void getCenterProfile_NotFound() throws Exception {
         // given
         UUID nonExistentuserId = UUID.randomUUID();
-        when(centerQueryUseCase.getCenterProfileByUserId(nonExistentuserId))
+        when(centerQueryUseCase.getCenterProfileById(nonExistentuserId))
                 .thenThrow(new BadRequestException(NOT_EXISTS_CENTER.getMessage()));
 
         // when & then
         mockMvc.perform(
-                        get("/api/center/profile/{userId}", nonExistentuserId)
+                        get("/api/center/profile/{centerId}", nonExistentuserId)
                                 .contentType(MediaType.APPLICATION_JSON)
                 )
                 .andExpect(status().isBadRequest())
                 .andExpect(jsonPath("$.status").value("400"))
                 .andExpect(jsonPath("$.detail").value("존재하지 않는 기관입니다."));
 
-        verify(centerQueryUseCase, times(1)).getCenterProfileByUserId(nonExistentuserId);
+        verify(centerQueryUseCase, times(1)).getCenterProfileById(nonExistentuserId);
     }
 
 }
diff --git a/src/test/java/com/somemore/center/repository/NEWCenterRepositoryImplTest.java b/src/test/java/com/somemore/center/repository/NEWCenterRepositoryImplTest.java
@@ -39,7 +39,7 @@ void saveVolunteerByUserId() {
 
     }
 
-    @DisplayName("유저 아이디로 기관 정보를 가져올 수 있다.")
+    @DisplayName("기관 아이디로 기관 프로필 정보를 가져올 수 있다.")
     @Test
     void findCenterProfileByUserId() {
 
@@ -49,7 +49,7 @@ void findCenterProfileByUserId() {
         centerRepository.save(center);
 
         // when
-        Optional<CenterProfileDto> result = centerRepository.findCenterProfileByUserId(userId);
+        Optional<CenterProfileDto> result = centerRepository.findCenterProfileById(center.getId());
 
         // then
         assertThat(result).isPresent();
@@ -63,10 +63,10 @@ void findCenterProfileByUserId() {
     void findCenterProfileByUserId_NoResult() {
 
         // given
-        UUID nonExistentUserId = UUID.randomUUID();
+        UUID nonExistentCenterId = UUID.randomUUID();
 
         // when
-        Optional<CenterProfileDto> result = centerRepository.findCenterProfileByUserId(nonExistentUserId);
+        Optional<CenterProfileDto> result = centerRepository.findCenterProfileById(nonExistentCenterId);
 
         // then
         assertThat(result).isEmpty();
diff --git a/src/test/java/com/somemore/center/service/NEWCenterQueryServiceTest.java b/src/test/java/com/somemore/center/service/NEWCenterQueryServiceTest.java
@@ -90,7 +90,7 @@ void getCenterProfileByUserId() {
         List<PreferItemResponseDto> preferItems = preferItemQueryUseCase.getPreferItemDtosByCenterId(center.getId());
 
         //when
-        CenterProfileResponseDto result = centerQueryService.getCenterProfileByUserId(userId);
+        CenterProfileResponseDto result = centerQueryService.getCenterProfileById(center.getId());
 
         //then
         assertThat(result).isNotNull();

Original file line number	Diff line number	Diff line change
`@@ -14,5 +14,5 @@ public interface NEWCenterRepository {`
`14`	`14`
`15`	`15`	`Optional<NEWCenter> findByUserId(UUID userId);`
`16`	`16`
`17`		`- Optional<CenterProfileDto> findCenterProfileByUserId(UUID userId);`
	`17`	`+ Optional<CenterProfileDto> findCenterProfileById(UUID centerId);`
`18`	`18`	`}`
Original file line number	Diff line number	Diff line change
`@@ -11,5 +11,5 @@ public interface NEWCenterQueryUseCase {`
`11`	`11`
`12`	`12`	`UUID getIdByUserId(UUID userId);`
`13`	`13`
`14`		`- CenterProfileResponseDto getCenterProfileByUserId(UUID userId);`
	`14`	`+ CenterProfileResponseDto getCenterProfileById(UUID centerId);`
`15`	`15`	`}`