Feature/97 봉사자 프로필 수정 #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Problem Detail 사용.
- 닉네임과 소개 필드로 구성된 RequestDto와 ImgUrl로 프로필 업데이트 - Dto의 각 필드 유효한 값인지 검사
Closed
1 task
|
leebs0521
approved these changes
Dec 1, 2024
Collaborator
leebs0521
left a comment
leebs0521
left a comment
There was a problem hiding this comment.
코드 깔끔합니다~
잘 작성해주신것 같아요 고생많으셨습니다.
|
|
||
| problemDetail.setTitle("유효성 예외"); | ||
| problemDetail.setDetail("입력 데이터 유효성 검사가 실패했습니다. 각 필드를 확인해주세요."); | ||
|
|
| VolunteerDetailResponseDto volunteerDetailResponseDto | ||
| @Schema(description = "봉사자 상세 정보", implementation = VolunteerDetailProfileResponseDto.class) | ||
| VolunteerDetailProfileResponseDto volunteerDetailProfileResponseDto | ||
| ) { |
Collaborator
There was a problem hiding this comment.
API 응답에서 필드명으로 "key": "value"로 나가서
volunteerDetailProfileResponseDto -> volunteerDetailProfile 로 필드명(레코드 타입이름이 아닌) 바꾸는게 어떤가요??
"volunteer_detail_profile_reponse_dto" -> "volunteer_detail_profile"
Collaborator
Author
There was a problem hiding this comment.
좋아요! 명세에 적은 details로 변경하면 깔끔할 것 같습니다. 감사합니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved:
📌 과제 설명
👩💻 요구 사항과 구현 내용
봉사자 업데이트 (domain, usecase-service, controller)
build(gradle): validation 의존성 추가spring-boot-starter-validation을 추가하였습니다.feat(GlobalExceptionHandler): 유효성 예외를 전역 예외 핸들러로 처리MethodArgumentNotValidException발생 시 사용자에게 명확한 오류 메시지를 제공하도록GlobalExceptionHandler를 수정하였습니다. 일관성을 위해서 기존의 상속 구조를 포기했습니다.Volunteer 패키지 내의 명확하지 않은 클래스들 Rename.
✅ PR 포인트 & 궁금한 점