Feature/97 봉사자 프로필 수정 #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Problem Detail 사용.
- 닉네임과 소개 필드로 구성된 RequestDto와 ImgUrl로 프로필 업데이트 - Dto의 각 필드 유효한 값인지 검사
…tailProfileResponseDto에서 'detail'로 변경 - API 명세에 맞게 응답 값을 수정 - 내부 private record 이므로 과감한 네이밍 개선
Closed
1 task
7zrv
reviewed
Dec 1, 2024
| class VolunteerProfileCommandControllerTest extends ControllerTestSupport { | ||
|
|
||
| @Autowired | ||
| private MockMvc mockMvc; |
Collaborator
There was a problem hiding this comment.
controllerTestSupport에 들어있어서 지우셔도 됩니다!
7zrv
approved these changes
Dec 1, 2024
- 상속받는 서포트 클래스에 존재하는 의존성 주입을 테스트 클래스에서 삭제
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved:
📌 과제 설명
👩💻 요구 사항과 구현 내용
봉사자 업데이트 (domain, usecase-service, controller)
build(gradle): validation 의존성 추가spring-boot-starter-validation을 추가하였습니다.feat(GlobalExceptionHandler): 유효성 예외를 전역 예외 핸들러로 처리MethodArgumentNotValidException발생 시 사용자에게 명확한 오류 메시지를 제공하도록GlobalExceptionHandler를 수정하였습니다. 일관성을 위해서 기존의 상속 구조를 포기했습니다.Volunteer 패키지 내의 명확하지 않은 클래스들 Rename.
✅ PR 포인트 & 궁금한 점