Feature/129 봉사 지원 승인/거절 #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
ayoung-dev
approved these changes
Dec 3, 2024
Collaborator
ayoung-dev
left a comment
ayoung-dev
left a comment
There was a problem hiding this comment.
저도 범수님 의견 들으니 추후에 검증 절차가 달라질 수도 있겠다고 생각되어 나누는 거 좋은 거 같습니다!
고생하셨습니다
leebs0521
force-pushed
the
feature/129-add-volunteer-apply-approve
branch
from
abd2d58 to
606c027
Compare
m-a-king
approved these changes
Dec 3, 2024
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고하셨습니다! 승인과 거절을 명확히 나눈 판단은 좋은 선택이라 생각합니다.
또, 승인이나 거절의 검증을 서비스가 아닌 도메인 자체에서 처리할 수 있는지 고민해봤지만, 현재 구조가 더 적합하다고 판단됩니다. 잘 구현해 주신 것 같습니다~
Comment on lines
+23
to
+24
| private final ApproveVolunteerApplyUseCase approveVolunteerApplyUseCase; | ||
| private final RejectVolunteerApplyUseCase rejectVolunteerApplyUseCase; |
leebs0521
force-pushed
the
feature/129-add-volunteer-apply-approve
branch
from
606c027 to
0f8d4eb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점