-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/189 봉사 후기 요청 이벤트, 알림 #203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
m-a-king
merged 12 commits into
main
from
feature/189-add-notification-enable-volunteer-review-event
Dec 8, 2024
Merged
Feature/189 봉사 후기 요청 이벤트, 알림 #203
m-a-king
merged 12 commits into
main
from
feature/189-add-notification-enable-volunteer-review-event
Dec 8, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leebs0521
approved these changes
Dec 8, 2024
Collaborator
leebs0521
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트 코드까지 고생하셨습니다.!
- oldStatus 추가. - 이벤트에 receiverId가 포함되는 것이 어색, volunteerId로 수정.
- SettleVolunteerApplyFacadeService 에서 이벤트 발생. - subType 명명 수정.
- DB save 작업
- buildVolunteerApplyStatusChangeNotification 와 형태가 비슷해서 리팩토링 예정. - createVolunteerApplyStatusChangeNotificationTitle dafault를 명확하게 예외로 처리.
6e41ff2 to
9368992
Compare
|
7zrv
approved these changes
Dec 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



resolved :
📌 과제 설명
봉사 정산이 완료된 후, 유저가 후기를 작성할 수 있는 상태가 되면 봉사 후기 요청 이벤트가 발생합니다.
이 이벤트는 Redis Pub/Sub과 SSE를 통해 클라이언트에게 전달되며, 전체 흐름은 다음과 같습니다:
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점