Feature/198 모집글 스케쥴링 #205
Closed
Feature/198 모집글 스케쥴링 #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
|
ayoung-dev
reviewed
Dec 8, 2024
Comment on lines
+71
to
+75
| schedules: | ||
| cron: | ||
| updateBoardsToClosed: "0 0 0 * * ?" # updateBoardsToClosed 스케줄링 cron 표현식 | ||
| updateBoardsToCompleted: "0 0 0 * * ?" # updateBoardsToCompleted 스케줄링 cron 표현식 | ||
|
|
m-a-king
approved these changes
Dec 8, 2024
Collaborator
There was a problem hiding this comment.
00시와 24시를 나눠주는 친절한 범수 님!
이해가 잘 됐습니다.
|
|
||
| private final RecruitBoardRepository recruitBoardRepository; | ||
|
|
||
| @Scheduled(cron = "${spring.schedules.cron.updateBoardsToClosed}") |
Collaborator
There was a problem hiding this comment.
Suggested change
| @Scheduled(cron = "${spring.schedules.cron.updateBoardsToClosed}") | |
| @Retryable( | |
| value = Exception.class, | |
| maxAttempts = 3, | |
| backoff = @Backoff(delay = 100000) // 100초 후 재시도 | |
| ) | |
| @Scheduled(cron = "${spring.schedules.cron.updateBoardsToClosed}") |
이런 재시도 로직도 가능할 것 같아요!
| List<RecruitBoard> boards = recruitBoardRepository.findByStartDateTimeBetweenAndStatus( | ||
| startOfDay, startOfNextDay, RECRUITING); | ||
|
|
||
| boards.forEach(RecruitBoard::markAsClosed); |
Collaborator
There was a problem hiding this comment.
아니면 여기서 실패 로직이 나오면 데드 레터 큐 방식으로 레디스로 서버 이벤트를 발행하고 처리할 수 있을 것 같아요~~
| List<RecruitBoard> boards = recruitBoardRepository.findByStartDateTimeBetweenAndStatus( | ||
| startOfDay, startOfNextDay, RECRUITING); | ||
|
|
||
| boards.forEach(RecruitBoard::markAsClosed); |
Collaborator
There was a problem hiding this comment.
Suggested change
| boards.forEach(RecruitBoard::markAsClosed); | |
| boards.forEach(board -> { | |
| try { | |
| board.markAsClosed(); | |
| } catch (Exception e) { | |
| // event 생성 | |
| serverEventPublisher.publish(event); | |
| log.warn("보드 업데이트 실패: {} (ID: {})", e.getMessage(), board.getId()); | |
| } | |
| }); |
| private final RecruitBoardRepository recruitBoardRepository; | ||
|
|
||
| @Scheduled(cron = "${spring.schedules.cron.updateBoardsToClosed}") | ||
| public synchronized void transitionBoardsToClosed() { |
Collaborator
There was a problem hiding this comment.
synchronized 키워드는 왜 적으셨는지 궁금합니다!
테스트 코드에서 스케줄러 호출때문에 그런걸까요?
ayoung-dev
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
봉사 시작 당일 00시 모집상태는 모집 완료로 변경
봉사 종료 후 그날 24시 모집 상태는 완료로 변경
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점