[FEATURE] 리뷰 수정 및 삭제 #263
Merged
[FEATURE] 리뷰 수정 및 삭제 #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
7zrv
reviewed
Dec 31, 2024
|
|
||
| @Override | ||
| public void deleteReview(UUID volunteerId, Long id) { | ||
| Review review = reviewRepository.findById(id).orElseThrow( |
Collaborator
There was a problem hiding this comment.
리뷰 쿼리 유스케이스에 findById가 존재하는데 쿼리 유스케이스를 주입하는건 어떻게 생각하시나요
중복 코드라는 생각이 들어서 말씀드려봤습니다
7zrv
reviewed
Dec 31, 2024
| } | ||
|
|
||
| private Review getReview(Long id) { | ||
| return reviewRepository.findById(id).orElseThrow( |
Collaborator
There was a problem hiding this comment.
이 부분도 봐주셔야할 것 같아서 코멘트 달아놓겠습니다!
m-a-king
approved these changes
Dec 31, 2024
Comment on lines
+54
to
+66
|
|
||
| public boolean isAuthor(UUID volunteerId) { | ||
| return this.volunteerId.equals(volunteerId); | ||
| } | ||
|
|
||
| public void updateWith(ReviewUpdateRequestDto dto) { | ||
| this.title = dto.title(); | ||
| this.content = dto.content(); | ||
| } | ||
|
|
||
| public void updateWith(String imgUrl) { | ||
| this.imgUrl = imgUrl; | ||
| } |
Collaborator
There was a problem hiding this comment.
저는 이런 부분이 기본적이지만 상당히 느낌이 좋네요..
Collaborator
Author
|
@7zrv @m-a-king @ayoung-dev |
Collaborator
테스트가 없는 지금이 너무 좋네요. |
Collaborator
|
@leebs0521 |
Collaborator
저도 지금은 없어도 될 거 같아요! |
7zrv
approved these changes
Jan 1, 2025
- getById, getDetailById
- getById, getDetailById
- ReviewQueryUseCase 의존하도록 변경
- ReviewQueryUseCase 의존하도록 변경
- ReviewQueryUseCase 의존하도록 변경
leebs0521
force-pushed
the
feat/257-add-review-update-and-delete
branch
from
c41db0b to
c04d2a0
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
👩💻 요구 사항과 구현 내용
리뷰 삭제 기능
리뷰 수정 기능
리뷰 도메인 리팩토링
✅ PR 포인트 & 궁금한 점
ReviewValidator도입