[FEATURE] 모집글 시간 필드 추가 #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4 tasks
m-a-king
approved these changes
Jan 2, 2025
Collaborator
m-a-king
left a comment
m-a-king
left a comment
There was a problem hiding this comment.
수고하셨습니다. 싹 갈아엎으셨군요. 훨씬 깔끔해진 것 같아요!
...test/java/com/somemore/domains/recruitboard/service/validator/RecruitBoardValidatorTest.java
Show resolved
Hide resolved
7zrv
reviewed
Jan 2, 2025
src/main/java/com/somemore/domains/recruitboard/domain/RecruitmentInfo.java
Outdated
Show resolved
Hide resolved
7zrv
reviewed
Jan 2, 2025
src/main/java/com/somemore/domains/recruitboard/service/validator/RecruitBoardValidator.java
Show resolved
Hide resolved
ayoung-dev
approved these changes
Jan 2, 2025
Collaborator
ayoung-dev
left a comment
ayoung-dev
left a comment
There was a problem hiding this comment.
수고하셨습니다~
그리고 writer에서 author로 바꾸게된 이유가 무엇인지 궁금합니다!
src/main/java/com/somemore/domains/recruitboard/dto/request/RecruitBoardCreateRequestDto.java
Outdated
Show resolved
Hide resolved
src/main/java/com/somemore/domains/recruitboard/dto/response/RecruitBoardResponseDto.java
Outdated
Show resolved
Hide resolved
Collaborator
Author
이건 Review 쪽에서 이렇게 해버려서 메서드 이름 맞춰줄려고 했는데 어떤게 좋을려나요... |
Collaborator
|
저는 writer가 자연스러운 것 같아요~ |
Collaborator
저는 지금까지 writer로 써서 통일하면 좋을 거 같은데 혹시 다른 분들은 어떻게 쓰시나욤 |
Collaborator
|
저도 writer가 조금 더 자연스러운거 같습니다 |
- volunteer_hours
- volunteer_hours
- Integer -> int
- isAuthor -> isWriter
leebs0521
force-pushed
the
feat/247-add-recruit-board-hours
branch
from
0c5f8d6 to
074e77c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolved :
📌 과제 설명
모집글 시간 추가
모집글 Validator 추가
QueryUseCase에 의존하도록 리팩토링
패키지 구조 변경(query, command 패키지 제거)
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점