Merge pull request #265 from prgrms-web-devcourse-final-project/refactor/share-proposal-valid(WR9-152)

refactor 공유 제안 금칙어 검증

Author: HeoJeongHyeon

src/main/java/io/crops/warmletter/domain/share/service/ShareProposalService.java

@@ -1,5 +1,6 @@
 package io.crops.warmletter.domain.share.service;
 import io.crops.warmletter.domain.auth.facade.AuthFacade;
+import io.crops.warmletter.domain.badword.service.BadWordService;
 import io.crops.warmletter.domain.share.dto.request.ShareProposalRequest;
 import io.crops.warmletter.domain.share.dto.response.ShareInboxResponse;
 import io.crops.warmletter.domain.share.dto.response.ShareProposalDetailResponse;
@@ -29,12 +30,12 @@ public class ShareProposalService {
     private final ShareProposalLetterRepository shareProposalLetterRepository;
     private final SharePostRepository sharePostRepository;
     private final AuthFacade authFacade;
-
+    private final BadWordService badWordService;
     private final ApplicationEventPublisher notificationPublisher;
 
     @Transactional
     public ShareProposalResponse requestShareProposal(ShareProposalRequest request) {
-
+        badWordService.validateText(request.getMessage());
         Long requesterId = authFacade.getCurrentUserId();
 
         ShareProposal shareProposal = shareProposalRepository.save(request.toEntity(requesterId));

src/test/java/io/crops/warmletter/domain/share/service/ShareProposalServiceTest.java

@@ -1,5 +1,6 @@
 package io.crops.warmletter.domain.share.service;
 import io.crops.warmletter.domain.auth.facade.AuthFacade;
+import io.crops.warmletter.domain.badword.service.BadWordService;
 import io.crops.warmletter.domain.share.dto.request.ShareProposalRequest;
 import io.crops.warmletter.domain.share.dto.response.*;
 import io.crops.warmletter.domain.share.entity.SharePost;
@@ -48,6 +49,9 @@ class ShareProposalServiceTest {
     @Mock
     private ApplicationEventPublisher notificationPublisher;
 
+    @Mock
+    private BadWordService badWordService;
+
     @Mock
     private AuthFacade authFacade;
 
@@ -73,6 +77,7 @@ void requestShareProposal_Success() {
         when(authFacade.getCurrentUserId()).thenReturn(requesterId);
         when(shareProposalRepository.save(any(ShareProposal.class))).thenReturn(shareProposal);
         when(shareProposalRepository.findShareProposalWithZipCode(anyLong())).thenReturn(expectedResponse);
+        doNothing().when(badWordService).validateText(request.getMessage());
 
         ShareProposalResponse response = shareProposalService.requestShareProposal(request);
 
@@ -82,6 +87,7 @@ void requestShareProposal_Success() {
                 () -> assertEquals(expectedResponse.getZipCode(), response.getZipCode())
         );
 
+        verify(badWordService).validateText(request.getMessage());
         verify(authFacade).getCurrentUserId(); // AuthFacade 호출 검증 추가
         verify(shareProposalRepository).save(any(ShareProposal.class));
         verify(shareProposalLetterRepository).saveAll(anyList());
@@ -103,11 +109,13 @@ void requestShareProposal_ThrowsException_WhenLetterIdsInvalid() {
         );
 
         when(authFacade.getCurrentUserId()).thenReturn(currentUserId);
+        doNothing().when(badWordService).validateText(request.getMessage());
 
         // when & then
         NullPointerException exception = assertThrows(NullPointerException.class, () ->
                 shareProposalService.requestShareProposal(request));
 
+        verify(badWordService).validateText(request.getMessage());
         verify(authFacade).getCurrentUserId();
     }
 
@@ -219,6 +227,7 @@ void requestShareProposal_LetterSaveFail() {
         verify(shareProposalRepository).save(any(ShareProposal.class));
     }
 
+
     @Test
     @DisplayName("존재하지 않는 공유 제안 승인 실패")
     void approveShareProposal_NotFound() {