Skip to content

Commit 8774299

Browse files
committed
refactor join PR리뷰 관해 업데이트
- leftjoin -> join으로 수정 join으로 수정하여도 shareProposalLetter는 반드시 1개 이상의 공유 편지가 존재한다. null 값이 들어갈 수 없기에 이부분은 join으로 수정.
1 parent 6fa0511 commit 8774299

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/main/java/io/crops/warmletter/domain/share/repository/ShareProposalRepositoryImpl.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ public ShareProposalDetailResponse findShareProposalDetailById(Long shareProposa
7979
.from(SHARE_PROPOSAL)
8080
.join(REQUESTER_MEMBER).on(SHARE_PROPOSAL.requesterId.eq(REQUESTER_MEMBER.id))
8181
.join(RECIPIENT_MEMBER).on(SHARE_PROPOSAL.recipientId.eq(RECIPIENT_MEMBER.id))
82-
.leftJoin(shareProposalLetter).on(SHARE_PROPOSAL.id.eq(shareProposalLetter.proposalId))
82+
.join(shareProposalLetter).on(SHARE_PROPOSAL.id.eq(shareProposalLetter.proposalId))
8383
.leftJoin(letter).on(shareProposalLetter.letterId.eq(letter.id))
8484
.leftJoin(letterWriterMember).on(letter.writerId.eq(letterWriterMember.id))
8585
.leftJoin(letterReceiverMember).on(letter.receiverId.eq(letterReceiverMember.id))

0 commit comments

Comments
 (0)