Merge pull request #250 from prgrms-web-devcourse-final-project/refactor/share-refactoring(WR9-127)

Refactor/share refactoring(wr9 127)

Author: HeoJeongHyeon

src/main/java/io/crops/warmletter/domain/share/service/SharePostLikeService.java

@@ -27,6 +27,14 @@ public SharePostLikeResponse getLikeCountAndStatus(Long sharePostId) {
         if (sharePostId == null)
             throw new ShareInvalidInputValue();
 
-        return sharePostLikeRepository.getLikeCountAndStatus(sharePostId,memberId);
+        boolean isLikedInRedis = postLikeRedisManager.isLiked(sharePostId,memberId);
+
+        SharePostLikeResponse response = sharePostLikeRepository.getLikeCountAndStatus(sharePostId,memberId);
+
+        if (isLikedInRedis != response.isLiked()) {
+            return new SharePostLikeResponse(response.getLikeCount(), isLikedInRedis);
+        }
+
+        return response;
     }
 }

src/test/java/io/crops/warmletter/domain/share/service/SharePostLikeServiceTest.java

@@ -1,5 +1,4 @@
 package io.crops.warmletter.domain.share.service;
-
 import io.crops.warmletter.domain.auth.facade.AuthFacade;
 import io.crops.warmletter.domain.share.cache.PostLikeRedisManager;
 import io.crops.warmletter.domain.share.dto.response.SharePostLikeResponse;
@@ -11,7 +10,6 @@
 import org.mockito.InjectMocks;
 import org.mockito.Mock;
 import org.mockito.junit.jupiter.MockitoExtension;
-
 import static org.junit.jupiter.api.Assertions.*;
 import static org.mockito.Mockito.*;
 
@@ -56,6 +54,7 @@ void getLikeCountAndStatus_Success() {
         SharePostLikeResponse mockResponse = new SharePostLikeResponse(5L, true);
 
         when(authFacade.getCurrentUserId()).thenReturn(memberId);
+        when(redisManager.isLiked(sharePostId, memberId)).thenReturn(true);
         when(sharePostLikeRepository.getLikeCountAndStatus(sharePostId, memberId))
                 .thenReturn(mockResponse);
 
@@ -67,6 +66,7 @@ void getLikeCountAndStatus_Success() {
         assertEquals(5L, result.getLikeCount());
         assertTrue(result.isLiked());
         verify(authFacade).getCurrentUserId();
+        verify(redisManager).isLiked(sharePostId, memberId);
         verify(sharePostLikeRepository).getLikeCountAndStatus(sharePostId, memberId);
     }
 
@@ -79,6 +79,7 @@ void getLikeCountAndStatus_NotLiked() {
         SharePostLikeResponse mockResponse = new SharePostLikeResponse(10L, false);
 
         when(authFacade.getCurrentUserId()).thenReturn(memberId);
+        when(redisManager.isLiked(sharePostId, memberId)).thenReturn(false);
         when(sharePostLikeRepository.getLikeCountAndStatus(sharePostId, memberId))
                 .thenReturn(mockResponse);
 
@@ -90,6 +91,7 @@ void getLikeCountAndStatus_NotLiked() {
         assertEquals(10L, result.getLikeCount());
         assertFalse(result.isLiked());
         verify(authFacade).getCurrentUserId();
+        verify(redisManager).isLiked(sharePostId, memberId);
         verify(sharePostLikeRepository).getLikeCountAndStatus(sharePostId, memberId);
     }
 
@@ -106,6 +108,31 @@ void getLikeCountAndStatus_NullPostId() {
         });
 
         verify(authFacade).getCurrentUserId();
+        verify(redisManager, never()).isLiked(any(), any());
         verify(sharePostLikeRepository, never()).getLikeCountAndStatus(any(), any());
     }
+    @Test
+    @DisplayName("좋아요 개수와 상태 조회 - Redis는 false, DB는 true일 때 redis 우선 ")
+    void getLikeCountAndStatus_RedisNotLikedDbLiked() {
+        // given
+        Long sharePostId = 1L;
+        Long memberId = 1L;
+        SharePostLikeResponse mockResponse = new SharePostLikeResponse(10L, true);
+
+        when(authFacade.getCurrentUserId()).thenReturn(memberId);
+        when(redisManager.isLiked(sharePostId, memberId)).thenReturn(false);
+        when(sharePostLikeRepository.getLikeCountAndStatus(sharePostId, memberId))
+                .thenReturn(mockResponse);
+
+        // when
+        SharePostLikeResponse result = sharePostLikeService.getLikeCountAndStatus(sharePostId);
+
+        // then
+        assertNotNull(result);
+        assertEquals(10L, result.getLikeCount());
+        assertFalse(result.isLiked());
+        verify(authFacade).getCurrentUserId();
+        verify(redisManager).isLiked(sharePostId, memberId);
+        verify(sharePostLikeRepository).getLikeCountAndStatus(sharePostId, memberId);
+    }
 }