Skip to content

Commit 0310b57

Browse files
committed
fix: code smell 제거
1 parent 67b485a commit 0310b57

File tree

5 files changed

+4
-18
lines changed

5 files changed

+4
-18
lines changed

src/main/java/org/dfbf/soundlink/domain/user/config/RedisConfig.java

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,9 +33,7 @@ public RedisConnectionFactory redisConnectionFactory(){
3333
public RedisTemplate<String,Object> redisTemplate(){
3434
RedisTemplate<String,Object> redisTemplate = new RedisTemplate<>();
3535
redisTemplate.setConnectionFactory(redisConnectionFactory());
36-
//key,value를 email,authCode로 구현. String으로 직렬화
37-
redisTemplate.setKeySerializer(new StringRedisSerializer());
38-
//redisTemplate.setValueSerializer(new StringRedisSerializer());
36+
redisTemplate.setKeySerializer(new StringRedisSerializer()); //key,value를 email,authCode로 구현. String으로 직렬화
3937
redisTemplate.setValueSerializer(new GenericJackson2JsonRedisSerializer());
4038

4139
return redisTemplate;
Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
package org.dfbf.soundlink.domain.user.dto.request;
22

3-
import com.fasterxml.jackson.annotation.JsonInclude;
4-
53
import java.util.Optional;
64

75
public record UserUpdateDto(
@@ -14,7 +12,4 @@ public record UserUpdateDto(
1412
Optional<String> artist,
1513
Optional<String> albumImage
1614
) {
17-
public void toString2() {
18-
System.out.println("UserUpdateDto(email=" + email + ", loginId=" + loginId + ", nickName=" + nickName + ", password=" + password + ", spotifyId=" + spotifyId);
19-
}
2015
}

src/main/java/org/dfbf/soundlink/domain/user/repository/UserRepository.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,8 @@
11
package org.dfbf.soundlink.domain.user.repository;
22

3-
import io.lettuce.core.dynamic.annotation.Param;
4-
import org.dfbf.soundlink.domain.user.dto.response.UserMyPageDto;
53
import org.dfbf.soundlink.domain.user.entity.User;
64
import org.dfbf.soundlink.domain.user.repository.dsl.UserRepositoryCustom;
7-
import org.springframework.cache.annotation.Cacheable;
85
import org.springframework.data.jpa.repository.JpaRepository;
9-
import org.springframework.data.jpa.repository.Query;
106

117
import java.util.Optional;
128

src/main/java/org/dfbf/soundlink/domain/user/repository/dsl/UserRepositoryCustom.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import org.dfbf.soundlink.domain.user.dto.response.UserMyPageDto;
44
import org.dfbf.soundlink.domain.user.entity.User;
5-
import org.springframework.cache.annotation.Cacheable;
65
import org.springframework.data.repository.query.Param;
76

87
import java.util.Optional;

src/main/java/org/dfbf/soundlink/domain/user/service/UserService.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,6 @@ public ResponseResult updateUser(Long userId, UserUpdateDto userUpdateDto) {
8888
* orElseGet -> null일때만 실행 (함수O, 람다O)
8989
*/
9090

91-
userUpdateDto.toString2();
92-
9391
try {
9492
User user = userRepository.findByUserIdWithCache(userId)
9593
.orElseThrow(NoUserDataException::new);
@@ -254,7 +252,7 @@ public ResponseResult login(LoginReqDto loginReqDto, HttpServletResponse respons
254252

255253
return new ResponseResult(responseBody);
256254
} catch (Exception e) {
257-
System.out.println("[ERROR] " + e.getMessage());
255+
log.info("[ERROR] " + e.getMessage());
258256
return new ResponseResult(ErrorCode. INTERNAL_SERVER_ERROR);
259257
}
260258
}
@@ -356,8 +354,8 @@ public ResponseResult reissueToken(HttpServletRequest request, HttpServletRespon
356354
String newAccessToken = jwtProvider.createAccessToken(userId);
357355
String newRefreshToken = jwtProvider.createRefreshToken(userId);
358356

359-
System.out.println("New AccessToken: " + newAccessToken);
360-
System.out.println("New RefreshToken: " + newRefreshToken);
357+
log.info("New AccessToken: " + newAccessToken);
358+
log.info("New RefreshToken: " + newRefreshToken);
361359

362360
//레디스에 새로운 리프레시 토큰 업데이트!
363361
tokenService.updateRefreshToken(userId, newRefreshToken);

0 commit comments

Comments
 (0)