refactor: 코드스멜 제거

Author: HYEONSIKOH

src/main/java/org/dfbf/soundlink/domain/chat/service/ChatRoomService.java

@@ -17,11 +17,13 @@ public class ChatRoomService {
     private final RedisTemplate<String, Object> redisTemplate;
     private final EmotionRecordRepository emotionRecordRepository;
 
+    private final static String CHAT_REQUEST_KEY = "chatRequest";
+
     // 요청을 Redis에 저장 (TTL: 60초)
-    public ResponseResult saveRequestToRedis(Long requestUserId, Long EmotionRecordId) {
+    public ResponseResult saveRequestToRedis(Long requestUserId, Long emotionRecordId) {
         try {
             // 응답자의 ID를 EmotionRecord에서 가져옴
-            Long responseUserId = emotionRecordRepository.findById(EmotionRecordId)
+            Long responseUserId = emotionRecordRepository.findById(emotionRecordId)
                     .orElseThrow(EmotionRecordNotFoundException::new)
                     .getUser()
                     .getUserId();
@@ -32,15 +34,15 @@ public ResponseResult saveRequestToRedis(Long requestUserId, Long EmotionRecordI
             }
 
             // Redis에 이미 requestUserId가 포함되어 있는 경우
-            if (!redisTemplate.keys("chatRequest" + requestUserId + "to*").isEmpty()) {
-                String firstKey = redisTemplate.keys("chatRequest" + requestUserId + "to*").iterator().next(); // 첫 번째 키 가져오기
+            if (!redisTemplate.keys(CHAT_REQUEST_KEY + requestUserId + "to*").isEmpty()) {
+                String firstKey = redisTemplate.keys(CHAT_REQUEST_KEY + requestUserId + "to*").iterator().next(); // 첫 번째 키 가져오기
                 Long ttl = redisTemplate.getExpire(firstKey);
                 return new ResponseResult(400, ttl + "초 후에 다시 시도해주세요.");
             }
 
             // Key & Request 객체 생성
-            String key = "chatRequest" + requestUserId + "to" + EmotionRecordId;
-            ChatRequest chatRequest = new ChatRequest(requestUserId, responseUserId, EmotionRecordId);
+            String key = CHAT_REQUEST_KEY + requestUserId + "to" + emotionRecordId;
+            ChatRequest chatRequest = new ChatRequest(requestUserId, responseUserId, emotionRecordId);
 
             // Redis 저장
             redisTemplate.opsForValue().set(key, chatRequest, Duration.ofSeconds(61));
@@ -54,19 +56,13 @@ public ResponseResult saveRequestToRedis(Long requestUserId, Long EmotionRecordI
     }
 
     // 요청을 삭제
-    public ResponseResult deleteRequestFromRedis(Long requestUserId, Long EmotionRecordId) {
+    public ResponseResult deleteRequestFromRedis(Long requestUserId, Long emotionRecordId) {
         try {
-            // 응답자의 ID를 EmotionRecord에서 가져옴
-            Long responseUserId = emotionRecordRepository.findById(EmotionRecordId)
-                    .orElseThrow(EmotionRecordNotFoundException::new)
-                    .getUser()
-                    .getUserId();
-
             // Key 생성
-            String key = "chatRequest" + requestUserId + "to" + EmotionRecordId;
+            String key = CHAT_REQUEST_KEY + requestUserId + "to" + emotionRecordId;
 
             // Redis에 Key가 존재하는 경우 삭제 (KEY가 없는 경우 400)
-            if (redisTemplate.hasKey(key)) {
+            if (Boolean.TRUE.equals(redisTemplate.hasKey(key))) {
                 redisTemplate.delete(key);
                 return new ResponseResult(ErrorCode.SUCCESS);
             } else {

src/main/java/org/dfbf/soundlink/domain/user/service/UserService.java

@@ -360,9 +360,7 @@ public ResponseResult reissueToken(HttpServletRequest request, HttpServletRespon
                 responseBody.put("accessToken", newAccessToken);
 
                 // Redis에서 user::userID TTL을 30분으로 다시 갱신
-                redisTemplate.expire("user::" + userId, 30 * 60, TimeUnit.SECONDS);
-
-
+                redisTemplate.expire("user::" + userId, 30L * 60, TimeUnit.SECONDS);
 
                 return new ResponseResult(ErrorCode.SUCCESS, responseBody);
             } else {