Skip to content

Commit 87cdc14

Browse files
[Fix] 블록리스트 API 리팩토링: DTO 제거 및 매개변수 간소화, 메서드 및 변수명 수정
1 parent 6cc8380 commit 87cdc14

File tree

5 files changed

+8
-22
lines changed

5 files changed

+8
-22
lines changed

src/main/java/org/dfbf/soundlink/domain/blocklist/controller/BlockListController.java

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,6 @@
33
import io.swagger.v3.oas.annotations.Operation;
44
import io.swagger.v3.oas.annotations.tags.Tag;
55
import lombok.RequiredArgsConstructor;
6-
import org.dfbf.soundlink.domain.blocklist.dto.BlockListReq;
7-
import org.dfbf.soundlink.domain.blocklist.dto.BlockReq;
86
import org.dfbf.soundlink.domain.blocklist.service.BlockListService;
97
import org.dfbf.soundlink.global.exception.ResponseResult;
108
import org.springframework.security.core.annotation.AuthenticationPrincipal;
@@ -24,9 +22,9 @@ public class BlockListController {
2422
)
2523
public ResponseResult blockUser(
2624
@AuthenticationPrincipal Long userId,
27-
@RequestBody BlockReq req
25+
@RequestBody String tag
2826
) {
29-
return blockListService.blockUser(userId, req.tag());
27+
return blockListService.blockUser(userId, tag);
3028
}
3129

3230
@DeleteMapping
@@ -36,9 +34,9 @@ public ResponseResult blockUser(
3634
)
3735
public ResponseResult unblockUser(
3836
@AuthenticationPrincipal Long userId,
39-
@RequestBody BlockListReq req
37+
@RequestBody Long blocklistId
4038
) {
41-
return blockListService.unblockUser(userId, req.blocklistId());
39+
return blockListService.unblockUser(userId, blocklistId);
4240
}
4341

4442
@GetMapping("/mypage/blackListSearch")

src/main/java/org/dfbf/soundlink/domain/blocklist/dto/BlockListReq.java

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/main/java/org/dfbf/soundlink/domain/blocklist/dto/BlockReq.java

Lines changed: 0 additions & 6 deletions
This file was deleted.

src/main/java/org/dfbf/soundlink/domain/blocklist/repository/BlockListRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ Optional<Blocklist> findByUserIdAndLoginId(
3636
"WHERE b.user.userId = :userId " +
3737
"AND b.blockedUser.userId = :blockedUserId"
3838
)
39-
Optional<Blocklist> findByUserIdAndBlockedUserId(
39+
Optional<Blocklist> findByUserIdAndBlocklistId(
4040
@Param("userId") Long userId,
4141
@Param("blockedUserId") Long blockedUserId
4242
);

src/main/java/org/dfbf/soundlink/domain/blocklist/service/BlockListService.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -75,10 +75,10 @@ public ResponseResult blockUser(Long userId, String tag) {
7575
}
7676

7777
@Transactional
78-
public ResponseResult unblockUser(Long userId, Long blockedUserId) {
78+
public ResponseResult unblockUser(Long userId, Long blocklistId) {
7979
try {
80-
Blocklist block = blockListRepository.findByUserIdAndBlockedUserId(
81-
userId, blockedUserId
80+
Blocklist block = blockListRepository.findByUserIdAndBlocklistId(
81+
userId, blocklistId
8282
).orElseThrow(BlockingUserNotFound::new);
8383

8484
blockListRepository.delete(block);

0 commit comments

Comments
 (0)