Skip to content

Commit 005f1f1

Browse files
committed
refactor: 프로필 이미지 가져오는 로직 수정
프로필 이미지 칼럼명 변경 및 주석 제거
1 parent b43193a commit 005f1f1

File tree

7 files changed

+36
-28
lines changed

7 files changed

+36
-28
lines changed

src/main/java/com/example/log4u/common/oauth2/dto/GoogleResponseDto.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public String getNickname() {
3838
}
3939

4040
@Override
41-
public String getProfileImageUrl() {
41+
public String getProfileImage() {
4242
return attribute.get("picture").toString();
4343
}
4444

src/main/java/com/example/log4u/common/oauth2/dto/KakaoResponseDto.java

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,20 @@
88

99
@RequiredArgsConstructor
1010
public class KakaoResponseDto implements OAuth2Response {
11+
12+
private static final String KAKAO_ACCOUNT = "kakao_account";
13+
1114
@Override
1215
public String getNickname() {
1316
return "";
1417
}
1518

1619
@Override
17-
public String getProfileImageUrl() {
18-
return "";
20+
public String getProfileImage() {
21+
// kakao_account.profile.profile_image_url 형태로 응답
22+
Map<String, Object> account = (Map<String, Object>)attribute.get(KAKAO_ACCOUNT);
23+
Map<String, Object> profile = (Map<String, Object>)account.get("profile");
24+
return (String)profile.get("profile_image_url");
1925
}
2026

2127
private final Map<String, Object> attribute;
@@ -32,13 +38,13 @@ public String getProviderId() {
3238

3339
@Override
3440
public String getEmail() {
35-
Map<String, Object> account = (Map<String, Object>)attribute.get("kakao_account");
41+
Map<String, Object> account = (Map<String, Object>)attribute.get(KAKAO_ACCOUNT);
3642
return (String)account.get("email");
3743
}
3844

3945
@Override
4046
public String getName() {
41-
Map<String, Object> account = (Map<String, Object>)attribute.get("kakao_account");
47+
Map<String, Object> account = (Map<String, Object>)attribute.get(KAKAO_ACCOUNT);
4248
Map<String, Object> profile = (Map<String, Object>)account.get("profile");
4349
return profile.get("nickname").toString();
4450
}

src/main/java/com/example/log4u/common/oauth2/dto/NaverResponseDto.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public String getNickname() {
3838
}
3939

4040
@Override
41-
public String getProfileImageUrl() {
41+
public String getProfileImage() {
4242
return attribute.get("profile_image").toString();
4343
}
4444

src/main/java/com/example/log4u/common/oauth2/dto/OAuth2Response.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,5 +13,5 @@ public interface OAuth2Response {
1313

1414
String getNickname();
1515

16-
String getProfileImageUrl();
16+
String getProfileImage();
1717
}

src/main/java/com/example/log4u/common/oauth2/dto/UserCreateRequestDto.java renamed to src/main/java/com/example/log4u/domain/user/dto/UserCreateRequestDto.java

Lines changed: 16 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,53 @@
1-
package com.example.log4u.common.oauth2.dto;
1+
package com.example.log4u.domain.user.dto;
22

3+
import com.example.log4u.common.oauth2.dto.OAuth2Response;
4+
import com.example.log4u.domain.user.entity.SocialType;
35
import com.example.log4u.domain.user.entity.User;
46

5-
public record UserCreateRequestDto (
6-
String provider,
7+
public record UserCreateRequestDto(
8+
SocialType socialType,
79
String providerId,
810
Long userId,
911
String name,
1012
String email,
1113
String nickname,
12-
String profileImageUrl,
14+
String profileImage,
1315
String role
14-
){
15-
public static User toEntity(UserCreateRequestDto userCreateRequestDto){
16+
) {
17+
public static User toEntity(UserCreateRequestDto userCreateRequestDto) {
1618
return User.builder()
17-
.provider(userCreateRequestDto.provider)
19+
.socialType(userCreateRequestDto.socialType)
1820
.providerId(userCreateRequestDto.providerId)
1921
.name(userCreateRequestDto.name)
2022
.email(userCreateRequestDto.email)
2123
.nickname(userCreateRequestDto.nickname)
22-
.profileImageUrl(userCreateRequestDto.profileImageUrl)
24+
.profileImage(userCreateRequestDto.profileImage)
2325
.role(userCreateRequestDto.role)
2426
.build();
2527
}
2628

27-
public static UserCreateRequestDto fromOAuth2Response(OAuth2Response oAuth2Response, Long userId, String role){
29+
public static UserCreateRequestDto fromOAuth2Response(OAuth2Response oAuth2Response, Long userId, String role) {
2830
return new UserCreateRequestDto(
29-
oAuth2Response.getProvider(),
31+
oAuth2Response.getSocialType(),
3032
oAuth2Response.getProviderId(),
3133
userId,
3234
oAuth2Response.getName(),
3335
oAuth2Response.getEmail(),
3436
oAuth2Response.getNickname(),
35-
oAuth2Response.getProfileImageUrl(),
37+
oAuth2Response.getProfileImage(),
3638
role
3739
);
3840
}
3941

40-
public static UserCreateRequestDto fromEntity(User user){
42+
public static UserCreateRequestDto fromEntity(User user) {
4143
return new UserCreateRequestDto(
42-
user.getProvider(),
44+
user.getSocialType(),
4345
user.getProviderId(),
4446
user.getUserId(),
4547
user.getName(),
4648
user.getEmail(),
4749
user.getNickname(),
48-
user.getProfileImageUrl(),
50+
user.getProfileImage(),
4951
user.getRole()
5052
);
5153
}

src/main/java/com/example/log4u/domain/user/entity/User.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class User extends BaseEntity {
4040
@Column(nullable = false)
4141
private String providerId;
4242

43-
private String profileImageUrl;
43+
private String profileImage;
4444

4545
@Column(nullable = false)
4646
private String role;
@@ -51,13 +51,13 @@ public class User extends BaseEntity {
5151

5252
private String statusMessage;
5353

54-
// @Column(nullable = false)
55-
// private boolean isPremium;
54+
@Column(nullable = false)
55+
private boolean isPremium = false;
5656

5757
public void updateOauth2Profile(OAuth2Response oAuth2Response) {
5858
this.email = oAuth2Response.getEmail();
5959
this.name = oAuth2Response.getName();
6060
this.nickname = oAuth2Response.getNickname();
61-
this.profileImageUrl = oAuth2Response.getProfileImageUrl();
61+
this.profileImage = oAuth2Response.getProfileImage();
6262
}
6363
}

src/test/java/com/example/log4u/fixture/UserFixture.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public static User createUserFixture() {
99
return User.builder()
1010
.userId(1L)
1111
.nickname("testUser")
12-
.providerId(123L)
12+
.providerId("123")
1313
1414
.socialType(SocialType.KAKAO)
1515
.statusMessage("상태 메시지")
@@ -21,7 +21,7 @@ public static User createUserFixture(Long userId) {
2121
return User.builder()
2222
.userId(userId)
2323
.nickname("testUser" + userId)
24-
.providerId(100L + userId)
24+
.providerId("100 + userId")
2525
.email("test" + userId + "@example.com")
2626
.socialType(SocialType.KAKAO)
2727
.statusMessage("상태 메시지 " + userId)
@@ -33,7 +33,7 @@ public static User createPremiumUserFixture(Long userId) {
3333
return User.builder()
3434
.userId(userId)
3535
.nickname("premiumUser" + userId)
36-
.providerId(1000L + userId)
36+
.providerId("1000L + userId")
3737
.email("premium" + userId + "@example.com")
3838
.socialType(SocialType.KAKAO)
3939
.statusMessage("프리미엄 사용자")

0 commit comments

Comments
 (0)