Merge pull request #256 from june3780/refactoring_advice

Refactoring advice

Author: june3780

src/main/java/com/grepp/spring/infra/error/ApiCustomExceptionAdvice.java

@@ -0,0 +1,26 @@
+package com.grepp.spring.infra.error;
+
+import com.grepp.spring.infra.error.exceptions.CustomException;
+import com.grepp.spring.infra.response.ApiResponse;
+import com.grepp.spring.infra.response.error.ErrorCode;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.core.annotation.Order;
+import org.springframework.http.ResponseEntity;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.RestControllerAdvice;
+
+@Slf4j
+@RestControllerAdvice(basePackages = "com.grepp.spring.app.controller.api")
+@Order(0)
+public class ApiCustomExceptionAdvice {
+
+    @ExceptionHandler(CustomException.class)
+    public ResponseEntity<ApiResponse<Object>> handleCustomException(CustomException ex) {
+        ErrorCode errorCode = ex.getErrorCode();
+        log.warn("API CustomException occurred: code={}, message={}", errorCode.code(), errorCode.message());
+
+        return ResponseEntity
+            .status(errorCode.status())
+            .body(ApiResponse.error(errorCode));
+    }
+}

src/main/java/com/grepp/spring/infra/error/GlobalExceptionAdvice.java

@@ -0,0 +1,56 @@
+package com.grepp.spring.infra.error;
+
+import com.grepp.spring.infra.response.ApiResponse;
+import com.grepp.spring.infra.response.ResponseCode;
+import lombok.extern.slf4j.Slf4j;
+import org.springframework.http.ResponseEntity;
+import org.springframework.validation.BindException;
+import org.springframework.web.bind.MethodArgumentNotValidException;
+import org.springframework.web.bind.annotation.ExceptionHandler;
+import org.springframework.web.bind.annotation.RestControllerAdvice;
+
+import java.util.HashMap;
+import java.util.Map;
+
+@Slf4j
+@RestControllerAdvice
+public class GlobalExceptionAdvice {
+
+    @ExceptionHandler({MethodArgumentNotValidException.class, BindException.class})
+    public ResponseEntity<ApiResponse<Map<String, String>>> validationExHandler(BindException ex) {
+        Map<String, String> errors = new HashMap<>();
+        ex.getBindingResult().getFieldErrors().forEach(error -> {
+            String fieldName = error.getField();
+            String errorMessage = error.getDefaultMessage();
+            errors.put(fieldName, errorMessage);
+        });
+        log.warn("Validation error: {}", errors);
+        return ResponseEntity
+            .status(ResponseCode.BAD_REQUEST.status())
+            .body(ApiResponse.error(ResponseCode.BAD_REQUEST, errors));
+    }
+
+    @ExceptionHandler(IllegalArgumentException.class)
+    public ResponseEntity<ApiResponse<String>> illegalArgumentExHandler(IllegalArgumentException ex) {
+        log.warn("Illegal argument: {}", ex.getMessage());
+        return ResponseEntity
+            .status(ResponseCode.BAD_REQUEST.status())
+            .body(ApiResponse.error(ResponseCode.BAD_REQUEST, ex.getMessage()));
+    }
+
+    @ExceptionHandler(IllegalStateException.class)
+    public ResponseEntity<ApiResponse<String>> illegalStateExHandler(IllegalStateException ex) {
+        log.warn("Illegal state: {}", ex.getMessage());
+        return ResponseEntity
+            .status(ResponseCode.BAD_REQUEST.status())
+            .body(ApiResponse.error(ResponseCode.BAD_REQUEST, ex.getMessage()));
+    }
+
+    @ExceptionHandler(Exception.class)
+    public ResponseEntity<ApiResponse<String>> allUncaughtExHandler(Exception ex) {
+        log.error("Unhandled exception", ex);
+        return ResponseEntity
+            .status(ResponseCode.INTERNAL_SERVER_ERROR.status())
+            .body(ApiResponse.error(ResponseCode.INTERNAL_SERVER_ERROR, "서버 내부 오류가 발생했습니다."));
+    }
+}

src/main/java/com/grepp/spring/infra/error/eventAdvice/EventExceptionAdvice.java

@@ -0,0 +1,19 @@
+package com.grepp.spring.infra.error.exceptions;
+
+import com.grepp.spring.infra.response.error.ErrorCode;
+import lombok.Getter;
+
+@Getter
+public abstract class CustomException extends RuntimeException {
+    private final ErrorCode errorCode;
+
+    public CustomException(ErrorCode errorCode) {
+        super(errorCode.message());
+        this.errorCode = errorCode;
+    }
+
+    public CustomException(ErrorCode errorCode, Exception e) {
+        super(errorCode.message(), e);
+        this.errorCode = errorCode;
+    }
+}

src/main/java/com/grepp/spring/infra/error/exceptions/CustomException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class AlreadyConfirmedScheduleException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class AlreadyConfirmedScheduleException extends CustomException {
 
     public AlreadyConfirmedScheduleException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public AlreadyConfirmedScheduleException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }

src/main/java/com/grepp/spring/infra/error/exceptions/event/AlreadyConfirmedScheduleException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class AlreadyJoinedEventException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class AlreadyJoinedEventException extends CustomException {
 
     public AlreadyJoinedEventException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public AlreadyJoinedEventException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }

src/main/java/com/grepp/spring/infra/error/exceptions/event/AlreadyJoinedEventException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class EventAlreadyCompletedException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class EventAlreadyCompletedException extends CustomException {
 
     public EventAlreadyCompletedException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public EventAlreadyCompletedException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }

src/main/java/com/grepp/spring/infra/error/exceptions/event/EventAlreadyCompletedException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class EventAuthenticationException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class EventAuthenticationException extends CustomException {
 
     public EventAuthenticationException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public EventAuthenticationException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }

src/main/java/com/grepp/spring/infra/error/exceptions/event/EventAuthenticationException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class EventNotFoundException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class EventNotFoundException extends CustomException {
 
     public EventNotFoundException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public EventNotFoundException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }

src/main/java/com/grepp/spring/infra/error/exceptions/event/EventNotFoundException.java

@@ -1,23 +1,18 @@
 package com.grepp.spring.infra.error.exceptions.event;
 
+import com.grepp.spring.infra.error.exceptions.CustomException;
 import com.grepp.spring.infra.response.EventErrorCode;
 import lombok.extern.slf4j.Slf4j;
 
 @Slf4j
-public class InvalidEventDataException extends RuntimeException {
-
-    private final EventErrorCode code;
+public class InvalidEventDataException extends CustomException {
 
     public InvalidEventDataException(EventErrorCode code) {
-        this.code = code;
+        super(code);
     }
 
     public InvalidEventDataException(EventErrorCode code, Exception e) {
-        this.code = code;
-        log.error(e.getMessage(), e);
+        super(code, e);
     }
 
-    public EventErrorCode code() {
-        return code;
-    }
 }